#57: Not support Unicode name

Author: proofrock

src/web_service.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"database/sql"
 	"errors"
+	"net/url"
 	"strings"
 	"time"
 
@@ -201,6 +202,18 @@ func handler(databaseId string) func(c *fiber.Ctx) error {
 
 		isListResultSet := body.ResultFormat != nil && strings.EqualFold(*body.ResultFormat, "list")
 
+		// Fix for Issue #57: URL-decode the database ID parameter.
+		// The databaseId parameter is the URL-encoded form passed from the route registration
+		// (e.g., "%E6%95%B0%E6%8D%AE%E5%BA%93"). We decode it to get the human-readable ID
+		// (e.g., "数据库") to look it up in the dbs map which stores human-readable IDs.
+		// The parameter comes in URL-encoded (e.g., "%E6%95%B0%E6%8D%AE%E5%BA%93")
+		// and must be decoded to match the human-readable ID stored in the
+		// dbs map (e.g., "数据库").
+		databaseId, err := url.PathUnescape(databaseId)
+		if err != nil {
+			return newWSErrorf(-1, fiber.StatusBadRequest, "invalid URL path encoding: %s", err.Error())
+		}
+
 		db, found := dbs[databaseId]
 		if !found {
 			return newWSErrorf(-1, fiber.StatusNotFound, "database with ID '%s' not found", databaseId)

src/ws4sqlite.go

@@ -20,6 +20,7 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"net/url"
 	"os"
 	"strings"
 	"sync"
@@ -309,10 +310,16 @@ func launch(cfg config, disableKeepAlive4Tests bool) {
 
 		handlers = append(handlers, handler(db.Id))
 
-		app.Post(fmt.Sprintf("/%s", db.Id), handlers...)
+		// Fix for Issue #57: Support Unicode database names in HTTP routes
+		// URL-encode the database ID for route registration to handle Unicode characters.
+		// When clients send requests with Unicode (e.g., "数据库"), browsers/curl will
+		// URL-encode it (e.g., "%E6%95%B0%E6%8D%AE%E5%BA%93"). We must register routes
+		// with the encoded form so Fiber can match incoming requests.
+		encodedId := url.PathEscape(db.Id)
+		app.Post(fmt.Sprintf("/%s", encodedId), handlers...)
 
 		if db.CORSOrigin != "" {
-			app.Options(fmt.Sprintf("/%s", db.Id), handlers...)
+			app.Options(fmt.Sprintf("/%s", encodedId), handlers...)
 		}
 	}
 

src/ws4sqlite_test.go

@@ -1564,3 +1564,98 @@ func TestFileServerWithOverlap(t *testing.T) {
 
 	Shutdown()
 }
+
+func TestUnicodeDatabaseName(t *testing.T) {
+	// Test for Issue #57: Unicode database names should work properly
+	os.Remove("../test/数据库.db")
+
+	cfg := config{
+		Bindhost: "0.0.0.0",
+		Port:     12321,
+		Databases: []db{
+			{
+				Id:   "数据库",
+				Path: "../test/数据库.db",
+			},
+		},
+	}
+	go launch(cfg, true)
+
+	time.Sleep(time.Second)
+
+	if !fileExists("../test/数据库.db") {
+		t.Error("Unicode db file not created")
+		return
+	}
+
+	// Create a table
+	req := request{
+		Transaction: []requestItem{
+			{
+				Statement: "CREATE TABLE test (id INTEGER PRIMARY KEY, name TEXT)",
+			},
+		},
+	}
+
+	code, _, res := call("数据库", req, t)
+
+	if code != 200 {
+		t.Error("Create table failed with code", code)
+		return
+	}
+
+	if !res.Results[0].Success {
+		t.Error("Create table did not succeed")
+		return
+	}
+
+	// Insert data
+	req = request{
+		Transaction: []requestItem{
+			{
+				Statement: "INSERT INTO test (name) VALUES ('test data')",
+			},
+		},
+	}
+
+	code, _, res = call("数据库", req, t)
+
+	if code != 200 {
+		t.Error("Insert failed with code", code)
+		return
+	}
+
+	if !res.Results[0].Success {
+		t.Error("Insert did not succeed")
+		return
+	}
+
+	// Query data
+	req = request{
+		Transaction: []requestItem{
+			{
+				Query: "SELECT * FROM test",
+			},
+		},
+	}
+
+	code, _, res = call("数据库", req, t)
+
+	if code != 200 {
+		t.Error("Query failed with code", code)
+		return
+	}
+
+	if !res.Results[0].Success {
+		t.Error("Query did not succeed")
+		return
+	}
+
+	if len(res.Results[0].ResultSet) != 1 {
+		t.Error("Expected 1 row, got", len(res.Results[0].ResultSet))
+		return
+	}
+
+	Shutdown()
+	os.Remove("../test/数据库.db")
+}