From 265761733e0ba4ec5983ffcea55764e46ef3bc0b Mon Sep 17 00:00:00 2001
From: Anthony Ettinger <anthony@chovy.com>
Date: Tue, 28 Jul 2026 03:17:31 +0000
Subject: [PATCH] fix(leads): honour scan_prospects on the discovery path too
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The setting was threaded into the runner's stage-3 research call and
nowhere else, so the discovery top-up — the path that sees every newly
discovered domain — kept queueing a scan per candidate no matter what
the campaign asked for. A campaign with scanning off still scanned
everything it found, which is exactly the behaviour the setting exists
to prevent.

Observable in the audits table: a tick on a scan_prospects=false
campaign produced fresh audits of artstation.com, adobe.com and every
other domain discovery turned up.

The guard asserts every researchProspect call in the runner passes
skipScan, and derives it from the campaign rather than hardcoding it.
Source-level, because the alternative is standing up the runner with a
live database and a scan worker to watch for a call that should not
happen. Reverting the fix fails it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 lib/outreach/runner.ts         |  5 +++++
 tests/runner-scan-gate.test.ts | 41 ++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)
 create mode 100644 tests/runner-scan-gate.test.ts

diff --git a/lib/outreach/runner.ts b/lib/outreach/runner.ts
index a6773ed4..d2fc6c7a 100644
--- a/lib/outreach/runner.ts
+++ b/lib/outreach/runner.ts
@@ -256,6 +256,11 @@ export async function runEmailCampaignTick(campaign: CampaignRow): Promise<TickR
         campaignId: campaign.id,
         discoveredVia: candidate.via,
         discoveryLabel: candidate.label,
+        // The setting has to be honoured here too, not only when researching
+        // prospects that are already on the board. This is the path that sees
+        // every newly discovered domain, so missing it meant a campaign with
+        // scanning off still scanned everything it found.
+        skipScan: !campaign.scan_prospects,
       });
       if (res.status === "scanning") {
         result.scansStarted += 1;
diff --git a/tests/runner-scan-gate.test.ts b/tests/runner-scan-gate.test.ts
new file mode 100644
index 00000000..23d4f44b
--- /dev/null
+++ b/tests/runner-scan-gate.test.ts
@@ -0,0 +1,41 @@
+import { describe, it, expect } from "vitest";
+import { readFileSync } from "node:fs";
+import path from "node:path";
+
+// scan_prospects has to be honoured at every point the runner researches a
+// prospect, not just the obvious one. It was originally threaded through the
+// stage-3 call only, so the discovery top-up — the path that sees every newly
+// discovered domain — went on scanning everything a campaign found, which is
+// precisely the behaviour the setting exists to stop.
+//
+// Asserted against the source because the alternative is standing up the
+// whole runner with a live database and a scan worker to observe a call that
+// should not happen.
+
+const RUNNER = path.join(process.cwd(), "lib/outreach/runner.ts");
+
+describe("campaign runner honours scan_prospects", () => {
+  const source = readFileSync(RUNNER, "utf8");
+
+  // Every researchProspect({...}) call in the runner.
+  const calls = [...source.matchAll(/researchProspect\(\{([\s\S]*?)\}\)/g)].map((m) => m[1]);
+
+  it("researches prospects in more than one place", () => {
+    // If this drops to one, the test below stops proving anything.
+    expect(calls.length).toBeGreaterThanOrEqual(2);
+  });
+
+  it("passes skipScan at every research call site", () => {
+    const missing = calls.filter((body) => !body.includes("skipScan"));
+    expect(
+      missing,
+      `researchProspect call(s) without skipScan — a campaign with scanning off would still scan:\n${missing.join("\n---\n")}`,
+    ).toHaveLength(0);
+  });
+
+  it("derives skipScan from the campaign setting rather than hardcoding it", () => {
+    for (const body of calls) {
+      expect(body).toMatch(/skipScan:\s*!campaign\.scan_prospects/);
+    }
+  });
+});