From 515ea3c70ff5d58017b54ae70413267da7d3e7c6 Mon Sep 17 00:00:00 2001 From: Naveed Sajjad <88137903+naveedsajjdawan@users.noreply.github.com> Date: Wed, 14 Oct 2026 14:19:14 +0500 Subject: [PATCH 1/3] fix: apply padding prop to PageLayout sidebar --- packages/react/src/PageLayout/PageLayout.module.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/react/src/PageLayout/PageLayout.module.css b/packages/react/src/PageLayout/PageLayout.module.css index 526fa6d8ee5..d2ca689e1f2 100644 --- a/packages/react/src/PageLayout/PageLayout.module.css +++ b/packages/react/src/PageLayout/PageLayout.module.css @@ -840,6 +840,8 @@ .Sidebar { width: var(--pane-width-size); height: 100%; + /* stylelint-disable-next-line primer/spacing */ + padding: var(--spacing); overflow: auto; &:where([data-resizable]) { From d69ea15ed167576b2583b711eb55ad3c09804490 Mon Sep 17 00:00:00 2001 From: Naveed Sajjad <88137903+naveedsajjdawan@users.noreply.github.com> Date: Wed, 14 Oct 2026 14:20:38 +0500 Subject: [PATCH 2/3] test: cover PageLayout sidebar padding --- .../PageLayout.sidebar-padding.test.tsx | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 packages/react/src/PageLayout/PageLayout.sidebar-padding.test.tsx diff --git a/packages/react/src/PageLayout/PageLayout.sidebar-padding.test.tsx b/packages/react/src/PageLayout/PageLayout.sidebar-padding.test.tsx new file mode 100644 index 00000000000..09082ce4f0d --- /dev/null +++ b/packages/react/src/PageLayout/PageLayout.sidebar-padding.test.tsx @@ -0,0 +1,18 @@ +import {describe, it, expect} from 'vitest' +import {render} from '@testing-library/react' +import {PageLayout} from './PageLayout' + +describe('PageLayout.Sidebar padding', () => { + it('applies sidebar padding when the root has no padding', () => { + const {container} = render( + + Content + Sidebar + , + ) + + const sidebar = container.querySelector('[data-component="PageLayout.Sidebar"]') + expect(sidebar).not.toBeNull() + expect(getComputedStyle(sidebar!).paddingTop).toBe('16px') + }) +}) From 2df60db1c98dbbcbef11bfee953909b6217b7fa6 Mon Sep 17 00:00:00 2001 From: Naveed Sajjad <88137903+naveedsajjdawan@users.noreply.github.com> Date: Wed, 14 Oct 2026 14:21:12 +0500 Subject: [PATCH 3/3] docs: add changeset for sidebar padding fix --- .changeset/quiet-sidebar-padding.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/quiet-sidebar-padding.md diff --git a/.changeset/quiet-sidebar-padding.md b/.changeset/quiet-sidebar-padding.md new file mode 100644 index 00000000000..f7d0deb0b3e --- /dev/null +++ b/.changeset/quiet-sidebar-padding.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Fix `PageLayout.Sidebar` so its `padding` prop applies independently of the root layout padding.