some fixes to 6517B and LCR

Author: prathameshnium

Keithley_6517B/Pyroelectricity/Backends/Current_K6517B_Simple_Backend_v10.py

@@ -3,7 +3,7 @@
 # Purpose:     Current Measurement Backend
 # Author:      Prathamesh K Deshmukh
 # Created:     03-03-2024
-# Updates:     V1.3 (Fixed DataFrame saving bug)
+# Updates:     V1.4 (Fixed DataFrame saving bug)
 #-------------------------------------------------------------------------------
 
 import time
@@ -42,15 +42,21 @@
     # Graceful Exit on Ctrl+C
     print("\nMeasurement stopped by User.")
 
-    # --- FIX IS HERE: Define data_df before using it ---
-    data_df = pd.DataFrame({"Timestamp": t, "Current (A)": I})
-    data_df.to_csv("demo_data.dat", index=False)
-    print(f"Data saved to file: demo_data.dat")
+    # --- FIX: Create the DataFrame before saving ---
+    if t and I:
+        data_df = pd.DataFrame({"Timestamp": t, "Current (A)": I})
+        data_df.to_csv("demo_data.dat", index=False)
+        print(f"Data saved to file: demo_data.dat")
+    else:
+        print("No data collected to save.")
 
     # Shutdown Sequence
-    time.sleep(0.5)
-    keithley.shutdown()  # Ramps current to 0 and disables output
-    print("Keithley closed.")
+    try:
+        time.sleep(0.5)
+        keithley.shutdown()  # Ramps current to 0 and disables output
+        print("Keithley closed.")
+    except Exception as e:
+        print(f"Error closing instrument: {e}")
 
 except Exception as e:
-    print(f"Error with Keithley: {e}")
+    print(f"Error with Keithley: {e}")

LCR_Keysight_E4980A/Backends/CV_KE4980A_Simple_Backend_v10.py

@@ -20,16 +20,13 @@
 
 filename = "E:/Prathamesh/Python Stuff/CV/CV_Measurements/" + str(name) + "_freq_" + str(freq) + "_volt_" + str(V) + "_V_step_" + str(V_step) + "_Loops" + str(loop) + ".txt"
 
-#---------------------------------------------------------------
-
 loop_ind_new = 0
 protocol_list = []
 V_list = []
 C_list = []
 loop_list = []
 
 #---------------------------------
-# Initialize Instrument
 try:
     rm = pyvisa.ResourceManager()
     my_instrument = rm.open_resource("GPIB::17")
@@ -42,21 +39,16 @@
     my_instrument.write('*RST; *CLS')
     my_instrument.write(':DISP:ENAB')
     time.sleep(2)
-
     my_instrument.write(':INIT:CONT')
     my_instrument.write(':TRIG:SOUR EXT')
     time.sleep(2)
-
     my_instrument.write(':APER MED')
     my_instrument.write(':FUNC:IMP:RANGE:AUTO ON')
     time.sleep(2)
-
     my_instrument.write(':MMEM EXT')
     time.sleep(2)
-
     my_instrument.write(':MEM:DIM DBUF, ' + str(100))
     time.sleep(1)
-
     my_instrument.write(':MEM:FILL DBUF')
     time.sleep(2)
     my_instrument.write(':MEM:CLE DBUF')
@@ -65,76 +57,66 @@
     time.sleep(2)
     my_instrument.write(':VOLT:LEVEL ' + str(V_ac))
     time.sleep(2)
-
 except Exception as e:
-    print(f"Instrument initialization failed: {e}")
-    # In a real scenario, you might want to exit here
-    pass
+    print(f"Initialization error: {e}")
+    # Continue for simulation purposes, or exit in real usage
 
 #---------------------------------
 
 # LCR_fcn for the actual measurements
 def LCR_fcn(volt_ind):
-    # Removed unused globals that caused linting errors
+    # --- FIX: Removed unused globals ---
     global v1
     global output1
 
     my_instrument.write(':BIAS:VOLTage:LEVel ' + str(volt_ind))
-
     time.sleep(5)
     my_instrument.write(':INITiate[:IMMediate]')
-
     time.sleep(2)
 
     output1 = LCR.values(":FETCh:IMPedance:FORMatted?")
     time.sleep(2)
 
-    C_list.append(output1[0])
+    if output1:
+        C_list.append(output1[0])
+    
     v1 = my_instrument.query(':BIAS:VOLTage:LEVel?')
     V_list.append(v1)
     time.sleep(4)
 
-    print("Output: " + str(output1) + "    |  Volt : " + str(v1) + "   |  Cp : " + str(output1[0]) + " | Loop: " + str(loop_ind_new) + "  |  ")
-
+    print("Output: " + str(output1) + "    |  Volt : " + str(v1) + "   |  Loop: " + str(loop_ind_new))
 
 # Proto_fcn for the measurements protocol
 def Proto_fcn():
     global loop_ind_new
-    # Removed unused global protocol_list
-    
     loop_ind_new += 1
 
-    # First protocol 0 to V {A}
+    # Protocol Steps
     for v_ind in np.arange(0, V + V_step, V_step):
         LCR_fcn(v_ind)
         loop_list.append(loop_ind_new)
         protocol_list.append("A")
 
-    # Second protocol V to 0 {B}
     for v_ind in np.arange(V, 0 - V_step, -V_step):
         LCR_fcn(v_ind)
         loop_list.append(loop_ind_new)
         protocol_list.append("B")
 
-    # Third protocol 0 to -V {C}
     for v_ind in np.arange(0, -V - V_step, -V_step):
         LCR_fcn(v_ind)
         loop_list.append(loop_ind_new)
         protocol_list.append("C")
 
-    # Second protocol -V to 0 {D}
     for v_ind in np.arange(-V, 0 + V_step, V_step):
         LCR_fcn(v_ind)
         loop_list.append(loop_ind_new)
         protocol_list.append("D")
 
-
 # Loop_fcn for the looping number of times
 def Loop_fcn(loop):
     for loop_ind in range(loop):
         Proto_fcn()
 
-
 if __name__ == "__main__":
     try:
         Loop_fcn(loop)
@@ -144,25 +126,20 @@ def Loop_fcn(loop):
         time.sleep(1)
         LCR.shutdown()
 
-        # Save Data
         data_dict = {'Volt': V_list, 'Cp': C_list, 'Loop': loop_list, 'Protocol': protocol_list}
         df = pd.DataFrame(data_dict)
 
         try:
             df.to_csv(filename, sep=',', index=False, encoding='utf-8')
             print(f"Data saved to {filename}")
         except Exception:
-            fallback_name = "LCR_Data_Backup.csv"
-            df.to_csv(fallback_name, sep=',', index=False)
-            print(f"Could not save to specified path. Saved to {fallback_name} instead.")
+            df.to_csv("LCR_Backup.csv", index=False)
+            print("Saved to LCR_Backup.csv")
 
-        # Plotting
         if V_list and C_list:
             plt.scatter(V_list, C_list)
-            plt.title("Cp vs V , Loops:" + str(loop) + "   V_max:" + str(V) + "   step size : " + str(V_step))
-            plt.xlabel("V")
-            plt.ylabel("Cp")
+            plt.title("Cp vs V")
             plt.show()
 
     except Exception as e:
-        print(f"An error occurred: {e}")
+        print(f"Error: {e}")