diff --git a/api/core/v1beta1/connect_types.go b/api/core/v1beta1/connect_types.go index 9388f1d..1e4b4c7 100644 --- a/api/core/v1beta1/connect_types.go +++ b/api/core/v1beta1/connect_types.go @@ -928,8 +928,9 @@ func (c *Connect) CreateSessionVolumeFactory(ctx context.Context) *product.Multi }, InitContainerDefs: map[string]*product.ContainerDef{ "init-runtime": { - Image: img, - ImagePullPolicy: corev1.PullAlways, + Image: img, + // PullIfNotPresent: tag is pinned to Connect version, so a cached copy is always correct. + ImagePullPolicy: corev1.PullIfNotPresent, Mounts: map[string]*product.VolumeMountDef{ "init-volume": { MountPath: "/mnt/rstudio-connect-runtime", diff --git a/api/core/v1beta1/connect_types_test.go b/api/core/v1beta1/connect_types_test.go index 74f0170..50bb3bc 100644 --- a/api/core/v1beta1/connect_types_test.go +++ b/api/core/v1beta1/connect_types_test.go @@ -435,6 +435,12 @@ func TestConnect_CreateSessionVolumeFactory(t *testing.T) { env := v.EnvVars() assert.Len(t, env, 0) + // the init-runtime container should not force a registry pull on every start + initContainers := v.InitContainers() + assert.Len(t, initContainers, 1) + assert.Equal(t, "init-runtime", initContainers[0].Name) + assert.Equal(t, corev1.PullIfNotPresent, initContainers[0].ImagePullPolicy) + // and if you don't have a special secret env var con.Spec.SessionConfig = &product.SessionConfig{ Pod: &product.PodConfig{