fixed

Author: AJIXuMuK

src/common/utilities/SPHelper.ts

@@ -372,6 +372,14 @@ export class SPHelper {
             });
     }
 
+    public static isTextFieldType(fieldType?: string): boolean {
+      if (!fieldType) {
+        return true;
+      }
+      const lowercasedFieldType = fieldType.toLowerCase();
+      return lowercasedFieldType === 'text' || lowercasedFieldType === 'note';
+    }
+
 
     private static _updateFieldInSessionStorage(field: ISPField, context: IContext): void {
         let loadedViewFields: { [viewId: string]: IFields } = SPHelper._getLoadedViewFieldsFromStorage();

src/controls/listItemPicker/ListItemPicker.tsx

@@ -8,6 +8,7 @@ import { IListItemPickerProps, IListItemPickerState } from ".";
 import * as telemetry from '../../common/telemetry';
 import isEqual from 'lodash/isEqual';
 import { ITag } from 'office-ui-fabric-react/lib/components/pickers/TagPicker/TagPicker.types';
+import { SPHelper } from '../../common/utilities/SPHelper';
 
 
 export class ListItemPicker extends React.Component<IListItemPickerProps, IListItemPickerState> {
@@ -168,7 +169,7 @@ export class ListItemPicker extends React.Component<IListItemPickerProps, IListI
       // Check if the list had items
       if (listItems.length > 0) {
         for (const item of listItems) {
-          arrayItems.push({ key: item[keyColumn], name: item[columnInternalName] });
+          arrayItems.push({ key: item[keyColumn], name: SPHelper.isTextFieldType(field.TypeAsString === 'Calculated' ? field.ResultType : field.TypeAsString) ? item[columnInternalName] : item.FieldValuesAsText[columnInternalName] });
         }
       }
       return arrayItems;

src/services/SPService.ts

@@ -2,7 +2,7 @@ import { ISPService, ILibsOptions, LibsOrderBy, IFieldsOptions, FieldsOrderBy }
 import { ISPField, ISPList, ISPLists, IUploadImageResult } from "../common/SPEntities";
 import { BaseComponentContext } from '@microsoft/sp-component-base';
 import { SPHttpClient, ISPHttpClientOptions } from "@microsoft/sp-http";
-import { urlCombine } from "../common/utilities";
+import { SPHelper, urlCombine } from "../common/utilities";
 import filter from 'lodash/filter';
 import find from 'lodash/find';
 
@@ -170,7 +170,7 @@ export default class SPService implements ISPService {
     let isPost = false;
     let processItems: ((items: any[]) => any[]) | undefined;
 
-    if (field && field.TypeAsString === 'Calculated' && this._isTextFieldType(field.ResultType)) { // for calculated fields we need to use CAML query
+    if (field && field.TypeAsString === 'Calculated' && SPHelper.isTextFieldType(field.ResultType)) { // for calculated fields we need to use CAML query
       let orderByStr = '';
 
       if (orderBy) {
@@ -187,7 +187,7 @@ export default class SPService implements ISPService {
       apiUrl = `${webAbsoluteUrl}/_api/web/lists('${listId}')/GetItems(query=@v1)?$select=${keyInternalColumnName || 'Id'},${internalColumnName}&@v1=${JSON.stringify({ ViewXml: camlQuery })}`;
       isPost = true;
     }
-    else if (this._isTextFieldType(field.TypeAsString)) {
+    else if (SPHelper.isTextFieldType(field.TypeAsString)) {
       const filterStr = substringSearch ? // JJ - 20200613 - find by substring as an option
         `${filterText ? `substringof('${encodeURIComponent(filterText.replace("'", "''"))}',${internalColumnName})` : ''}${filterString ? (filterText ? ' and ' : '') + filterString : ''}`
         : `${filterText ? `startswith(${internalColumnName},'${encodeURIComponent(filterText.replace("'", "''"))}')` : ''}${filterString ? (filterText ? ' and ' : '') + filterString : ''}`; //string = filterList  ? `and ${filterList}` : '';
@@ -201,8 +201,8 @@ export default class SPService implements ISPService {
         return this._filterListItemsFieldValuesAsText(cachedItems.items, internalColumnName, filterText, substringSearch);
       }
 
-      apiUrl = `${webAbsoluteUrl}/_api/web/lists('${listId}')/GetItems?$select=${keyInternalColumnName || 'Id'},FieldValuesAsText/${internalColumnName}&$expand=FieldValuesAsText&$orderby=${orderBy}${filterString ? '&$filter=' + filterString : ''}`;
-      isPost = true;
+      apiUrl = `${webAbsoluteUrl}/_api/web/lists('${listId}')/items?$select=${keyInternalColumnName || 'Id'},${internalColumnName},FieldValuesAsText/${internalColumnName}&$expand=FieldValuesAsText&$orderby=${orderBy}${filterString ? '&$filter=' + filterString : ''}`;
+      isPost = false;
 
       processItems = (items: any[]) => {
 
@@ -638,14 +638,6 @@ export default class SPService implements ISPService {
     return result;
   }
 
-  private _isTextFieldType(fieldType?: string): boolean {
-    if (!fieldType) {
-      return true;
-    }
-    const lowercasedFieldType = fieldType.toLowerCase();
-    return lowercasedFieldType === 'text' || lowercasedFieldType === 'note';
-  }
-
   private _filterListItemsFieldValuesAsText(items: any[], internalColumnName: string, filterText: string | undefined, substringSearch: boolean): any[] {
     const lowercasedFilterText = filterText.toLowerCase();
 

src/webparts/controlsTest/ControlsTestWebPart.ts

@@ -15,7 +15,7 @@ import {
 } from "@microsoft/sp-property-pane";
 import { BaseClientSideWebPart } from "@microsoft/sp-webpart-base";
 
-import ControlsTest from "./components/ControlsTest_SingleComponent";
+import ControlsTest from "./components/ControlsTest";
 import { IControlsTestProps } from "./components/IControlsTestProps";
 import { IControlsTestWebPartProps } from "./IControlsTestWebPartProps";
 

src/webparts/controlsTest/components/ControlsTest.tsx

@@ -1466,10 +1466,10 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
 
               <div className="ms-font-m">List Item picker list data tester:
 
-                <ListItemPicker listId={'76a8231b-35b6-4703-b1f4-5d03d3dfb1ca'}
-                  columnInternalName="Title"
+                <ListItemPicker listId={'b1416fca-dc77-4198-a082-62a7657dcfa9'}
+                  columnInternalName="DateAndTime"
                   keyColumnInternalName="Id"
-                  filter={"Title eq 'SPFx'"}
+                  // filter={"Title eq 'SPFx'"}
                   orderBy={'Title desc'}
                   itemLimit={5}
                   context={this.props.context}