fix: Code scanning alerts (#228)

* fix: Code scanning alerts

Author: pm7y

src/AzureEventGridSimulator.Tests/IntegrationTests/BasicTests.cs

@@ -42,7 +42,7 @@ public async Task GivenAValidEvent_WhenPublished_ThenItShouldBeAccepted()
         );
 
         // Act
-        var jsonContent = new StringContent(json, Encoding.UTF8, "application/json");
+        using var jsonContent = new StringContent(json, Encoding.UTF8, "application/json");
         var response = await client.PostAsync("/api/events", jsonContent);
 
         // Assert

src/AzureEventGridSimulator.Tests/UnitTests/Retry/HttpEventDeliveryServiceTests.cs

@@ -13,9 +13,10 @@
 namespace AzureEventGridSimulator.Tests.UnitTests.Retry;
 
 [Trait("Category", "unit")]
-public class HttpEventDeliveryServiceTests
+public class HttpEventDeliveryServiceTests : IDisposable
 {
     private readonly EventSchemaFormatterFactory _formatterFactory;
+    private readonly List<HttpClient> _httpClients = [];
     private readonly ILogger<HttpEventDeliveryService> _logger;
 
     public HttpEventDeliveryServiceTests()
@@ -27,6 +28,16 @@ public HttpEventDeliveryServiceTests()
         );
     }
 
+    public void Dispose()
+    {
+        foreach (var client in _httpClients)
+        {
+            client.Dispose();
+        }
+
+        _httpClients.Clear();
+    }
+
     [Theory]
     [InlineData(HttpStatusCode.OK)]
     [InlineData(HttpStatusCode.Created)]
@@ -194,7 +205,7 @@ public async Task GivenDnsError_WhenDelivering_ThenReturnsNetworkError()
         result.ErrorMessage.ShouldContain("No such host");
     }
 
-    private static IHttpClientFactory CreateMockHttpClientFactory(
+    private IHttpClientFactory CreateMockHttpClientFactory(
         HttpStatusCode statusCode = HttpStatusCode.OK,
         Exception throwException = null,
         Action responseAction = null,
@@ -208,6 +219,7 @@ private static IHttpClientFactory CreateMockHttpClientFactory(
             captureHeaders
         );
         var httpClient = new HttpClient(handler);
+        _httpClients.Add(httpClient);
 
         var factory = Substitute.For<IHttpClientFactory>();
         factory.CreateClient(Arg.Any<string>()).Returns(httpClient);
@@ -264,6 +276,7 @@ private class MockHttpMessageHandler : HttpMessageHandler
         private readonly Action<HttpRequestHeaders> _captureHeaders;
         private readonly Exception _exception;
         private readonly Action _responseAction;
+        private readonly List<HttpResponseMessage> _responses = [];
         private readonly HttpStatusCode _statusCode;
 
         public MockHttpMessageHandler(
@@ -292,13 +305,29 @@ CancellationToken cancellationToken
                 throw _exception;
             }
 
-            return Task.FromResult(
-                new HttpResponseMessage(_statusCode)
+            var response = new HttpResponseMessage(_statusCode)
+            {
+                Content = new StringContent(""),
+                ReasonPhrase = _statusCode.ToString(),
+            };
+            _responses.Add(response);
+
+            return Task.FromResult(response);
+        }
+
+        protected override void Dispose(bool disposing)
+        {
+            if (disposing)
+            {
+                foreach (var response in _responses)
                 {
-                    Content = new StringContent(""),
-                    ReasonPhrase = _statusCode.ToString(),
+                    response.Dispose();
                 }
-            );
+
+                _responses.Clear();
+            }
+
+            base.Dispose(disposing);
         }
     }
 }

src/AzureEventGridSimulator/Infrastructure/Extensions/KestrelServerOptionsExtensions.cs

@@ -30,7 +30,7 @@ this KestrelServerOptions options
             certificate = new X509Certificate2(certificateFile, certificatePassword);
 #endif
         }
-        else if (certificateFileSpecified && !certificatePasswordSpecified)
+        else if (certificateFileSpecified)
         {
             // The certificate file was specified but the password wasn't.
             throw new InvalidOperationException("A certificate with a password is required.");