Address PR feedback

Author: camdecoster

.agents/architecture.md

@@ -6,7 +6,7 @@ Trace modules, the schema, and where a change lands. [CONTRIBUTING.md](../CONTRI
 
 A trace module is a plain object with functions attached, exported from `src/traces/<name>/index.js` and registered through the registry. The figure-wide subroutines call the methods in a loop, so the subroutines work with whatever set of trace modules a bundle registers.
 
-The methods you touch most:
+The methods/properties you touch most:
 
 - `attributes` - the JSON-serializable attribute declarations that feed the schema
 - `supplyDefaults` - input settings to `gd._fullData`. Cheap. No data loops.
@@ -18,7 +18,7 @@ Read the "Trace module design" section of [CONTRIBUTING.md](../CONTRIBUTING.md)
 
 ## The schema
 
-`test/plot-schema.json` is generated output that records the proposed API. Any change to an attribute or an attribute description changes this file.
+`test/plot-schema.json` is generated output that captures the full plotly.js API. Any change to an attribute or an attribute description changes this file.
 
 ```bash
 npm run schema

.agents/code-style.md

@@ -4,7 +4,7 @@
 
 ## Formatting
 
-Biome owns formatting. The JavaScript rules live in `biome.json`: single quotes, a four-space indent, no trailing commas, and a 120 column line width.
+Biome owns formatting. The JavaScript rules live in `biome.json`.
 
 Run the formatter on every file you add:
 
@@ -14,7 +14,7 @@ npx @biomejs/biome format --write <path>
 
 Format only files you created. Never pass a directory, and never format a file that already existed. The CLI formats a whole file at a time, and this repository is not formatted from end to end, so either one rewrites lines your change never touched and buries the real diff.
 
-In an existing file, write the lines you add by hand, to the settings above. That means single quotes, a four-space indent, no trailing comma, and no line past 120 columns. The settings are the house style, so follow them even when the lines around yours predate them. If you formatted such a file by accident, undo your changes and redo the edit.
+In an existing file, write the lines you add by hand, to follow the rules outlined in `biome.json`. The settings are the house style, so follow them even when the lines around yours predate them. If you formatted such a file by accident, undo your changes and redo the edit.
 
 `npm run lint-fix` also writes. It formats `test/image/mocks` and applies the safe lint fixes across every included path, so run it only when you want both.
 

.agents/pr-checklist.md

@@ -8,7 +8,7 @@ Walk this list before you hand the work back. Answer each item with evidence, no
 - [ ] A human asked for the pull request. If nobody asked, you open the issue and stop.
 - [ ] A human reviewed the code
 - [ ] You saw the rendered plot, for any change that moves pixels
-- [ ] You read the last few merged pull requests and matched their shape
+- [ ] You read the last few merged pull requests by library maintainers and matched their shape
 
 ## The change
 
@@ -26,7 +26,7 @@ Walk this list before you hand the work back. Answer each item with evidence, no
 ## Generated output
 
 - [ ] `npm run schema` ran after any attribute or description edit
-- [ ] `test/plot-schema.json` and `src/types/generated/schema.d.ts` are staged
+- [ ] `test/plot-schema.json` and `src/types/generated/schema.d.ts` are committed if they changed
 - [ ] `npm run schema-typegen-diff-check` reports no drift
 - [ ] The hand-written declarations under `src/types/core/` and `src/types/lib/` match the new API surface
 - [ ] Regl shaders regenerated, if the diff touches a regl path

.agents/testing.md

@@ -50,13 +50,13 @@ npm run test-jasmine -- axes --nowatch
 
 `--nowatch` turns off the watch mode, so the run exits after one pass instead of waiting for the next file change. Pass the exact file basename without the `_test.js` suffix, which the karma config appends for you. The name is not a substring: `-- bar` runs `bar_test.js` alone, and a partial name such as `hover_lab` matches no file, so the run finds nothing to do. Several names in one command run several suites.
 
-Write a test for every behavior change. A bug fix needs a test that fails before the fix.
+Write or modify a test for every behavior change. A bug fix needs a test that fails before the fix.
 
 For an interaction test, fix the width, height, margins, and both axis ranges. Interaction coordinates count from the top-left corner of the plot, including the margin. A test without fixed geometry turns flaky.
 
 ## Image tests
 
-An image test is a mock plus a baseline PNG.
+An image test is a JSON mock file plus a baseline PNG image.
 
 - The mock is figure JSON at `test/image/mocks/<name>.json`
 - The baseline is `test/image/baselines/<name>.png`