From eee28bae152b693bfdf9d3eebf444d974a683ce3 Mon Sep 17 00:00:00 2001 From: "Nick T." <73005126+tiliakoos@users.noreply.github.com> Date: Fri, 20 Nov 2026 00:18:12 -0500 Subject: [PATCH] fix(server): imported thread titles no longer end in a broken emoji The 100-unit title cut could land inside a surrogate pair, leaving a lone half that persists as U+FFFD. Re-lands #30970. Co-authored-by: MarcoDotIO <20867620+MarcoDotIO@users.noreply.github.com> --- .../src/project/AgentSessionScanner.test.ts | 19 +++++++++++++++++++ .../server/src/project/AgentSessionScanner.ts | 4 +++- 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/apps/server/src/project/AgentSessionScanner.test.ts b/apps/server/src/project/AgentSessionScanner.test.ts index 9f71bd9251ca6..fc76fc150a1d2 100644 --- a/apps/server/src/project/AgentSessionScanner.test.ts +++ b/apps/server/src/project/AgentSessionScanner.test.ts @@ -3831,6 +3831,25 @@ describe("parseAgentSessionTranscript", () => { expect(thread?.title).toBe("Fix the flaky login test"); }); + it("does not split an emoji when shortening a long first message into a title", () => { + const prompt = `${"a".repeat(99)}🚀 then deploy`; + const thread = AgentSessionScanner.parseAgentSessionTranscript({ + contents: [ + encodeTranscriptRecord({ type: "session_meta", payload: { id: "codex-session" } }), + encodeTranscriptRecord({ + type: "event_msg", + payload: { type: "user_message", message: prompt }, + }), + ].join("\n"), + source: "codex", + providerInstanceId: ProviderInstanceId.make("codex"), + fallbackSessionId: "fallback", + lastActiveAtMs: Date.parse("2026-08-25T08:00:00.000Z"), + }); + + expect(thread?.title).toBe("a".repeat(99)); + }); + it.each([ "Explain in this transcript", "Keep this incomplete example", diff --git a/apps/server/src/project/AgentSessionScanner.ts b/apps/server/src/project/AgentSessionScanner.ts index 0169535657caa..9bd4b5cebd276 100644 --- a/apps/server/src/project/AgentSessionScanner.ts +++ b/apps/server/src/project/AgentSessionScanner.ts @@ -29,6 +29,7 @@ import * as Schema from "effect/Schema"; import * as Semaphore from "effect/Semaphore"; import * as Stream from "effect/Stream"; +import { splitsSurrogatePair } from "@t3tools/shared/assistantCitations"; import { isBareGitConfig, parseOriginUrlFromGitConfig } from "@t3tools/shared/git"; import * as HostProcess from "@t3tools/shared/HostProcess"; import { normalizeProjectPathForComparison } from "@t3tools/shared/path"; @@ -455,7 +456,8 @@ function deriveTitle(source: AgentSessionSource, text: string): string | undefin WAKE_ENVELOPE, "$1", ); - return request.trim().split("\n")[0]?.slice(0, 100).trim() || undefined; + const line = request.trim().split("\n")[0] ?? ""; + return line.slice(0, splitsSurrogatePair(line, 100) ? 99 : 100).trim() || undefined; } // Pi keeps abandoned branches in the file; its active branch runs from the last entry to the root.