Improve variable names

Author: casperbakker

src/Types/TypeCode11.php

@@ -60,27 +60,27 @@ public function getBarcode(string $code): Barcode
 
     private function getCheckDigitC(string $code): string
     {
-        $p = 1;
-        $check = 0;
+        $weight = 1;
+        $checksum = 0;
         for ($i = (strlen($code) - 1); $i >= 0; --$i) {
             $digit = $code[$i];
             if ($digit == '-') {
-                $dval = 10;
+                $digitValue = 10;
             } else {
-                $dval = intval($digit);
+                $digitValue = intval($digit);
             }
-            $check += ($dval * $p);
-            ++$p;
-            if ($p > 10) {
-                $p = 1;
+            $checksum += ($digitValue * $weight);
+            ++$weight;
+            if ($weight > 10) {
+                $weight = 1;
             }
         }
-        $check %= 11;
-        if ($check == 10) {
-            $check = '-';
+        $checksum %= 11;
+        if ($checksum == 10) {
+            $checksum = '-';
         }
 
-        return $check;
+        return $checksum;
     }
 
     private function getCheckDigitK(string $code): string
@@ -89,23 +89,23 @@ private function getCheckDigitK(string $code): string
             return '';
         }
 
-        $p = 1;
-        $check = 0;
+        $weight = 1;
+        $checksum = 0;
         for ($i = (strlen($code) - 1); $i >= 0; --$i) {
             $digit = $code[$i];
             if ($digit == '-') {
-                $dval = 10;
+                $digitValue = 10;
             } else {
-                $dval = intval($digit);
+                $digitValue = intval($digit);
             }
-            $check += ($dval * $p);
-            ++$p;
-            if ($p > 9) {
-                $p = 1;
+            $checksum += ($digitValue * $weight);
+            ++$weight;
+            if ($weight > 9) {
+                $weight = 1;
             }
         }
-        $check %= 11;
+        $checksum %= 11;
 
-        return (string)$check;
+        return (string)$checksum;
     }
 }

src/Types/TypeCode32.php

@@ -98,17 +98,17 @@ public function getBarcode(string $code): Barcode
      */
     protected function checksum_code32(string $code): string
     {
-        $s = 0;
+        $checksum = 0;
 
         foreach (str_split($code) as $i => $c) {
             if (0 === $i % 2) {
-                $s += (int)$c;
+                $checksum += (int)$c;
             } else {
                 $c  = 2 * (int)$c;
-                $s += (int)floor($c / 10) + ($c % 10);
+                $checksum += (int)floor($c / 10) + ($c % 10);
             }
         }
 
-        return (string)($s % 10);
+        return (string)($checksum % 10);
     }
 }

src/Types/TypeCode39.php

@@ -318,13 +318,13 @@ protected function checksum_code39($code)
             '%'
         ];
 
-        $sum = 0;
-        for ($i = 0; $i < strlen($code); ++$i) {
-            $k = array_keys($chars, $code[$i]);
-            $sum += $k[0];
+        $checksum = 0;
+        for ($index = 0; $index < strlen($code); ++$index) {
+            $charPosition = array_keys($chars, $code[$index]);
+            $checksum += $charPosition[0];
         }
-        $j = ($sum % 43);
+        $checksumIndex = ($checksum % 43);
 
-        return $chars[$j];
+        return $chars[$checksumIndex];
     }
 }

src/Types/TypeCode93.php

@@ -251,35 +251,35 @@ protected function checksum_code93(string $code): string
         $chars = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', '-', '.', ' ', '$', '/', '+', '%', 'a', 'b', 'c', 'd'];
 
         // calculate check digit C
-        $len = strlen($code);
-        $p = 1;
-        $check = 0;
-        for ($i = ($len - 1); $i >= 0; --$i) {
-            $k = array_keys($chars, $code[$i]);
-            $check += ($k[0] * $p);
-            ++$p;
-            if ($p > 20) {
-                $p = 1;
+        $codeLength = strlen($code);
+        $weight = 1;
+        $checksum = 0;
+        for ($i = ($codeLength - 1); $i >= 0; --$i) {
+            $charIndex = array_keys($chars, $code[$i]);
+            $checksum += ($charIndex[0] * $weight);
+            ++$weight;
+            if ($weight > 20) {
+                $weight = 1;
             }
         }
-        $check %= 47;
-        $c = $chars[$check];
-        $code .= $c;
+        $checksumC = $checksum % 47;
+        $checkDigitC = $chars[$checksumC];
+        $codeWithC = $code . $checkDigitC;
 
         // calculate check digit K
-        $p = 1;
-        $check = 0;
-        for ($i = $len; $i >= 0; --$i) {
-            $k = array_keys($chars, $code[$i]);
-            $check += ($k[0] * $p);
-            ++$p;
-            if ($p > 15) {
-                $p = 1;
+        $weight = 1;
+        $checksum = 0;
+        for ($i = $codeLength; $i >= 0; --$i) {
+            $charIndex = array_keys($chars, $codeWithC[$i]);
+            $checksum += ($charIndex[0] * $weight);
+            ++$weight;
+            if ($weight > 15) {
+                $weight = 1;
             }
         }
-        $check %= 47;
-        $k = $chars[$check];
+        $checksumK = $checksum % 47;
+        $checkDigitK = $chars[$checksumK];
 
-        return $c . $k;
+        return $checkDigitC . $checkDigitK;
     }
 }