Phpstan fixed to level 2

Author: casperbakker

.github/workflows/phpstan.yml

@@ -22,4 +22,4 @@ jobs:
       run: composer install --prefer-dist --no-progress --no-interaction
 
     - name: Run analysis
-      run: vendor/bin/phpstan analyse src --level 1
+      run: vendor/bin/phpstan analyse src --level 2

src/Types/TypeIntelligentMailBarcode.php

@@ -378,11 +378,11 @@ public function getBarcodeData(string $code): Barcode
         // convert codewords to characters
         $characters = [];
         $bitmask = 512;
-        foreach ($codewords as $k => $val) {
+        foreach ($codewords as $val) {
             if ($val <= 1286) {
-                $chrcode = $table5of13[$val];
+                $chrcode = (int)$table5of13[$val];
             } else {
-                $chrcode = $table2of13[($val - 1287)];
+                $chrcode = (int)$table2of13[($val - 1287)];
             }
             if (($fcs & $bitmask) > 0) {
                 // bitwise invert
@@ -517,7 +517,7 @@ protected function hex_to_dec($hex)
      * @return array requested table
      * @protected
      */
-    protected function imb_tables($n, $size)
+    protected function imb_tables(int $n, int $size): array
     {
         $table = [];
         $lli = 0; // LUT lower index

src/Types/TypeUpcExtension2.php

@@ -20,20 +20,20 @@ public function getBarcodeData(string $code): Barcode
     {
         $len = $this->length;
 
-        //Padding
+        // Padding
         $code = str_pad($code, $len, '0', STR_PAD_LEFT);
 
-        // calculate check digit
+        // Calculate check digit
         if ($len == 2) {
             $r = $code % 4;
         } elseif ($len == 5) {
-            $r = (3 * ($code[0] + $code[2] + $code[4])) + (9 * ($code[1] + $code[3]));
+            $r = (3 * intval($code[0] . $code[2] . $code[4])) + (9 * intval($code[1] . $code[3]));
             $r %= 10;
         } else {
             throw new InvalidCheckDigitException();
         }
 
-        //Convert digits to bars
+        // Convert digits to bars
         $codes = [
             'A' => [ // left odd parity
                 '0' => '0001101',