ext/mysqli: Deprecate mysqli_stmt_init (#23209)

Author: kamil-tekiela

NEWS

@@ -95,7 +95,9 @@ PHP                                                                        NEWS
   . Passing objects to mb_convert_variables() is now deprecated. (Girgias)
 
 - MySQLi:
-  . The mysqli_get_charset() function is now deprecated. (Kamil Tekiela)
+  . The mysqli_get_charset() function and mysqli::get_charset() method are now deprecated. (Kamil Tekiela)
+  . The mysqli_stmt_init() function and mysqli::stmt_init() method are now deprecated. (Kamil Tekiela)
+  . Instantiation of mysqli_stmt without providing the $query parameter is now deprecated. (Kamil Tekiela)
 
 - PDO:
   . Fixed pdo_raise_impl_error() emitting a warning under ERRMODE_SILENT.

UPGRADING

@@ -476,8 +476,11 @@ PHP 8.6 UPGRADE NOTES
     RFC: https://wiki.php.net/rfc/deprecations_php_8_6#passing_objects_for_vars_parameter_of_mb_convert_variables
 
 - MySQLi:
-  . The mysqli_get_charset() function is now deprecated.
+  . The mysqli_get_charset() function and mysqli::get_charset() method are now deprecated.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_mysqli_get_charset
+  . The mysqli_stmt_init() function, mysqli::stmt_init() method, and calling mysqli_stmt constructor
+    without providing the $query parameter are now deprecated.
+    RFC: https://wiki.php.net/rfc/deprecations_php_8_6#deprecate_mysqlistmt_init
 
 - Reflection:
   . Calling ReflectionProperty::setValue() with an object that is not an

ext/mysqli/mysqli.c

@@ -674,6 +674,8 @@ PHP_METHOD(mysqli_stmt, __construct)
 			RETURN_FALSE;
 		}
 		mysqli_resource->status = MYSQLI_STATUS_VALID;
+	} else {
+		zend_error(E_DEPRECATED, "Instantiation of mysqli_stmt without providing the $query parameter is deprecated");
 	}
 }
 

ext/mysqli/mysqli.stub.php

@@ -996,6 +996,7 @@ public function stat(): string|false {}
      * @tentative-return-type
      * @alias mysqli_stmt_init
      */
+    #[\Deprecated(since: '8.6', message: 'use mysqli::prepare() instead')]
     public function stmt_init(): mysqli_stmt|false {}
 
     /**
@@ -1610,6 +1611,7 @@ function mysqli_stmt_get_result(mysqli_stmt $statement): mysqli_result|false {}
 function mysqli_stmt_get_warnings(mysqli_stmt $statement): mysqli_warning|false {}
 
 /** @refcount 1 */
+#[\Deprecated(since: '8.6', message: 'use mysqli_prepare() instead')]
 function mysqli_stmt_init(mysqli $mysql): mysqli_stmt|false {}
 
 /** @refcount 1 */

ext/mysqli/mysqli_arginfo.h

@@ -11,8 +11,7 @@ require_once 'skipifconnectfailure.inc';
 require_once 'connect.inc';
 
 $db = new my_mysqli($host, $user, $passwd, $db, $port, $socket);
-$qry=$db->stmt_init();
-$qry->prepare("SELECT REPEAT('a',100000)");
+$qry=$db->prepare("SELECT REPEAT('a',100000)");
 $qry->execute();
 $qry->bind_result($text);
 $qry->fetch();

ext/mysqli/tests/bug38710.phpt

@@ -50,23 +50,17 @@ memory_limit=83886080
 
     function test_format($link, $format, $from, $order_by, $expected, $offset) {
 
-        if (!$stmt = mysqli_stmt_init($link)) {
-            printf("[%03d] Cannot create PS, [%d] %s\n",
-                $offset,
-                mysqli_errno($link), mysqli_error($link));
-            return false;
-        }
         print "$format\n";
 
         if ($order_by)
             $sql = sprintf('SELECT %s AS _format FROM %s ORDER BY %s', $format, $from, $order_by);
         else
             $sql = sprintf('SELECT %s AS _format FROM %s', $format, $from);
 
-        if (!mysqli_stmt_prepare($stmt, $sql)) {
+        if (!$stmt = mysqli_prepare($link, $sql)) {
             printf("[%03d] Cannot prepare PS, [%d] %s\n",
                 $offset + 1,
-                mysqli_stmt_errno($stmt), mysqli_stmt_error($stmt));
+                mysqli_errno($link), mysqli_error($link));
             return false;
         }
 

ext/mysqli/tests/bug42378.phpt

@@ -16,11 +16,10 @@ require_once 'skipifconnectfailure.inc';
 
     $in_and_out = "a";
 
-    if (!($stmt = $link->stmt_init()))
+    if (!($stmt = $link->prepare("SELECT ?")))
         printf("[002] [%d] %s\n", $link->errno, $link->error);
 
-    if (!($stmt->prepare("SELECT ?")) ||
-        !($stmt->bind_param("s", $in_and_out)) ||
+    if (!($stmt->bind_param("s", $in_and_out)) ||
         !($stmt->execute()) ||
         !($stmt->bind_result($in_and_out)))
         printf("[003] [%d] %s\n", $stmt->errno, $stmt->error);

ext/mysqli/tests/bug55653.phpt

@@ -1,5 +1,5 @@
 --TEST--
-Bug #66043 (Segfault calling bind_param() on mysqli)
+Bug #66043 (Segfault calling bind_param() on mysqli) - Calling mysql_stmt::bind_result() without storing it's result value in a variable is causing a segfault.
 --EXTENSIONS--
 mysqli
 --SKIPIF--
@@ -9,38 +9,13 @@ require_once 'skipifconnectfailure.inc';
 --FILE--
 <?php
 require 'connect.inc';
-if (!$db = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket)) {
-    printf("[001] Connect failed, [%d] %s\n", mysqli_connect_errno(), mysqli_connect_error());
-}
-
-if (!$db->query("DROP TABLE IF EXISTS test")) {
-    printf("[002] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
-    die();
-}
-
-if (!$db->query("CREATE TABLE test(str TEXT)")) {
-    printf("[003] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
-    die();
-}
-
-if (!$db->query("INSERT INTO test(str) VALUES ('Test')")) {
-    printf("[004] [%d] %s\n", mysqli_errno($link), mysqli_error($link));
-    die();
-}
-
-$stmt = $db->stmt_init();
-if (!$stmt->prepare("SELECT str FROM test")) {
-    printf("[004] [%d] %s\n", mysqli_errno($db), mysqli_error($db));
-    die();
-}
+mysqli_report(MYSQLI_REPORT_ERROR | MYSQLI_REPORT_STRICT);
+$db = my_mysqli_connect($host, $user, $passwd, $db, $port, $socket);
 
+$stmt = $db->prepare("SELECT 'Test'");
 $stmt->execute();
 $stmt->bind_result($testArg);
 echo "Okey";
 ?>
---CLEAN--
-<?php
-require_once 'clean_table.inc';
-?>
 --EXPECT--
 Okey

ext/mysqli/tests/bug66043.phpt

@@ -132,6 +132,7 @@ printf("stmt->unknown = '%s'\n", @$stmt->unknown);
 print "done!";
 ?>
 --EXPECTF--
+Deprecated: Instantiation of mysqli_stmt without providing the $query parameter is deprecated in %s on line %d
 Parent class:
 bool(false)