Continued with revision for PR#87

Author: simon-mundy

composer.lock

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace PhpDb\Adapter\Driver\Pdo;
 
 use Closure;

src/Adapter/Driver/Pdo/Result.php

@@ -24,7 +24,7 @@ class Profiler implements ProfilerInterface
      * @throws InvalidArgumentException
      * @return $this Provides a fluent interface
      */
-    public function profilerStart(string|StatementContainerInterface $target): static
+    public function profilerStart(string|StatementContainerInterface $target): ProfilerInterface
     {
         $profileInformation = [
             'sql'        => '',
@@ -52,7 +52,7 @@ public function profilerStart(string|StatementContainerInterface $target): stati
     /**
      * @return $this Provides a fluent interface
      */
-    public function profilerFinish(): static
+    public function profilerFinish(): ProfilerInterface
     {
         if (! isset($this->profiles[$this->currentIndex])) {
             throw new Exception\RuntimeException(

src/Adapter/Profiler/Profiler.php

@@ -8,7 +8,7 @@
 
 interface ProfilerInterface
 {
-    public function profilerStart(string|StatementContainerInterface $target): mixed;
+    public function profilerStart(string|StatementContainerInterface $target): ProfilerInterface;
 
     /**
      * @return $this

src/Adapter/Profiler/ProfilerInterface.php

@@ -6,17 +6,15 @@
 
 class ConstraintKeyObject
 {
-    public const FK_CASCADE = 'CASCADE';
+    final public const FK_CASCADE = 'CASCADE';
 
-    public const FK_SET_NULL = 'SET NULL';
+    final public const FK_SET_NULL = 'SET NULL';
 
-    public const FK_NO_ACTION = 'NO ACTION';
+    final public const FK_NO_ACTION = 'NO ACTION';
 
-    public const FK_RESTRICT = 'RESTRICT';
+    final public const FK_RESTRICT = 'RESTRICT';
 
-    public const FK_SET_DEFAULT = 'SET DEFAULT';
-
-    protected string $columnName;
+    final public const FK_SET_DEFAULT = 'SET DEFAULT';
 
     protected ?int $ordinalPosition = null;
 
@@ -35,9 +33,8 @@ class ConstraintKeyObject
     /**
      * Constructor
      */
-    public function __construct(string $column)
+    public function __construct(protected string $columnName)
     {
-        $this->setColumnName($column);
     }
 
     /**

src/Metadata/Object/ConstraintKeyObject.php

@@ -119,9 +119,6 @@ public function getTables(?string $schema = null, bool $includeViews = false): a
         return $tables;
     }
 
-    /**
-     * {}
-     */
     #[Override]
     public function getTable(string $tableName, ?string $schema = null): TableObject|ViewObject
     {
@@ -197,9 +194,7 @@ public function getViews(?string $schema = null): array
         return $views;
     }
 
-    /**
-     * {}
-     */
+
     #[Override]
     public function getView(string $viewName, ?string $schema = null): ViewObject|TableObject
     {
@@ -217,9 +212,6 @@ public function getView(string $viewName, ?string $schema = null): ViewObject|Ta
         throw new Exception('View "' . $viewName . '" does not exist');
     }
 
-    /**
-     * {}
-     */
     #[Override]
     public function getColumnNames(string $table, ?string $schema = null): array
     {
@@ -256,9 +248,6 @@ public function getColumns(string $table, ?string $schema = null): array
         return $columns;
     }
 
-    /**
-     * {}
-     */
     #[Override]
     public function getColumn(string $columnName, string $table, ?string $schema = null): ColumnObject
     {
@@ -310,9 +299,6 @@ public function getConstraints(string $table, ?string $schema = null): array
         return $constraints;
     }
 
-    /**
-     * {}
-     */
     #[Override]
     public function getConstraint(
         string $constraintName,
@@ -427,9 +413,6 @@ public function getTriggers(?string $schema = null): array
         return $triggers;
     }
 
-    /**
-     * {}
-     */
     #[Override]
     public function getTrigger(string $triggerName, ?string $schema = null): TriggerObject
     {