Conversation
The horizontal-overflow clamp in show() wrote a viewport coordinate to menu.style.left, but .slash-menu is position:absolute inside a position:fixed anchor — left is anchor-relative, not viewport-relative. The menu jumped to viewport x ≈ (cursor.x + 895) and stayed there because show() never reset menu.style.left between opens, letting the stale value re-trigger the clamp on every subsequent /. - Reset menu.style.left at the start of show() - Convert the clamp from viewport coords to anchor-relative
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The horizontal-overflow clamp in show() wrote a viewport coordinate to menu.style.left, but .slash-menu is position:absolute inside a position:fixed anchor — left is anchor-relative, not viewport-relative. The menu jumped to viewport x ≈ (cursor.x + 895) and stayed there because show() never reset menu.style.left between opens, letting the stale value re-trigger the clamp on every subsequent /.