-
-
Notifications
You must be signed in to change notification settings - Fork 1
Normalize Assets Manager current-page exception IDs #96
Copy link
Copy link
Closed
Labels
area: assets-managerAsset Manager behavior, compatibility, UI, persistence, or per-page controls.Asset Manager behavior, compatibility, UI, persistence, or per-page controls.area: compatibilityWordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility.WordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility.bugConfirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling.Confirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling.priority: mediumUseful or user-impacting work that should be planned but is not blocking now.Useful or user-impacting work that should be planned but is not blocking now.risk: backward-compatibilityTouches public data, options, hooks, migrations, or established behavior.Touches public data, options, hooks, migrations, or established behavior.status: in-progressWork has a branch, PR, or active release branch implementation path.Work has a branch, PR, or active release branch implementation path.
Milestone
Metadata
Metadata
Assignees
Labels
area: assets-managerAsset Manager behavior, compatibility, UI, persistence, or per-page controls.Asset Manager behavior, compatibility, UI, persistence, or per-page controls.area: compatibilityWordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility.WordPress, PHP, multisite, WooCommerce, theme, or plugin compatibility.bugConfirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling.Confirmed or likely defect affecting runtime behavior, UX, compatibility, or data handling.priority: mediumUseful or user-impacting work that should be planned but is not blocking now.Useful or user-impacting work that should be planned but is not blocking now.risk: backward-compatibilityTouches public data, options, hooks, migrations, or established behavior.Touches public data, options, hooks, migrations, or established behavior.status: in-progressWork has a branch, PR, or active release branch implementation path.Work has a branch, PR, or active release branch implementation path.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Finding
Assets Manager current-page exceptions are saved from POST payload values, while runtime checks compare them against
get_queried_object_id()using strict comparison.Impact
A rule such as “disable everywhere, but enable on current URL” can fail when the saved current-page ID is stored as a string and the runtime current object ID is an integer. That makes per-page asset exceptions unreliable.
Suggested implementation
perform_assets_manager_options.currentarrays when reading or updating rules.Acceptance criteria