fix: isValidID validation (#15217)

## Scripts

### `script:setup-figma`

Sets up the local development environment for testing with content-api:

- Clones `enterprise-plugins` repo if not present (sibling directory)
- Runs `pnpm install` in enterprise-plugins
- Removes `@payloadcms/figma` from `test/package.json` to rely on vitest
alias instead

### `test:int:summary`

Shows less noisy output for integration tests - reports how many tests
failed without detailed error messages. The test suites to run can be
easily modified via a hardcoded array. This script is particularly
useful when many tests fail (e.g., when starting to develop a new
db-adapter). To run it for a specific adapter, prefix with
`PAYLOAD_DATABASE` env var. Can be removed once content-api is complete
if desired.

## Bug Fixes

### Fixed `isValidID` validation

- Now properly checks that value type matches the expected ID type
- Rejects numbers when `type === 'text'` (fixes content-api adapter
validation)
- Only accepts numbers when `type === 'number'`
- Added explicit `return false` for invalid cases

## Test Improvements

### Refactored "Schema generation" tests

Moved conditional logic inside `it()` blocks instead of wrapping them,
preventing "no tests found" errors with new db-adapters.

### Added type casting tests

Tests for automatic type coercion in database adapters:

- String-to-number conversion in `hasMany` number fields
- Date field storage and retrieval as ISO strings
- Unix timestamp to ISO string conversion

See rationale in the comments of [this
PR](payloadcms/enterprise-plugins#300).

### Configured Vitest to run tests from `src/` instead of `dist/`

This was very difficult with Jest and eliminates the need to build in
watch mode during development.

---

**Note:** Current setup is designed for local content-api and db-adapter
development. Small modifications will be made in the future to run these
tests in CI against a deployed staging content-api URL.

Author: GermanJablo

package.json

@@ -122,6 +122,7 @@
     "script:license-check": "pnpm --filter scripts license-check",
     "script:list-published": "pnpm --filter releaser list-published",
     "script:pack": "pnpm --filter scripts pack-all-to-dest",
+    "script:setup-figma": "./scripts/setup-figma-dev.sh",
     "pretest": "pnpm build",
     "test": "pnpm test:int && pnpm test:components && pnpm test:e2e",
     "test:e2e": "pnpm runts ./test/runE2E.ts",
@@ -135,6 +136,7 @@
     "test:int:firestore": "cross-env NODE_OPTIONS=\"--no-deprecation --no-experimental-strip-types\" NODE_NO_WARNINGS=1 PAYLOAD_DATABASE=firestore DISABLE_LOGGING=true vitest --project int",
     "test:int:postgres": "cross-env NODE_OPTIONS=\"--no-deprecation --no-experimental-strip-types\" NODE_NO_WARNINGS=1 PAYLOAD_DATABASE=postgres DISABLE_LOGGING=true vitest --project int",
     "test:int:sqlite": "cross-env NODE_OPTIONS=\"--no-deprecation --no-experimental-strip-types\" NODE_NO_WARNINGS=1 PAYLOAD_DATABASE=sqlite DISABLE_LOGGING=true vitest --project int",
+    "test:int:summary": "pnpm runts ./test/runTestsWithSummary.ts",
     "test:types": "tstyche",
     "test:unit": "vitest run --project unit",
     "translateNewKeys": "pnpm --filter @tools/scripts run generateTranslations:core"

packages/payload/src/utilities/isValidID.ts

@@ -5,7 +5,6 @@ const ObjectId = 'default' in ObjectIdImport ? ObjectIdImport.default : ObjectId
 export const isValidID = (
   value: number | string,
   type: 'number' | 'ObjectID' | 'text',
-  // @ts-expect-error - vestiges of when tsconfig was not strict. Feel free to improve
 ): boolean => {
   if (type === 'text' && value) {
     if (['object', 'string'].includes(typeof value)) {
@@ -15,11 +14,13 @@ export const isValidID = (
     return false
   }
 
-  if (typeof value === 'number' && !Number.isNaN(value)) {
+  if (type === 'number' && typeof value === 'number' && !Number.isNaN(value)) {
     return true
   }
 
   if (type === 'ObjectID') {
     return ObjectId.isValid(String(value))
   }
+
+  return false
 }

scripts/setup-figma-dev.sh

@@ -0,0 +1,33 @@
+#!/bin/bash
+set -e
+
+# Get the absolute path to the repo root
+REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+ENTERPRISE_DIR="$REPO_ROOT/../enterprise-plugins"
+
+echo "Checking for enterprise-plugins at $ENTERPRISE_DIR..."
+
+if [ ! -d "$ENTERPRISE_DIR" ]; then
+    echo "Directory not found. Cloning enterprise-plugins..."
+    # Using git clone
+    git clone https://github.com/payloadcms/enterprise-plugins "$ENTERPRISE_DIR"
+else
+    echo "enterprise-plugins found."
+fi
+
+# Install dependencies in enterprise-plugins
+echo "Installing dependencies in enterprise-plugins..."
+cd "$ENTERPRISE_DIR"
+pnpm install
+cd "$REPO_ROOT"
+
+# Remove local file dependency from test/package.json if it exists
+# We want to rely on the vitest alias instead of package.json file: protocol
+if grep -q "@payloadcms/figma" "$REPO_ROOT/test/package.json"; then
+    echo "Removing @payloadcms/figma from test/package.json dependencies..."
+    cd "$REPO_ROOT/test"
+    pnpm remove @payloadcms/figma || true # ignore if not found by pnpm but grep found it
+    cd "$REPO_ROOT"
+fi
+
+echo "Setup complete. You can now run 'PAYLOAD_DATABASE=content-api pnpm test:int _community'."

test/database/getConfig.ts

@@ -205,6 +205,15 @@ export const getConfig: () => Partial<Config> = () => ({
           type: 'number',
           defaultValue: 1,
         },
+        {
+          name: 'numbersHasMany',
+          type: 'number',
+          hasMany: true,
+        },
+        {
+          name: 'publishDate',
+          type: 'date',
+        },
         {
           type: 'blocks',
           name: 'blocks',

test/database/int.spec.ts

@@ -2806,61 +2806,60 @@ describe('database', () => {
   })
 
   describe('Schema generation', { db: 'drizzle' }, () => {
-    if (
-      process.env.PAYLOAD_DATABASE.includes('postgres') ||
-      process.env.PAYLOAD_DATABASE === 'supabase'
-    ) {
-      it('should generate Drizzle Postgres schema', async () => {
-        const generatedAdapterName = process.env.PAYLOAD_DATABASE
+    it('should generate Drizzle Postgres schema', async () => {
+      const generatedAdapterName = process.env.PAYLOAD_DATABASE
+      if (!generatedAdapterName?.includes('postgres') && generatedAdapterName !== 'supabase') {
+        return
+      }
 
-        const outputFile = path.resolve(dirname, `${generatedAdapterName}.generated-schema.ts`)
+      const outputFile = path.resolve(dirname, `${generatedAdapterName}.generated-schema.ts`)
 
-        await payload.db.generateSchema({
-          outputFile,
-        })
+      await payload.db.generateSchema({
+        outputFile,
+      })
 
-        const module = await import(outputFile)
+      const module = await import(outputFile)
 
-        // Confirm that the generated module exports every relation
-        for (const relation in payload.db.relations) {
-          expect(module).toHaveProperty(relation)
-        }
+      // Confirm that the generated module exports every relation
+      for (const relation in payload.db.relations) {
+        expect(module).toHaveProperty(relation)
+      }
 
-        // Confirm that module exports every table
-        for (const table in payload.db.tables) {
-          expect(module).toHaveProperty(table)
-        }
+      // Confirm that module exports every table
+      for (const table in payload.db.tables) {
+        expect(module).toHaveProperty(table)
+      }
 
-        // Confirm that module exports every enum
-        for (const enumName in payload.db.enums) {
-          expect(module).toHaveProperty(enumName)
-        }
-      })
-    }
+      // Confirm that module exports every enum
+      for (const enumName in payload.db.enums) {
+        expect(module).toHaveProperty(enumName)
+      }
+    })
 
-    if (process.env.PAYLOAD_DATABASE.includes('sqlite')) {
-      it('should generate Drizzle SQLite schema', async () => {
-        const generatedAdapterName = process.env.PAYLOAD_DATABASE
+    it('should generate Drizzle SQLite schema', async () => {
+      const generatedAdapterName = process.env.PAYLOAD_DATABASE
+      if (!generatedAdapterName?.includes('sqlite')) {
+        return
+      }
 
-        const outputFile = path.resolve(dirname, `${generatedAdapterName}.generated-schema.ts`)
+      const outputFile = path.resolve(dirname, `${generatedAdapterName}.generated-schema.ts`)
 
-        await payload.db.generateSchema({
-          outputFile,
-        })
+      await payload.db.generateSchema({
+        outputFile,
+      })
 
-        const module = await import(outputFile)
+      const module = await import(outputFile)
 
-        // Confirm that the generated module exports every relation
-        for (const relation in payload.db.relations) {
-          expect(module).toHaveProperty(relation)
-        }
+      // Confirm that the generated module exports every relation
+      for (const relation in payload.db.relations) {
+        expect(module).toHaveProperty(relation)
+      }
 
-        // Confirm that module exports every table
-        for (const table in payload.db.tables) {
-          expect(module).toHaveProperty(table)
-        }
-      })
-    }
+      // Confirm that module exports every table
+      for (const table in payload.db.tables) {
+        expect(module).toHaveProperty(table)
+      }
+    })
   })
 
   describe('drizzle: schema hooks', () => {
@@ -3573,6 +3572,63 @@ describe('database', () => {
     expect(result.text).toStrictEqual('1')
   })
 
+  it('should convert strings to numbers in hasMany number fields', async () => {
+    const result = await payload.create({
+      collection: postsSlug,
+      data: {
+        title: 'testing-numbers-hasMany',
+        // @ts-expect-error passing strings when numbers are expected
+        numbersHasMany: ['10', '20', '30'],
+      },
+    })
+
+    expect(result.numbersHasMany).toEqual([10, 20, 30])
+  })
+
+  it('should store and retrieve date fields as ISO strings', async () => {
+    const testDate = new Date('2024-01-15T10:30:00.000Z')
+
+    const result = await payload.create({
+      collection: postsSlug,
+      data: {
+        title: 'testing-date-field',
+        publishDate: testDate,
+      },
+    })
+
+    // Dates should be stored as ISO strings
+    expect(typeof result.publishDate).toBe('string')
+    expect(result.publishDate).toBe('2024-01-15T10:30:00.000Z')
+
+    // Reading back should also return ISO string
+    const retrieved = await payload.findByID({
+      collection: postsSlug,
+      id: result.id,
+    })
+
+    expect(typeof retrieved.publishDate).toBe('string')
+    expect(retrieved.publishDate).toBe('2024-01-15T10:30:00.000Z')
+  })
+
+  it('should convert Unix timestamps to ISO strings for date fields', async () => {
+    // Unix timestamp for 2024-01-15T10:30:00.000Z
+    const unixTimestamp = 1705314600000
+
+    // Using payload.db.create to bypass Payload's validation and test adapter coercion
+    const result = await payload.db.create({
+      collection: postsSlug,
+      data: {
+        title: 'testing-date-coercion',
+        publishDate: unixTimestamp,
+      },
+      req: {} as any,
+    })
+
+    // Should be converted to ISO string
+    expect(typeof result.publishDate).toBe('string')
+    expect(result.publishDate).toBe('2024-01-15T10:30:00.000Z')
+  })
+
   it('should not allow to query by a field with `virtual: true`', async () => {
     await expect(
       payload.find({
@@ -3585,10 +3641,13 @@ describe('database', () => {
   it('should not allow document creation with relationship data to an invalid document ID', async () => {
     let invalidDoc
 
+    // mongo requires ObjectId, postgres UUID and content-api number (wrong type for text ID)
+    const invalidId = payload.db.name === 'content_api' ? 1 : 'not-real-id'
+
     try {
       invalidDoc = await payload.create({
         collection: 'relation-b',
-        data: { relationship: 'not-real-id', title: 'invalid' },
+        data: { relationship: invalidId, title: 'invalid' },
       })
     } catch (error) {
       // instanceof checks don't work with libsql

test/database/payload-types.ts

@@ -264,6 +264,8 @@ export interface Post {
   text?: string | null;
   number?: number | null;
   numberDefault?: number | null;
+  numbersHasMany?: number[] | null;
+  publishDate?: string | null;
   blocks?:
     | {
         nested?:
@@ -926,6 +928,8 @@ export interface PostsSelect<T extends boolean = true> {
   text?: T;
   number?: T;
   numberDefault?: T;
+  numbersHasMany?: T;
+  publishDate?: T;
   blocks?:
     | T
     | {
@@ -1520,6 +1524,6 @@ export interface Auth {
 
 
 declare module 'payload' {
-  // @ts-ignore
+  // @ts-ignore 
   export interface GeneratedTypes extends Config {}
-}
+}

test/generateDatabaseAdapter.ts

@@ -95,6 +95,16 @@ export const allDatabaseAdapters = {
     },
     readReplicas: [process.env.POSTGRES_REPLICA_URL],
   })
+        `,
+  'content-api': `
+import { contentAPIAdapter } from '@payloadcms/figma'
+export const databaseAdapter = contentAPIAdapter({
+  auth: {
+    mode: 'devJwt',
+  },
+  url: process.env.CONTENT_API_URL || 'http://localhost:8080',
+  contentSystemId: process.env.CONTENT_SYSTEM_ID || '00000000-0000-4000-8000-000000000001',
+})
   `,
   'vercel-postgres-read-replica': `
   import { vercelPostgresAdapter } from '@payloadcms/db-vercel-postgres'