Skip to content

Commit de8ecab

Browse files
author
Simon Laden
committed
FISH-8908 - remove commented lines + add reference to the source
1 parent e4ab0c1 commit de8ecab

1 file changed

Lines changed: 4 additions & 15 deletions

File tree

test/e2e/baseTest.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ export const test = base.extend<TestFixtures>({
2828

2929
const electronApp = await _electron.launch({
3030
executablePath: vscodePath,
31-
// Got it from https://github.com/microsoft/vscode-test/blob/0ec222ef170e102244569064a12898fb203e5bb7/lib/runTest.ts#L126-L160
31+
// Got it from https://github.com/gitkraken/vscode-gitlens/blob/main/tests/e2e/specs/baseTest.ts
3232
args: [
33-
'--no-sandbox', // https://github.com/microsoft/vscode/issues/84238
34-
'--disable-gpu-sandbox', // https://github.com/microsoft/vscode-test/issues/221
35-
'--disable-updates', // https://github.com/microsoft/vscode-test/issues/120
33+
'--no-sandbox',
34+
'--disable-gpu-sandbox',
35+
'--disable-updates',
3636
'--skip-welcome',
3737
'--skip-release-notes',
3838
'--disable-workspace-trust',
@@ -44,17 +44,9 @@ export const test = base.extend<TestFixtures>({
4444
});
4545

4646
const page = await electronApp.firstWindow();
47-
/*await page.context().tracing.start({
48-
screenshots: true,
49-
snapshots: true,
50-
title: test.info().title,
51-
});*/
5247

5348
await use(page);
5449

55-
/*const tracePath = test.info().outputPath('trace.zip');
56-
await page.context().tracing.stop({ path: tracePath });
57-
test.info().attachments.push({ name: 'trace', path: tracePath, contentType: 'application/zip' });*/
5850
await electronApp.close();
5951

6052
const logPath = path.join(defaultCachePath, 'user-data');
@@ -63,9 +55,6 @@ export const test = base.extend<TestFixtures>({
6355
await fs.promises.cp(logPath, logOutputPath, { recursive: true });
6456
}
6557
},
66-
// Next line is necessary because of how Playwright works. It expect a destructured pattern here:
67-
// https://github.com/microsoft/playwright/issues/14590#issuecomment-1911734641
68-
// https://github.com/microsoft/playwright/issues/21566#issuecomment-1464858235
6958

7059
// eslint-disable-next-line no-empty-pattern
7160
createTmpDir: async ({}, use) => {

0 commit comments

Comments
 (0)