Merge pull request #229 from jGauravGupta/FISH-9450

FISH-9450 Payara Tools for VSCode fails to pass environmental variables and start a Payara Micro instance

Author: jGauravGupta

package.json

@@ -227,7 +227,7 @@
 			},
 			{
 				"command": "payara.server.app.migrate",
-				"title" : "Transform to Jakarta EE 10",
+				"title": "Transform to Jakarta EE 10",
 				"category": "Payara"
 			},
 			{
@@ -725,6 +725,7 @@
 		"gradle-to-js": "^2.0.0",
 		"lodash": "^4.17.21",
 		"open": "^8.4.2 ",
+		"payara-vscode": "file:",
 		"request": "^2.88.0",
 		"tail": "^2.0.3",
 		"tmp": "^0.2.0",
@@ -736,8 +737,8 @@
 		"@types/glob": "^8.0.0",
 		"@types/lodash": "^4.14.155",
 		"@types/mocha": "^10.0.0",
-		"@types/node": "^20.3.1",
-		"@types/vscode": "^1.22.0",
+		"@types/node": "^22.5.4",
+		"@types/vscode": "^1.93.0",
 		"glob": "^7.1.7",
 		"mocha": "^10.0.0",
 		"os": "^0.1.1",

src/main/fish/payara/project/Maven.ts

@@ -132,14 +132,14 @@ export class Maven implements Build {
         }
 
         let jdkHome;
-        let env: any = {};
+        let env = { ...process.env };
         if (this.payaraInstance && (jdkHome = this.payaraInstance.getJDKHome())) {
             env['JAVA_HOME'] = jdkHome;
         }
 
-        let process: ChildProcess = cp.spawn(mavenExe, args, { cwd: this.workspaceFolder.uri.fsPath, env: env });
+        let mvnProcess: ChildProcess = cp.spawn(mavenExe, args, { cwd: this.workspaceFolder.uri.fsPath, shell: true, env: env});
 
-        if (process.pid) {
+        if (mvnProcess.pid) {
             let outputChannel = ProjectOutputWindowProvider.getInstance().get(this.workspaceFolder);
             if (silent !== true) {
                 outputChannel.show(false);
@@ -152,16 +152,16 @@ export class Maven implements Build {
                 outputChannel.append(data.toString());
                 dataCallback(data.toString());
             };
-            if (process.stdout !== null) {
-                process.stdout.on('data', logCallback);
+            if (mvnProcess.stdout !== null) {
+                mvnProcess.stdout.on('data', logCallback);
             }
-            if (process.stderr !== null) {
-                process.stderr.on('data', logCallback);
+            if (mvnProcess.stderr !== null) {
+                mvnProcess.stderr.on('data', logCallback);
             }
-            process.on('error', errorCallback);
-            process.on('exit', exitCallback);
+            mvnProcess.on('error', errorCallback);
+            mvnProcess.on('exit', exitCallback);
         }
-        return process;
+        return mvnProcess;
     }
 
     public getDefaultHome(): string | undefined {