Skip to content

Commit d4e0217

Browse files
authored
Merge pull request #77 from jGauravGupta/FISH-7529
FISH-7529 JRE cannot be found at times in Server Runtime Environments in Eclipse IDE
2 parents 21acc15 + b9e6350 commit d4e0217

1 file changed

Lines changed: 24 additions & 5 deletions

File tree

bundles/fish.payara.eclipse.tools.server/src/fish/payara/eclipse/tools/server/ui/wizards/NewPayaraRuntimeWizardFragment.java

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public void modifyText(ModifyEvent e) {
153153
validate(handle);
154154
}
155155
});
156-
156+
157157
label = new Label(group, SWT.NONE);
158158
label.setText(GlassfishWizardResources.payaraLocation);
159159
data = new GridData(GridData.FILL_HORIZONTAL | GridData.VERTICAL_ALIGN_END);
@@ -163,6 +163,9 @@ public void modifyText(ModifyEvent e) {
163163
serverLocation = new Text(group, SWT.BORDER);
164164
data = new GridData(GridData.FILL_HORIZONTAL);
165165
serverLocation.setLayoutData(data);
166+
if(getServerRuntime().getLocation() != null) {
167+
serverLocation.setText(getServerRuntime().getLocation().toPortableString());
168+
}
166169
serverLocation.addModifyListener(new ModifyListener() {
167170
@Override
168171
public void modifyText(ModifyEvent e) {
@@ -183,9 +186,6 @@ public void widgetSelected(SelectionEvent se) {
183186
serverLocation.setText(selectedDirectory);
184187
getServerRuntime().setLocation(new Path(serverLocation.getText().trim()));
185188
}
186-
// JdkFilter jdkFilter = payaraRuntime.getVersion() == null ? null
187-
// : new JdkFilter(payaraRuntime.getJavaVersionConstraint());
188-
// updateJREs(jdkFilter);
189189
}
190190
});
191191

@@ -201,9 +201,9 @@ public void widgetSelected(SelectionEvent se) {
201201

202202
jrecombo = new Combo(group, SWT.DROP_DOWN | SWT.READ_ONLY);
203203
jrecombo.setItems(jreNames);
204+
setDefaultJREComboText();
204205
data = new GridData(GridData.HORIZONTAL_ALIGN_FILL);
205206
jrecombo.setLayoutData(data);
206-
207207
jrecombo.addSelectionListener(new SelectionListener() {
208208
@Override
209209
public void widgetSelected(SelectionEvent e) {
@@ -239,6 +239,25 @@ public void widgetSelected(SelectionEvent e) {
239239
}
240240
});
241241
}
242+
243+
private void setDefaultJREComboText() {
244+
PayaraRuntime payaraRuntime = (PayaraRuntime) getServerRuntime().loadAdapter(PayaraRuntime.class, null);
245+
if (payaraRuntime != null && payaraRuntime.getVMInstall() != null) {
246+
String selectedJRE = payaraRuntime.getVMInstall().getName();
247+
248+
int defaultIndex = -1;
249+
for (int i = 0; i < jreNames.length; i++) {
250+
if (jreNames[i].equals(selectedJRE)) {
251+
defaultIndex = i;
252+
break;
253+
}
254+
}
255+
256+
if (defaultIndex != -1) {
257+
jrecombo.select(defaultIndex);
258+
}
259+
}
260+
}
242261

243262
protected void updateJREs(JdkFilter jdkFilter) {
244263
// get all installed JVMs

0 commit comments

Comments
 (0)