Because this hasn't been contributed to PatternFly yet, we haven't gotten around to replacing the original table-controls hooks in https://github.com/konveyor/tackle2-ui with it. Since we copied that code into this repo and started work to prepare it for PatternFly, more enhancements have been made to the original. If/when work resumes on this, we should look back at what has changed and decide whether to port over those new enhancements and any bug fixes.
Examples:
Note: the AttributeValueFilter introduced in forklift-console-plugin may also be a good candidate to use for inspiration for the future replacement of the legacy FilterToolbar, at least in part. https://github.com/kubev2v/forklift-console-plugin/blob/main/packages/common/src/components/FilterGroup/AttributeValueFilter.tsx
Because this hasn't been contributed to PatternFly yet, we haven't gotten around to replacing the original
table-controlshooks in https://github.com/konveyor/tackle2-ui with it. Since we copied that code into this repo and started work to prepare it for PatternFly, more enhancements have been made to the original. If/when work resumes on this, we should look back at what has changed and decide whether to port over those new enhancements and any bug fixes.Examples:
Note: the AttributeValueFilter introduced in forklift-console-plugin may also be a good candidate to use for inspiration for the future replacement of the legacy FilterToolbar, at least in part. https://github.com/kubev2v/forklift-console-plugin/blob/main/packages/common/src/components/FilterGroup/AttributeValueFilter.tsx