feat: wire TracingInterceptor, sandbox passthrough, replay-safe time, plugin name (#1)

Author: praveen5959

README.md

@@ -17,7 +17,6 @@ pip install temporal-parseable
 ```python
 from temporalio.client import Client
 from temporalio.worker import Worker
-from temporalio.worker.workflow_sandbox import SandboxedWorkflowRunner, SandboxRestrictions
 from temporal_parseable import ParseablePlugin, ParseableConfig
 
 config = ParseableConfig(
@@ -30,16 +29,12 @@ plugin = ParseablePlugin(config)
 
 client = await Client.connect("localhost:7233", plugins=[plugin])
 
-sandbox = SandboxedWorkflowRunner(
-    restrictions=SandboxRestrictions.default.with_passthrough_modules("temporal_parseable")
-)
-
 async with Worker(
     client,
     task_queue="my-queue",
     workflows=[MyWorkflow],
     activities=[my_activity],
-    workflow_runner=sandbox,
+    plugins=[plugin],
 ):
     await asyncio.Event().wait()
 ```

pyproject.toml

@@ -24,7 +24,7 @@ classifiers = [
     "Topic :: System :: Monitoring",
 ]
 dependencies = [
-    "temporalio>=1.7",
+    "temporalio>=1.23.0",
     # OTel pinned to 1.x — Temporal's contrib.opentelemetry rides 1.x.
     # Bump the ceiling once temporalio.contrib.opentelemetry moves to 2.x.
     "opentelemetry-sdk>=1.25,<2",
@@ -51,8 +51,6 @@ packages = ["src/temporal_parseable"]
 [tool.pytest.ini_options]
 asyncio_mode = "auto"
 testpaths = ["tests"]
-markers = ["integration: requires live Temporal server (skipped in CI)"]
-addopts = "-m 'not integration'"
 
 [tool.ruff]
 line-length = 100

src/temporal_parseable/__init__.py

@@ -34,8 +34,11 @@
 
 from typing import Optional, Type
 
+from opentelemetry import trace as _otel_trace
+from temporalio.contrib.opentelemetry import TracingInterceptor
 from temporalio.plugin import SimplePlugin
 from temporalio.worker import ActivityInboundInterceptor, Interceptor, WorkflowInterceptorClassInput, WorkflowOutboundInterceptor
+from temporalio.worker.workflow_sandbox import SandboxedWorkflowRunner
 
 from .config import ParseableConfig, LogsConfig, TracesConfig
 from .exporters import build_tracer_provider, build_logger_provider
@@ -47,6 +50,12 @@
 from . import workflow as _workflow_module
 from ._version import PLUGIN_VERSION
 
+_PASSTHROUGH_MODULES = (
+    "temporal_parseable",
+    "opentelemetry",
+    "google.protobuf",
+)
+
 __version__ = PLUGIN_VERSION
 __all__ = [
     "ParseablePlugin",
@@ -69,10 +78,17 @@ def __init__(self, config: Optional[ParseableConfig] = None) -> None:
         _workflow_module._set_emitter(self._emitter)
 
         worker_interceptor = _ParseableWorkerInterceptor(self._emitter)
+        interceptors: list[Interceptor] = [worker_interceptor]
+
+        if self._tracer_provider is not None:
+            _otel_trace.set_tracer_provider(self._tracer_provider)
+            tracer = self._tracer_provider.get_tracer(__name__)
+            interceptors.append(TracingInterceptor(tracer=tracer))
 
         super().__init__(
-            name="parseable.temporal",
-            interceptors=[worker_interceptor],
+            name="parseable.ParseablePlugin",
+            interceptors=interceptors,
+            workflow_runner=_apply_passthrough,
         )
 
     @property
@@ -86,6 +102,15 @@ def shutdown(self) -> None:
             self._logger_provider.shutdown()
 
 
+def _apply_passthrough(existing: object) -> SandboxedWorkflowRunner:
+    base = existing if isinstance(existing, SandboxedWorkflowRunner) else SandboxedWorkflowRunner()
+    restrictions = base.restrictions.with_passthrough_modules(*_PASSTHROUGH_MODULES)
+    return SandboxedWorkflowRunner(
+        restrictions=restrictions,
+        runner_class=base.runner_class,
+    )
+
+
 class _ParseableWorkerInterceptor(Interceptor):
     def __init__(self, emitter: ParseableEmitter) -> None:
         self._emitter = emitter

src/temporal_parseable/activity_interceptor.py

@@ -16,6 +16,7 @@
 from typing import Any, Dict, cast
 
 from temporalio import activity
+from temporalio.exceptions import ApplicationError
 from temporalio.worker import ActivityInboundInterceptor, ExecuteActivityInput
 
 from ._emitter import ParseableEmitter, _now_iso
@@ -71,7 +72,8 @@ async def execute_activity(self, input: ExecuteActivityInput) -> Any:
                 status="failed",
                 timestamp=_now_iso(),
                 duration_ms=round(duration_ms, 3),
-                error=str(exc),
+                error=exc.message if isinstance(exc, ApplicationError) else str(exc),
+                error_type=exc.type if isinstance(exc, ApplicationError) else type(exc).__name__,
             ))
             raise
 

src/temporal_parseable/exporters.py

@@ -51,8 +51,8 @@ def _sanitize_span(span: ReadableSpan) -> ReadableSpan:
             clean[key] = sanitised
     try:
         object.__setattr__(span, "_attributes", clean)
-    except (AttributeError, TypeError):
-        pass
+    except (AttributeError, TypeError) as exc:
+        logger.warning("Could not sanitize span attributes: %s", exc)
     return span
 
 

src/temporal_parseable/types.py

@@ -56,6 +56,7 @@ class ParseableEventRecord(TypedDict, total=False):
     # ── Completion / failure fields ─────────────────────────────────────────
     duration_ms: float
     error: str                         # failure message
+    error_type: str                    # ApplicationError.type or exception class name
 
     # ── Message records (signal/query/update/child_workflow/continue_as_new) ─
     direction: EventDirection

src/temporal_parseable/workflow.py

@@ -79,4 +79,5 @@ def workflow_event(name: str, data: Optional[Dict[str, Any]] = None) -> None:
         "workflow_id": info.workflow_id,
         "run_id": info.run_id,
         "workflow_name": info.workflow_type,
+        "timestamp": workflow.now().isoformat(),
     })