FF-2 migrated 27 value-position chrome.X.Y(...) calls to browser.X.Y(...) but kept type-position references on @types/chrome. Five files still have chrome.bookmarks.BookmarkTreeNode / BookmarkChangeInfo / BookmarkMoveInfo / BookmarkRemoveInfo annotations:
packages/extension-shared/src/lib/apply-remote.ts:75packages/extension-shared/src/lib/listeners.ts:107,118,132,136packages/extension-shared/src/lib/reconcile.ts:124
Meanwhile packages/extension-shared/src/popup.ts:11 was migrated to browser.Tabs.Tab (the implementer flagged it as needed for typecheck).
This compiles only because extension-shared/tsconfig.json keeps @types/chrome in types and the dep is retained in extension-shared, extension-chrome, and extension-firefox package.jsons.
Fix
Migrate the 5 remaining type-position refs to webextension-polyfill's namespace (e.g., Browser.Bookmarks.BookmarkTreeNode via import type { Browser } from "webextension-polyfill"). Then drop @types/chrome from all three packages' devDeps and the tsconfig types arrays.
Flagged by
Post-merge code review of PR #32.
FF-2 migrated 27 value-position
chrome.X.Y(...)calls tobrowser.X.Y(...)but kept type-position references on@types/chrome. Five files still havechrome.bookmarks.BookmarkTreeNode/BookmarkChangeInfo/BookmarkMoveInfo/BookmarkRemoveInfoannotations:packages/extension-shared/src/lib/apply-remote.ts:75packages/extension-shared/src/lib/listeners.ts:107,118,132,136packages/extension-shared/src/lib/reconcile.ts:124Meanwhile
packages/extension-shared/src/popup.ts:11was migrated tobrowser.Tabs.Tab(the implementer flagged it as needed for typecheck).This compiles only because
extension-shared/tsconfig.jsonkeeps@types/chromeintypesand the dep is retained inextension-shared,extension-chrome, andextension-firefoxpackage.jsons.Fix
Migrate the 5 remaining type-position refs to
webextension-polyfill's namespace (e.g.,Browser.Bookmarks.BookmarkTreeNodeviaimport type { Browser } from "webextension-polyfill"). Then drop@types/chromefrom all three packages' devDeps and the tsconfig types arrays.Flagged by
Post-merge code review of PR #32.