The `edit` utility does not work on Windows for Visual Studio Code

[ofek]

A new editor tab opens with the temporary file but the file is immediately deleted. To reproduce:

1. Install Visual Studio Code
2. Set the EDITOR environment variable to code

Environment:

• Python version: 3.11
• Click version: 8.1.6

[ofek]

I saw #1050 but the value of require_save does not matter

[davidism]

Happy to review a PR, but I won't be able to fix this myself.

[Rowlando13]

@PlumLariat is working on this.

[kdeldycke]

OK so the issue is that VScode spawns then exit immediately. This is not under Click's control. So I am not certain there is a way to fix this cleanly in Click. As I don't know if there is a magical generic incantation that exists in Windows to do that. Any Windows expert around here?

Other path is to tweak the way we call these editors from Click. But it suppose that these editors can be fed with the right options to ask them to wait for us. Which means we might have to maintain a list of all editors on Windows and their respective way of telling them nicely to wait for us. I just did similar work for the less command in #3777 , but that is a standard utility so I guess it is acceptable. Not sure we should go further than that by listing all kind of exotic editors. I need other maintainers to draw the line on this topic.

A temporary solution might be to add a FAQ entry to document this limitation like I did with #3778.

[kdeldycke]

Wait, this is not a Windows specific issue. It happens on all platforms with VSCode. And any other editor that rely on an intermediate script to launch themselves then return immediately. So this seal the deal: it is not under Click's control and there is little we can do about it.

Still, I just added an FAQ entry to explain the situation and how to solve it on your particular machine: #3780