-
Notifications
You must be signed in to change notification settings - Fork 5
🎨 fix(newsletter): Remove unnecessary data attributes from newsletter… #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ludovicobesana
merged 2 commits into
main
from
13-cuj04-broken-image-in-newsletter-section
May 21, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| <style> | ||
| .rubicon-newsletter-input { | ||
| background: transparent; | ||
| color: #FCF7E8 !important; | ||
| border-bottom: 1px solid rgba(252, 247, 232, 0.7) !important; | ||
| } | ||
| .rubicon-newsletter-input::placeholder { | ||
| color: rgba(252, 247, 232, 0.55); | ||
| opacity: 1; | ||
| } | ||
| </style> | ||
|
|
||
| <section class="text-[#FCF7E8] relative overflow-hidden" style="background-image: url('{{ '/assets/images/marble.png' | relative_url }}'); background-size: cover; background-position: center; border-top: 1px solid #9C5E62; border-bottom: 1px solid #9C5E62;"> | ||
| <div class="mx-auto w-full max-w-[1376px] px-6 md:px-8 py-20 md:py-24 text-center min-h-[472px] flex flex-col items-center justify-center relative z-10"> | ||
| <h2 class="mb-4 md:mb-6" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 400; font-size: 48px; line-height: 56px; letter-spacing: 0; text-transform: none;"> | ||
| Cross the Rubicon. | ||
| </h2> | ||
| <p class="max-w-[760px] mx-auto mb-8 md:mb-10" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 400; font-size: 20px; line-height: 32px; letter-spacing: 0; text-align: center;"> | ||
| Rimini, 8 May. Nine talks, one stage, dinner on the beach, | ||
| and the rest of the weekend in Italy. | ||
| </p> | ||
|
|
||
| <div class="w-[318px] min-h-[88px] flex flex-col items-center gap-4 mx-auto"> | ||
| <a href="{{ site.event.tickets_url }}" class="inline-flex items-center justify-center" style="box-sizing: border-box; width: 254px; height: 52px; padding: 16px 32px; border: 1px solid #FCF7E8; color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none; vertical-align: middle; white-space: nowrap;"> | ||
| Get your ticket now | ||
| </a> | ||
|
|
||
| <p style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 20px; letter-spacing: 0; text-align: center; opacity: 0.95;"> | ||
| Early bird from €99 · Price goes up April 15 | ||
| </p> | ||
| </div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <section class="text-[#FCF7E8] relative overflow-hidden" style="background-image: url('{{ '/assets/images/marble.png' | relative_url }}'); background-size: cover; background-position: center; border-top: 1px solid #9C5E62; border-bottom: 1px solid #9C5E62;"> | ||
| <div class="mx-auto w-full max-w-[1376px] px-6 md:px-8 py-12 md:py-16 min-h-[480px] flex flex-col relative z-10"> | ||
| <div class="mb-10 md:mb-12"> | ||
| <h3 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 24px; line-height: 24px; letter-spacing: 0; text-transform: none;"> | ||
| Stay in the loop | ||
| </h3> | ||
| <form action="https://app.convertkit.com/forms/8a5a8f8636/subscriptions" method="post" class="flex items-center gap-4 w-full h-[40px]" style="max-width: 448px;"> | ||
| <input type="email" name="email_address" placeholder="your@email.com" required class="rubicon-newsletter-input" | ||
| style="flex: 1; min-width: 0; height: 40px; border: 0; color: #FCF7E8 !important; padding: 4px 0; font-family: 'Inter', sans-serif; font-weight: 400; font-size: 20px; line-height: 32px; letter-spacing: 0;" /> | ||
| <button type="submit" style="width: 120px; height: 40px; padding: 0 8px; border: 1px solid #FCF7E8; color: #FCF7E8; background: transparent; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 16px; line-height: 16px; letter-spacing: 0; text-transform: none;"> | ||
| Subscribe | ||
| </button> | ||
| </form> | ||
| </div> | ||
|
|
||
| <div class="grid grid-cols-2 md:grid-cols-4 gap-y-8 gap-x-8 mt-2 md:mt-auto"> | ||
| <div> | ||
| <h4 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none;">Conference</h4> | ||
| <ul class="space-y-2"> | ||
| <li><a href="/schedule/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Schedule</a></li> | ||
| <li><a href="/speakers/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Speakers</a></li> | ||
| <li><a href="/logistics/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Venue and travel</a></li> | ||
| <li><a href="/sponsors/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Sponsors</a></li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <div> | ||
| <h4 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none;">More</h4> | ||
| <ul class="space-y-2"> | ||
| <li><a href="/articles/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Blog</a></li> | ||
| <li><a href="/faq/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">FAQ</a></li> | ||
| <li><a href="/scholarship/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Scholarship</a></li> | ||
| <li><a href="/code-of-conduct/" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Code of Conduct</a></li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <div> | ||
| <h4 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none;">Social</h4> | ||
| <ul class="space-y-2"> | ||
| <li><a href="https://www.linkedin.com/company/rubycon-italy" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">LinkedIn</a></li> | ||
| <li><a href="https://www.instagram.com/rubyconitaly/" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Instagram</a></li> | ||
| <li><a href="https://bsky.app/profile/rubyconitaly.bsky.social" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Bluesky</a></li> | ||
| <li><a href="https://mastodon.social/@rubycon" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Mastodon</a></li> | ||
| <li><a href="https://x.com/rubyconitaly" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">X</a></li> | ||
| </ul> | ||
| </div> | ||
|
|
||
| <div> | ||
| <h4 class="mb-4" style="color: #FCF7E8; font-family: 'Noto Serif', serif; font-weight: 500; font-size: 20px; line-height: 20px; letter-spacing: 0; text-transform: none;">Contact</h4> | ||
| <ul class="space-y-2"> | ||
| <li><a href="mailto:{{ site.info_email }}" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">{{ site.info_email }}</a></li> | ||
| <li><a href="https://discord.gg/T43GHE6wHH" target="_blank" rel="noopener noreferrer" style="color: #FCF7E8; font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0;">Discord</a></li> | ||
| <li class="pt-2" style="font-family: 'Inter', sans-serif; font-weight: 300; font-size: 16px; line-height: 32px; letter-spacing: 0; opacity: 0.75;">Hotel Ambasciatori<br>Rimini, Italy</li> | ||
| </ul> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </section> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the repository style guide (lines 50 and 78), any change to a file requires updating the
site_versioninrubycon.it/_config.ymland adding a corresponding entry toCHANGELOG.md. Please ensure these updates are included in this pull request to maintain consistency with the project's versioning and documentation standards.References