No options for 120 max length with 2 spaces

[freerider7777]

GOOGLE is good that is has 2 spaces (but 100 max length), PALANTIR is good that it has 120 length (but 4 spaces) - why not add 120 length with 2 spaces?

[koppor]

Maybe because of

increased consistency across all repos, so contributing to other projects feels familiar

Source: https://github.com/palantir/palantir-java-format#upsides-of-automatic-formatting

---

Some interesting links:

• 8 spaces rock: https://stackoverflow.com/a/26669198/873282
• 4 spaces come from the Sun's Java Code conventions: https://www.reddit.com/r/dartlang/comments/ilhr3i/comment/g3tnf3b/?utm_source=share&utm_medium=web2x&context=3

  four spaces should be used as the unit of indentation -- Java Code Conventions, 1997, Sun Microsystems, https://www.oracle.com/technetwork/java/codeconventions-150003.pdf

• tabs are objectively better than spaces (due to accessibility reasons): https://gomakethings.com/tabs-are-objectively-better-than-spaces/

  Another accessibility reason for tabs: when using a braille display, each space takes up one character cell, so indenting with four spaces eats up four cells. Indenting three times with four spaces each eats up 12 characters already. Tabs only take one character cell each, so three indents = three character cells used.

  Given many, if not most, braille displays are 40 cells long, and that 70-to 80-cell displays are considered a luxury, and you can see how cutting 12 space characters down to 3 tab characters could be really, really helpful.

• Another article arguing for accessibility: https://alexandersandberg.com/articles/default-to-tabs-instead-of-spaces-for-an-accessible-first-environment/

Nevertheless, I think, it's hard to change the Java codestyle rule of 1997.

[freerider7777]

@koppor Thanks for the links. But as there are options as GOOGLE/PALANTIR/AOSP - why not make it configurable :)) We have corporate code style - so we need to recompile such plugins...

[laglangyue]

Can we support options for maxLength and spaces length ?

[talios]

I do a hacky workaround via the spotless maven plugin:

<indent>
  <tabs>true</tabs>
  <spacesPerTab>4</spacesPerTab>                                                                               </indent>
<indent>
  <spaces>true</spaces>
  <spacesPerTab>2</spacesPerTab>
</indent>

Change the 4sp indent to tabs, then tabs to 2sp. It lets me/us maintain the 2sp indent we had been working with previously. Unfortunately, this means that some lines wrap when they should not, due to the original 4-sp mandate of Palantir.

[norbertwnuk]

There is an open PR that does exactly that: #1658
Understand the preference to not expose the individual parameters for manipulation, however majority of us are interested in just this one configuration that only increase number of predefined styles from 3 to 4.

[norbertwnuk]

Snippet for those who are on Nix and need to patch indentationMultiplier / maxLineLength parameters.
Unfortunately upcoming Nix package will be JAR based: NixOS/nixpkgs#496426, so it will not simplify patching.

let
  # ...
  # https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/gradle.section.md
  palantir-java-format-pkg = chStable.stdenv.mkDerivation (finalAttrs: {
    pname = "palantir-java-format";
    version = "2.92.0";
    src = chStable.fetchFromGitHub {
      owner = "palantir";
      repo = "palantir-java-format";
      rev = "2.92.0";
      hash = "sha256-MxHQliL9ulWnuj3IZYVbON4FRPCNU5BQepD4W5fGe2Y=";
    };
    patches = [
      (chStable.fetchpatch {
        url = "https://github.com/SabreOSS/palantir-java-format/commit/1cb90e434c6ac9c609954a53e6d516d62080ecf7.patch";
        hash = "sha256-18ICUO84QoesCwrt/YEe2GyHLEqo2LTm5/lHWgih2g8=";
      })
    ];
    nativeBuildInputs = [ chStable.gradle ];
    mitmCache = chStable.gradle.fetchDeps {
      pkg = finalAttrs.finalPackage;
      data = ./palantir-java-format/palantir-java-format-deps.json;
      useBwrap = false;
    };
    gradleBuildTask = ":palantir-java-format-native:nativeCompile";
    doCheck = false;
    installPhase = ''
      runHook preInstall
      install -Dm755 palantir-java-format-native/build/native/nativeCompile/palantir-java-format-linux-glibc_x86-64 $out/bin/palantir-java-format
      runHook postInstall
    '';
    gradleFlags = [
      "--info"
    ];
    postPatch = ''
      sed -i \
        -e "/apply plugin: 'com.palantir.jdks.settings'/d" \
        settings.gradle
      sed -i \
        -e '/^jdks {/,/^}/d' \
        -e "/apply plugin: 'com.palantir.jdks'/d" \
        -e "/apply plugin: 'com.palantir.jdks.latest'/d" \
        -e "/apply plugin: 'com.palantir.git-version'/d" \
        -e "s/gitVersion()/'${finalAttrs.version}'/g" \
        build.gradle
      sed -i \
        -e "/include ':eclipse_plugin'/d" \
        -e "/include ':idea-plugin'/d" \
        -e "/include ':palantir-java-format-benchmarks'/d" \
        -e "/include ':gradle-palantir-java-format'/d" \
        settings.gradle
      sed -i \
        -e "s/JavaLanguageVersion.of(23)/JavaLanguageVersion.of(25)/g" \
        palantir-java-format-native/build.gradle
      echo 'graalvmNative { metadataRepository { enabled = false } }' >> palantir-java-format-native/build.gradle
      echo 'org.gradle.java.installations.paths=${chStableUnfree.graalvmPackages.graalvm-ce},${chStable.jdk21.home}' >> gradle.properties
    '';
  });
# ...
in
{
  # required for regeneration of the package only
  # $(nix-build pre-commit-hooks.nix -A palantir-java-format-pkg.mitmCache.updateScript)
  # inherit palantir-java-format-pkg;
  pre-commit-check = nix-pre-commit-hooks.run {
    hooks = {
      palantir-java-format = {
        enable = true;
        entry = ''${palantir-java-format-pkg}/bin/palantir-java-format -DindentationMultiplier=1 -DmaxLineLength=120 --replace --set-exit-if-changed'';
        types = [ "java" ];
        files = "^.*\\.java$";
      };  
    }
  }
}