From b94069ce786a7e09e84846df6ff5ac10cd7b24dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <1005065+DeepDiver1975@users.noreply.github.com> Date: Tue, 19 May 2026 13:05:21 +0200 Subject: [PATCH 1/2] feat(acceptance): add server-version input to allow custom ownCloud server version MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds a new optional input server-version (default: 'daily-master-qa') that is passed as PLUGIN_VERSION to the owncloudci/core Docker image in both the main and federated install steps. The owncloudci/core image constructs the download URL as: owncloud-${PLUGIN_VERSION}.tar.bz2 and falls back through daily/ → testing/ → stable/ channels, so: daily-master-qa → owncloud-daily-master-qa.tar.bz2 (OC11 nightly, from daily/) 10.16.2-qa → owncloud-10.16.2-qa.tar.bz2 (OC10 QA build, from testing/) All existing callers are unaffected since daily-master-qa remains the default. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --- .github/workflows/acceptance.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml index 8b74e0b..7615016 100644 --- a/.github/workflows/acceptance.yml +++ b/.github/workflows/acceptance.yml @@ -70,6 +70,11 @@ on: required: false type: string default: 'master' + server-version: + description: 'ownCloud server version to install (passed as PLUGIN_VERSION to owncloudci/core docker image). Use daily-master-qa for the OC11 nightly, or e.g. 10.16.2-qa for an OC10 testing release.' + required: false + type: string + default: 'daily-master-qa' filter-tags: description: test tags to run (or not run) required: false @@ -231,7 +236,7 @@ jobs: - name: Install owncloud/core env: SERVER_ROOT: ${{ steps.prepend.outputs.server-root }} - VERSION: 'daily-master-qa' + VERSION: ${{ inputs.server-version }} CORE_PATH: /var/www/html${{ steps.prepend.outputs.server-root }} DB_TYPE: 'mysql' DB_NAME: 'owncloud' @@ -260,7 +265,7 @@ jobs: if: ${{ inputs.federated-folder != '' }} env: FEDERATED_ROOT: ${{ steps.prepend.outputs.federated-root }} - VERSION: 'daily-master-qa' + VERSION: ${{ inputs.server-version }} CORE_PATH: /var/www/html${{ steps.prepend.outputs.federated-root }} DB_TYPE: 'mysql' DB_NAME: federateddb From 5bffdc50c8a4ec3d86c494c1beed20d200a2cced Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= <1005065+DeepDiver1975@users.noreply.github.com> Date: Tue, 19 May 2026 18:28:45 +0200 Subject: [PATCH 2/2] feat(acceptance): add app-ref input and example invocations in test.yml MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds optional app-ref input to acceptance.yml (defaults to repo default branch) so callers can pin a specific tag, branch, or SHA for the app checkout. Adds two example jobs to test.yml: - acceptance-api-oc10: tests against OC10 (server-version: 10.16.2-qa, app-ref: v0.6.1 which is the last OC10-compatible impersonate release) - acceptance-api-explicit-default: confirms server-version wiring by passing the default value (daily-master-qa) explicitly Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com> --- .github/workflows/acceptance.yml | 6 ++++++ .github/workflows/test.yml | 19 +++++++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml index 7615016..2ad17d4 100644 --- a/.github/workflows/acceptance.yml +++ b/.github/workflows/acceptance.yml @@ -25,6 +25,11 @@ on: required: false type: string default: '' + app-ref: + description: 'Git ref (branch, tag, or SHA) to checkout for the app repository. Defaults to the repository default branch.' + required: false + type: string + default: '' server-folder: description: 'The folder under the Apache root in which to install owncloud core' required: false @@ -166,6 +171,7 @@ jobs: with: path: apps/${{ inputs.app-name }} repository: ${{ inputs.app-repository }} + ref: ${{ inputs.app-ref }} - name: Checkout additional app if: ${{ inputs.additional-app != '' }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8aff426..aa869ab 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -119,3 +119,22 @@ jobs: app-repository: owncloud/notifications do-api-tests: true use-email-server: true + + acceptance-api-oc10: + name: API acceptance tests (OC10) + uses: ./.github/workflows/acceptance.yml + with: + app-name: impersonate + app-repository: owncloud/impersonate + app-ref: 'v0.6.1' + do-api-tests: true + server-version: '10.16.2-qa' + + acceptance-api-explicit-default: + name: API acceptance tests (explicit default version) + uses: ./.github/workflows/acceptance.yml + with: + app-name: impersonate + app-repository: owncloud/impersonate + do-api-tests: true + server-version: 'daily-master-qa'