feat: support headers and query params

Handle URL building and header setting

Author: maniac-en

internal/http/manager.go

@@ -3,6 +3,7 @@ package http
 import (
 	"fmt"
 	"net/http"
+	"net/url"
 	"strings"
 	"time"
 
@@ -59,13 +60,24 @@ func (h *HTTPManager) ExecuteRequest(req *Request) (*Response, error) {
 
 	log.Debug("executing HTTP request", "method", req.Method, "url", req.URL)
 
+	requestURL, err := h.buildURL(req.URL, req.QueryParams)
+	if err != nil {
+		log.Error("failed to build URL", "error", err)
+		return nil, fmt.Errorf("failed to build URL: %w", err)
+	}
+
 	start := time.Now()
-	httpReq, err := http.NewRequest(strings.ToUpper(req.Method), req.URL, nil)
+	httpReq, err := http.NewRequest(strings.ToUpper(req.Method), requestURL, nil)
 	if err != nil {
 		log.Error("failed to create HTTP request", "error", err)
 		return nil, fmt.Errorf("failed to create request: %w", err)
 	}
 
+	if err := h.setHeaders(httpReq, req.Headers); err != nil {
+		log.Error("failed to set headers", "error", err)
+		return nil, fmt.Errorf("failed to set headers: %w", err)
+	}
+
 	resp, err := h.Client.Do(httpReq)
 	if err != nil {
 		log.Error("HTTP request failed", "error", err)
@@ -85,3 +97,32 @@ func (h *HTTPManager) ExecuteRequest(req *Request) (*Response, error) {
 	log.Info("HTTP request completed", "status", resp.StatusCode, "duration", duration)
 	return response, nil
 }
+
+func (h *HTTPManager) buildURL(baseURL string, queryParams map[string]string) (string, error) {
+	if len(queryParams) == 0 {
+		return baseURL, nil
+	}
+
+	parsedURL, err := url.Parse(baseURL)
+	if err != nil {
+		return "", err
+	}
+
+	values := parsedURL.Query()
+	for key, value := range queryParams {
+		values.Set(key, value)
+	}
+	parsedURL.RawQuery = values.Encode()
+
+	return parsedURL.String(), nil
+}
+
+func (h *HTTPManager) setHeaders(req *http.Request, headers map[string]string) error {
+	for key, value := range headers {
+		if strings.TrimSpace(key) == "" {
+			return fmt.Errorf("header key cannot be empty")
+		}
+		req.Header.Set(key, value)
+	}
+	return nil
+}

internal/http/manager_test.go

@@ -1,6 +1,7 @@
 package http
 
 import (
+	"net/http"
 	"testing"
 	"time"
 )
@@ -86,3 +87,46 @@ func TestValidateRequest(t *testing.T) {
 		t.Error("expected invalid request to fail validation")
 	}
 }
+
+func TestBuildURL(t *testing.T) {
+	manager := NewHTTPManager()
+
+	tests := []struct {
+		baseURL     string
+		queryParams map[string]string
+		expected    string
+	}{
+		{"https://example.com", nil, "https://example.com"},
+		{"https://example.com", map[string]string{}, "https://example.com"},
+		{"https://example.com", map[string]string{"foo": "bar"}, "https://example.com?foo=bar"},
+	}
+
+	for _, test := range tests {
+		result, err := manager.buildURL(test.baseURL, test.queryParams)
+		if err != nil {
+			t.Errorf("buildURL failed: %v", err)
+		}
+		if result != test.expected {
+			t.Errorf("expected %s, got %s", test.expected, result)
+		}
+	}
+}
+
+func TestSetHeaders(t *testing.T) {
+	manager := NewHTTPManager()
+	req, _ := http.NewRequest("GET", "https://example.com", nil)
+
+	headers := map[string]string{
+		"Content-Type": "application/json",
+		"User-Agent":   "req-cli",
+	}
+
+	err := manager.setHeaders(req, headers)
+	if err != nil {
+		t.Errorf("setHeaders failed: %v", err)
+	}
+
+	if req.Header.Get("Content-Type") != "application/json" {
+		t.Error("Content-Type header not set correctly")
+	}
+}