Upgrade to patternfly-6 alpha. pf-codemods not working

[ShivamG0217]

Hi Team,

I'm facing an issue while upgrading a Patternfly 5 project to Patternfly 6 alpha. I've followed the upgrade guide and updated the dependencies accordingly. However, when running pf-codemods with the --v6 flag, I'm not getting any output in the console. There are no errors, just a blank result.

Are there any specific steps or configurations I should be aware of for Patternfly 6 alpha upgrades?

Below is the result when I ran it for the first time, after that I am just getting blank output.

npx @patternfly/pf-codemods@2.2.2 --v6 ./src
Need to install the following packages:
@patternfly/pf-codemods@2.2.2
Ok to proceed? (y) y

npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead

I have also tried the above command giving the full path of the src folder still didnt got any result.

Addition to this I can see a cache file is getting generated in the root folder of my project, On checking that I can see it contain all the filepath of the files that are in my src folder along with some json data as given below.

`[{
    "hashOfConfig": "8",
    "mtime": 1724826385427,
    "results": "7",
    "size": 1307
    },
    {
    "hashOfConfig": "8",
    "mtime": 1724843762337,
    "results": "9",
    "size": 16736
    },
    {
    "hashOfConfig": "8",
    "mtime": 1724843942408,
    "results": "10",
    "size": 13620
    },
    {
    "hashOfConfig": "8",
    "mtime": 1724826385427,
    "results": "11",
    "size": 3303
    },
    {
    "hashOfConfig": "8",
    "mtime": 1724844288066,
    "results": "12",
    "size": 7821
    },
    {
    "hashOfConfig": "8",
    "mtime": 1724826385427,
    "results": "13",
    "size": 1704
    },
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "14",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "15",
    "suppressedMessages": "16",
    "warningCount": 0
    },
"ek6qj1",
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "17",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "18",
    "suppressedMessages": "19",
    "warningCount": 0
    },
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "20",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "21",
    "suppressedMessages": "22",
    "warningCount": 0
    },
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "23",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "24",
    "suppressedMessages": "25",
    "warningCount": 0
    },
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "26",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "27",
    "suppressedMessages": "28",
    "warningCount": 0
    },
    {
    "errorCount": 0,
    "fatalErrorCount": 0,
    "filePath": "29",
    "fixableErrorCount": 0,
    "fixableWarningCount": 0,
    "messages": "30",
    "suppressedMessages": "31",
    "warningCount": 0
    }]`

[wise-king-sullyman]

Hello @ShivamG0217,

I'm not able to reproduce your issue, can you link your codebase, ideally in the state you're currently trying to run the codemods in?

[wise-king-sullyman]

Are you sure that you should be getting any errors thrown?

Also did something in our instructions say to delete your lock file? AFAIK as a general rule you shouldn't do that unless there is some particular reason for which you really need to.

[ShivamG0217]

yes, I should be getting errors as when I try to build it I got multiple errors and I have checked codemods docs and those contain rules for them.

Regarding the lock file I have tried without deleting them, it didnt worked at that time as well, so while trying to resolve the issue I have deleted the file.

[wise-king-sullyman]

Are you using windows @ShivamG0217?

[ShivamG0217]

yes

[wise-king-sullyman]

That seems to be what's causing the issue, if you're able to run them in a *nix environment they should work. We will create an issue to address them not working on windows though.

[LukasStordeur]

I'm facing a similar issue on our project. The codemod cretaes the cache-file but exits without error code and without fixing/linting the files.
We are migrating from pf5 to the alpha, you can find the repo here: https://github.com/inmanta/web-console
(We know the Readme is stating we are using V4, but it's a bit outdated and need to be refreshed)

You won't be able to install it as is, since we are using a licenced package that can't be placed on github.
If you remove the "@inmanta/rappid": "^4.0.0", dependency from the package.json, you should be able to run the install the project and run the codemods.

I'm running on W11, and tried to run the codemod both in bash and powershell, and I'm on LTS Node version.

[wise-king-sullyman]

Thanks for adding your report! I ran our codemods on the repo and am seeing a ton of errors/warnings so I'm not sure what is causing the difference. Did you run it with the --v6 flag?

Screenshot of my command and some of my response:

If you ran the command same as I did it might be a Windows issue. Can you test in a different dev env, or at least in something like WSL if you're not using that already?

[LukasStordeur]

@wise-king-sullyman
Sorry for the late response, I just tested it in a linux environment, and yes it works.
I managed to spot the difference too, the paths in the cache files are correct in the linux environment,
/home/usr/web-console/src/Core/Command/Command.ts
but in the windows one, you end up with double slahes.
C:\\web-console\\src\\config.js

So my take is that you have some escaping logic missing. If it helps, the previous mods worked in the past when we upgraded from V4 to V5, so the solution might be lying at hand there.

[wise-king-sullyman]

👍 thank you for letting us know! I created patternfly/pf-codemods#798 to track this issue 🙂