From 6092b293a942c1905e3c11d1ebc9eec4c4ed2485 Mon Sep 17 00:00:00 2001 From: Dennis-Mircea Ciupitu Date: Wed, 27 May 2026 14:18:57 +0300 Subject: [PATCH 1/2] improve: clarify EventProcessor logging and contract for events received before start Signed-off-by: Dennis-Mircea Ciupitu --- .../operator/processing/event/EventProcessor.java | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java index 1aecac6c9a..efda250116 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java @@ -111,6 +111,14 @@ private EventProcessor( .orElseGet(HashMap::new); } + /** + * Receives an {@link Event} from a registered {@link + * io.javaoperatorsdk.operator.processing.event.source.EventSource} and either dispatches it for + * immediate processing or, if this processor has not been {@link #start() started} yet, marks it + * in the resource state so it can be replayed by {@link #handleAlreadyMarkedEvents()} once the + * processor starts. Events received during the start-up window between event source readiness + * and processor start are therefore deferred rather than dropped. + */ @Override public synchronized void handleEvent(Event event) { try { @@ -134,7 +142,8 @@ public synchronized void handleEvent(Event event) { cleanupForDeletedEvent(state.getId()); } // events are received and marked, but will be processed when started, see start() method. - log.debug("Skipping event: {} because the event processor is not started", event); + log.debug( + "Deferring event: {} until the event processor starts", event); return; } handleMarkedEventForResource(state); From 174fa491f26372a5a166cf9756aec8c12689cc47 Mon Sep 17 00:00:00 2001 From: Dennis-Mircea Ciupitu Date: Wed, 27 May 2026 14:50:06 +0300 Subject: [PATCH 2/2] Properly format the code Signed-off-by: Dennis-Mircea Ciupitu --- .../operator/processing/event/EventProcessor.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java index efda250116..5af48a1694 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventProcessor.java @@ -116,8 +116,8 @@ private EventProcessor( * io.javaoperatorsdk.operator.processing.event.source.EventSource} and either dispatches it for * immediate processing or, if this processor has not been {@link #start() started} yet, marks it * in the resource state so it can be replayed by {@link #handleAlreadyMarkedEvents()} once the - * processor starts. Events received during the start-up window between event source readiness - * and processor start are therefore deferred rather than dropped. + * processor starts. Events received during the start-up window between event source readiness and + * processor start are therefore deferred rather than dropped. */ @Override public synchronized void handleEvent(Event event) { @@ -142,8 +142,7 @@ public synchronized void handleEvent(Event event) { cleanupForDeletedEvent(state.getId()); } // events are received and marked, but will be processed when started, see start() method. - log.debug( - "Deferring event: {} until the event processor starts", event); + log.debug("Deferring event: {} until the event processor starts", event); return; } handleMarkedEventForResource(state);