Allow filtering servers by their metadata

Author: carolynvs

src/corelib/Compute/v2_1/ServerListOptions.cs

@@ -6,6 +6,12 @@ namespace OpenStack.Compute.v2_1
     /// <summary />
     public class ServerListOptions : PageOptions
     {
+        /// <summary />
+        public ServerListOptions()
+        {
+            Metadata = new Dictionary<string, string>();
+        }
+
         /// <summary />
         public DateTimeOffset? UpdatedAfter { get; set; }
 
@@ -21,6 +27,9 @@ public class ServerListOptions : PageOptions
         /// <summary />
         public ServerStatus Status { get; set; }
 
+        /// <summary />
+        public IDictionary<string, string> Metadata { get; set; } 
+
         /// <summary />
         protected override IDictionary<string, object> BuildQueryString()
         {
@@ -30,6 +39,7 @@ protected override IDictionary<string, object> BuildQueryString()
             queryString["flavor"] = FlavorId;
             queryString["name"] = Name;
             queryString["status"] = Status;
+            queryString["metadata"] = Metadata;
 
             return queryString;
         }

src/testing/integration/Compute/v2_1/ServerTests.cs

@@ -148,12 +148,27 @@ public async Task FindServersTest()
         {
             var servers = await _testData.CreateServers();
             await Task.WhenAll(servers.Select(x => x.WaitUntilActiveAsync()));
+
+            var serverWithMetadata = servers.First();
+            var fooValue = Guid.NewGuid().ToString();
+            await serverWithMetadata.Metadata.CreateAsync("foo", fooValue);
+
             var serversNames = new HashSet<string>(servers.Select(s => s.Name));
 
             var results = await _compute.ListServerSummariesAsync(new ServerListOptions {Name = "ci-*"});
             var resultNames = new HashSet<string>(results.Select(s => s.Name));
 
             Assert.Subset(resultNames, serversNames);
+
+            Trace.WriteLine("Filtering servers by their metadata...");
+            results = await _compute.ListServerSummariesAsync(new ServerListOptions
+            {
+                Metadata =
+                {
+                    {"foo", fooValue}
+                }
+            });
+            Assert.Equal(1, results.Count());
         }
 
         [Fact]

src/testing/unit/Compute/v2_1/ServerTests.cs

@@ -44,6 +44,17 @@ public void SerializeServerWithoutSchedulerHints()
             Assert.Equal(expectedJson, json);
         }
 
+        [Fact]
+        public void SerializeListServerOptionsInUrl()
+        {
+            using (var httpTest = new HttpTest())
+            {
+                httpTest.RespondWithJson(new ServerSummaryCollection());
+                _compute.ListServerSummaries(new ServerListOptions());
+                httpTest.ShouldNotHaveCalled("*metadata*");
+            }   
+        }
+
         [Fact]
         public void CreateServer()
         {