Skip to content

Commit 8ca2e36

Browse files
committed
Comment out os-volume-types
It is documented but doesn't seem to exist: https://bugs.launchpad.net/openstack-api-site/+bug/1543169
1 parent 14a1299 commit 8ca2e36

5 files changed

Lines changed: 45 additions & 36 deletions

File tree

src/corelib/Compute/v2_1/ComputeApiBuilder.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1161,13 +1161,13 @@ protected ComputeApiBuilder(IServiceType serviceType, IAuthenticationProvider au
11611161
return Endpoint.PrepareGetResourceRequest("os-volumes", cancellationToken);
11621162
}
11631163

1164-
/// <summary />
1165-
public virtual async Task<T> ListVolumeTypesAsync<T>(CancellationToken cancellationToken = default(CancellationToken))
1166-
{
1167-
return await BuildListVolumeTypesAsync(cancellationToken)
1168-
.SendAsync()
1169-
.ReceiveJson<T>();
1170-
}
1164+
///// <summary />
1165+
//public virtual async Task<T> ListVolumeTypesAsync<T>(CancellationToken cancellationToken = default(CancellationToken))
1166+
//{
1167+
// return await BuildListVolumeTypesAsync(cancellationToken)
1168+
// .SendAsync()
1169+
// .ReceiveJson<T>();
1170+
//}
11711171

11721172
/// <summary />
11731173
public virtual Task<PreparedRequest> BuildListVolumeTypesAsync(CancellationToken cancellationToken = default(CancellationToken))

src/corelib/Compute/v2_1/ComputeService.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -452,11 +452,11 @@ public ComputeService(IAuthenticationProvider authenticationProvider, string reg
452452
return await _computeApi.ListVolumesAsync<VolumeCollection>(cancellationToken);
453453
}
454454

455-
/// <inheritdoc cref="ComputeApiBuilder.ListVolumeTypesAsync{T}" />
456-
public async Task<IEnumerable<VolumeType>> ListVolumeTypesAsync(CancellationToken cancellationToken = default(CancellationToken))
457-
{
458-
return await _computeApi.ListVolumeTypesAsync<VolumeTypeCollection>(cancellationToken);
459-
}
455+
///// <inheritdoc cref="ComputeApiBuilder.ListVolumeTypesAsync{T}" />
456+
//public async Task<IEnumerable<VolumeType>> ListVolumeTypesAsync(CancellationToken cancellationToken = default(CancellationToken))
457+
//{
458+
// return await _computeApi.ListVolumeTypesAsync<VolumeTypeCollection>(cancellationToken);
459+
//}
460460

461461
/// <inheritdoc cref="ComputeApiBuilder.ListVolumeSnapshotsAsync{T}" />
462462
public async Task<IEnumerable<VolumeSnapshot>> ListVolumeSnapshotsAsync(CancellationToken cancellationToken = default(CancellationToken))

src/corelib/Compute/v2_1/ComputeServiceExtensions.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -432,11 +432,11 @@ public static IEnumerable<Volume> ListVolumes(this ComputeService service)
432432
return service.ListVolumesAsync().ForceSynchronous();
433433
}
434434

435-
/// <inheritdoc cref="ComputeService.ListVolumeTypesAsync" />
436-
public static IEnumerable<VolumeType> ListVolumeTypes(this ComputeService service)
437-
{
438-
return service.ListVolumeTypesAsync().ForceSynchronous();
439-
}
435+
///// <inheritdoc cref="ComputeService.ListVolumeTypesAsync" />
436+
//public static IEnumerable<VolumeType> ListVolumeTypes(this ComputeService service)
437+
//{
438+
// return service.ListVolumeTypesAsync().ForceSynchronous();
439+
//}
440440

441441
/// <inheritdoc cref="ComputeService.ListVolumeSnapshotsAsync" />
442442
public static IEnumerable<VolumeSnapshot> ListVolumeSnapshots(this ComputeService service)

src/testing/integration/Compute/v2_1/VolumeTests.cs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,15 @@ public void Dispose()
3434
_testData.Dispose();
3535
}
3636

37+
// Endpoint is documented but doesn't exist
38+
//[Fact]
39+
//public async Task ListVolumeTypes()
40+
//{
41+
// var types = await _compute.ListVolumeTypesAsync();
42+
// Assert.NotNull(types);
43+
// Assert.Contains("lvm", types.Select(x => x.Name));
44+
//}
45+
3746
[Fact]
3847
public async Task VolumesTest()
3948
{

src/testing/unit/Compute/v2_1/VolumeTests.cs

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -154,25 +154,25 @@ public void ListVolumes()
154154
}
155155
}
156156

157-
[Fact]
158-
public void ListVolumeTypes()
159-
{
160-
using (var httpTest = new HttpTest())
161-
{
162-
Identifier volumeTypeId = Guid.NewGuid();
163-
httpTest.RespondWithJson(new VolumeTypeCollection
164-
{
165-
new VolumeType {Id = volumeTypeId}
166-
});
167-
168-
var results = _compute.ListVolumeTypes();
169-
170-
httpTest.ShouldHaveCalled("*/os-volume-types");
171-
Assert.Equal(1, results.Count());
172-
var result = results.First();
173-
Assert.Equal(volumeTypeId, result.Id);
174-
}
175-
}
157+
//[Fact]
158+
//public void ListVolumeTypes()
159+
//{
160+
// using (var httpTest = new HttpTest())
161+
// {
162+
// Identifier volumeTypeId = Guid.NewGuid();
163+
// httpTest.RespondWithJson(new VolumeTypeCollection
164+
// {
165+
// new VolumeType {Id = volumeTypeId}
166+
// });
167+
168+
// var results = _compute.ListVolumeTypes();
169+
170+
// httpTest.ShouldHaveCalled("*/os-volume-types");
171+
// Assert.Equal(1, results.Count());
172+
// var result = results.First();
173+
// Assert.Equal(volumeTypeId, result.Id);
174+
// }
175+
//}
176176

177177
[Fact]
178178
public void ListVolumeSnapshots()

0 commit comments

Comments
 (0)