Skip to content

Commit 32911b8

Browse files
committed
Skip doc generation for vendor/serialization classes
1 parent 84952df commit 32911b8

10 files changed

Lines changed: 47 additions & 20 deletions

src/corelib/OpenStackNet.cs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,10 +266,16 @@ private void SetUserAgentHeader(HttpCall call)
266266
}
267267
}
268268

269-
/// <summary />
269+
/// <summary>
270+
/// Raised when creating the SDK configuration options class.
271+
/// <para>Intended for vendors to override.</para>
272+
/// </summary>
273+
/// <exclude />
270274
public class CreateEvent
271275
{
272-
/// <summary />
276+
/// <summary>
277+
/// An instance of the configuration class to use when configuring the SDK.
278+
/// </summary>
273279
public OpenStackNetConfigurationOptions Result = new OpenStackNetConfigurationOptions();
274280
}
275281
}

src/corelib/PageOptions.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,19 @@
33

44
namespace OpenStack
55
{
6-
/// <summary />
6+
/// <summary>
7+
/// Paging options when listing a resource that supports paging.
8+
/// </summary>
79
public class PageOptions : IQueryStringBuilder
810
{
9-
/// <summary />
11+
/// <summary>
12+
/// The number of resources to return per page.
13+
/// </summary>
1014
public int? PageSize { get; set; }
1115

12-
/// <summary />
16+
/// <summary>
17+
/// The identifier of the first resource to return on the page.
18+
/// </summary>
1319
public Identifier StartingAt { get; set; }
1420

1521
/// <summary />

src/corelib/Serialization/IHaveExtraData.cs

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,27 @@
33

44
namespace OpenStack.Serialization
55
{
6-
/// <summary />
6+
/// <summary>
7+
/// Identifies a resource as potentially containing more data than what is exposed via properties.
8+
/// </summary>
9+
/// <exclude />
710
public interface IHaveExtraData
811
{
9-
/// <summary />
12+
/// <summary>
13+
/// Contains any additional data returned from the cloud provider which has not already been mapped to a property.
14+
/// </summary>
1015
IDictionary<string, JToken> Data { get; set; }
1116
}
1217

13-
/// <summary />
18+
/// <summary>
19+
/// Provides convenience methods for working with custom resource properties.
20+
/// </summary>
21+
/// <exclude />
1422
public static class IHaveExtraDataExtensions
1523
{
16-
/// <summary />
24+
/// <summary>
25+
/// Get a custom resource property.
26+
/// </summary>
1727
public static T GetExtraData<T>(this IHaveExtraData dataContainer, string key)
1828
where T : class
1929
{
@@ -24,7 +34,9 @@ public static T GetExtraData<T>(this IHaveExtraData dataContainer, string key)
2434
return null;
2535
}
2636

27-
/// <summary />
37+
/// <summary>
38+
/// Sets a custom resource property.
39+
/// </summary>
2840
public static void SetExtraData(this IHaveExtraData dataContainer, string key, object value)
2941
{
3042
dataContainer.Data[key] = value != null ? JToken.FromObject(value) : JValue.CreateNull();

src/corelib/Serialization/IPageBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
namespace OpenStack.Serialization
77
{
8-
/// <summary />
8+
/// <exclude />
99
public interface IPageBuilder<TPage>
1010
{
1111
/// <summary>

src/corelib/Serialization/IPageLink.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace OpenStack.Serialization
22
{
3-
/// <summary />
3+
/// <exclude />
44
public interface IPageLink
55
{
66
/// <summary />

src/corelib/Serialization/IQueryStringBuilder.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace OpenStack.Serialization
44
{
5-
/// <summary />
5+
/// <exclude />
66
public interface IQueryStringBuilder
77
{
88
/// <summary />

src/corelib/Serialization/IServiceResource.cs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ namespace OpenStack.Serialization
1010
/// Resources which want to expose service operations directly (e.g. resource.Delete())
1111
/// should implement this interface and the service will use it to add a reference to itself.
1212
/// </summary>
13+
/// <exclude />
1314
public interface IServiceResource
1415
{
1516
/// <summary>
@@ -21,6 +22,7 @@ public interface IServiceResource
2122
/// <summary>
2223
/// Resources which are children of another resource.
2324
/// </summary>
25+
/// <exclude />
2426
public interface IChildResource : IServiceResource
2527
{
2628
/// <summary>
@@ -34,14 +36,14 @@ public interface IChildResource : IServiceResource
3436
void SetParent(string parentId);
3537
}
3638

37-
/// <summary />
39+
/// <exclude />
3840
public static class ServiceResourceExtensions
3941
{
4042
/// <summary />
4143
public static async Task<T> PropogateOwner<T>(this Task<T> task, object owner)
4244
where T : IServiceResource
4345
{
44-
T resource = await task;
46+
T resource = await task.ConfigureAwait(false);
4547
return PropogateOwner(resource, owner);
4648
}
4749

@@ -77,7 +79,7 @@ public static T PropogateOwner<T>(this T resource, object owner)
7779
public static async Task<T> PropogateOwnerToChildren<T>(this Task<T> task, object owner)
7880
where T : IEnumerable<IServiceResource>
7981
{
80-
T resources = await task;
82+
T resources = await task.ConfigureAwait(false);
8183
return resources.PropogateOwnerToChildren(owner);
8284
}
8385

@@ -109,7 +111,7 @@ public static T GetOwnerOrThrow<T>(this IServiceResource resource, [CallerMember
109111
public static async Task<T> SetParent<T>(this Task<T> task, string parentId)
110112
where T : IChildResource
111113
{
112-
var resource = await task;
114+
var resource = await task.ConfigureAwait(false);
113115
resource.SetParent(parentId);
114116
return resource;
115117
}
@@ -118,7 +120,7 @@ public static async Task<T> SetParent<T>(this Task<T> task, string parentId)
118120
public static async Task<T> SetParentOnChildren<T>(this Task<T> task, string parentId)
119121
where T : IEnumerable<IChildResource>
120122
{
121-
var resources = await task;
123+
var resources = await task.ConfigureAwait(false);
122124
return SetParentOnChildren(resources, parentId);
123125
}
124126

src/corelib/Serialization/PageLink.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace OpenStack.Serialization
66
{
7-
/// <summary />
7+
/// <exclude />
88
public class PageLink : IPageLink, IHaveExtraData
99
{
1010
/// <summary />

src/corelib/Serialization/ResourceStatus.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace OpenStack.Serialization
22
{
3-
/// <summary />
3+
/// <exclude />
44
public class ResourceStatus : StringEnumeration
55
{
66
/// <summary />

src/corelib/Serialization/StringEnumeration.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ namespace OpenStack.Serialization
1010
/// Using classes for enumerations allows us to use inheritance and enable API versions or other providers to share and extend "enums"
1111
/// <seealso href="https://lostechies.com/jimmybogard/2008/08/12/enumeration-classes/"/>
1212
/// </summary>
13+
/// <exclude />
1314
[JsonConverter(typeof(StringEnumerationConverter))]
1415
public abstract class StringEnumeration : IComparable
1516
{

0 commit comments

Comments
 (0)