Fix reference from child back to the parent

Author: carolynvs

src/corelib/Compute/v2_1/ImageMetadata.cs

@@ -32,27 +32,27 @@ protected internal void SetParent(ImageReference parent)
 
         void IChildResource.SetParent(string parentId)
         {
-            SetParent(new Image {Id = parentId});
+            SetParent(new ImageReference { Id = parentId});
         }
 
         void IChildResource.SetParent(object parent)
         {
-            SetParent((Image)parent);
+            SetParent((ImageReference)parent);
         }
 
         /// <summary />
-        protected void AssertImageIsSet([CallerMemberName]string callerName = "")
+        protected void AssertParentIsSet([CallerMemberName]string callerName = "")
         {
             if (Image != null)
                 return;
 
-            throw new InvalidOperationException(string.Format($"{callerName} can only be used on instances which were constructed by the ComputeServer. Use ComputeService.{callerName} instead."));
+            throw new InvalidOperationException(string.Format($"{callerName} can only be used on instances which were constructed by the ComputeService. Use ComputeService.{callerName} instead."));
         }
 
         /// <summary />
         public async Task CreateAsync(string key, string value, CancellationToken cancellationToken = default(CancellationToken))
         {
-            AssertImageIsSet();
+            AssertParentIsSet();
             var compute = this.GetOwnerOrThrow<ComputeApi>();
             await compute.CreateImagMetadataAsync(Image.Id, key, value, cancellationToken);
             this[key] = value;
@@ -61,7 +61,7 @@ protected void AssertImageIsSet([CallerMemberName]string callerName = "")
         /// <summary />
         public async Task UpdateAsync(bool overwrite = false, CancellationToken cancellationToken = default(CancellationToken))
         {
-            AssertImageIsSet();
+            AssertParentIsSet();
             var compute = this.GetOwnerOrThrow<ComputeApi>();
             var results = await compute.UpdateImageMetadataAsync<ImageMetadata>(Image.Id, this, overwrite, cancellationToken);
             Clear();
@@ -77,7 +77,7 @@ protected void AssertImageIsSet([CallerMemberName]string callerName = "")
             if (!ContainsKey(key))
                 return;
 
-            AssertImageIsSet();
+            AssertParentIsSet();
             var compute = this.GetOwnerOrThrow<ComputeApi>();
             await compute.DeleteImageMetadataAsync(Image.Id, key, cancellationToken);
             Remove(key);

src/corelib/Compute/v2_1/ServerVolumeReference.cs

@@ -31,7 +31,7 @@ protected internal void SetParent(ServerReference parent)
 
         void IChildResource.SetParent(object parent)
         {
-            SetParent((Server)parent);
+            SetParent((ServerReference)parent);
         }
 
         void IChildResource.SetParent(string parentId)
@@ -44,19 +44,19 @@ void IChildResource.SetParent(string parentId)
         IDictionary<string, JToken> IHaveExtraData.Data { get; set; } = new Dictionary<string, JToken>();
 
         /// <summary />
-        protected void AssertServerIsSet([CallerMemberName]string callerName = "")
+        protected void AssertParentIsSet([CallerMemberName]string callerName = "")
         {
             if (ServerRef != null)
                 return;
 
-            throw new InvalidOperationException(string.Format($"{callerName} can only be used on instances which were constructed by the ComputeServer. Use ComputeService.{callerName} instead."));
+            throw new InvalidOperationException(string.Format($"{callerName} can only be used on instances which were constructed by the ComputeService. Use ComputeService.{callerName} instead."));
         }
 
         /// <summary />
         /// <exception cref="InvalidOperationException">When this instance was not constructed by the <see cref="ComputeService"/>, as it is missing the appropriate internal state to execute service calls.</exception>
         public async Task<ServerVolume> GetServerVolumeAsync(CancellationToken cancellationToken = default(CancellationToken))
         {
-            AssertServerIsSet();
+            AssertParentIsSet();
 
             var compute = this.GetOwnerOrThrow<ComputeApi>();
             var result = await compute.GetServerVolumeAsync<ServerVolume>(ServerRef.Id, Id, cancellationToken);
@@ -68,7 +68,7 @@ protected void AssertServerIsSet([CallerMemberName]string callerName = "")
         /// <exception cref="InvalidOperationException">When this instance was not constructed by the <see cref="ComputeService"/>, as it is missing the appropriate internal state to execute service calls.</exception>
         public async Task DetachAsync(CancellationToken cancellationToken = default(CancellationToken))
         {
-            AssertServerIsSet(); 
+            AssertParentIsSet(); 
 
             var compute = this.GetOwnerOrThrow<ComputeApi>();
             await compute.DetachVolumeAsync(ServerRef.Id, Id, cancellationToken);