Remove os-volume-types endpoint, it never existed...

https://bugs.launchpad.net/openstack-api-site/+bug/1543169

Author: carolynvs

src/corelib/Compute/v2_1/ComputeService.cs

@@ -455,12 +455,6 @@ public ComputeService(IAuthenticationProvider authenticationProvider, string reg
             return _computeApi.GetVolumeAsync<Volume>(volumeId, cancellationToken);
         }
 
-        /// <inheritdoc cref="ComputeApi.GetVolumeTypeAsync{T}" />
-        public Task<VolumeType> GetVolumeTypeAsync(Identifier volumeTypeId, CancellationToken cancellationToken = default(CancellationToken))
-        {
-            return _computeApi.GetVolumeTypeAsync<VolumeType>(volumeTypeId, cancellationToken);
-        }
-
         /// <inheritdoc cref="ComputeApi.GetVolumeSnapshotAsync{T}" />
         public Task<VolumeSnapshot> GetVolumeSnapshotAsync(Identifier snapshotId, CancellationToken cancellationToken = default(CancellationToken))
         {
@@ -484,13 +478,7 @@ public ComputeService(IAuthenticationProvider authenticationProvider, string reg
         {
             return await _computeApi.ListVolumesAsync<VolumeCollection>(cancellationToken).ConfigureAwait(false);
         }
-
-        ///// <inheritdoc cref="ComputeApiBuilder.ListVolumeTypesAsync{T}" />
-        //public async Task<IEnumerable<VolumeType>> ListVolumeTypesAsync(CancellationToken cancellationToken = default(CancellationToken))
-        //{
-        //    return await _computeApi.ListVolumeTypesAsync<VolumeTypeCollection>(cancellationToken);
-        //}
-
+        
         /// <inheritdoc cref="ComputeApi.ListVolumeSnapshotsAsync{T}" />
         public async Task<IEnumerable<VolumeSnapshot>> ListVolumeSnapshotsAsync(CancellationToken cancellationToken = default(CancellationToken))
         {

src/corelib/Compute/v2_1/ComputeServiceExtensions.cs

@@ -433,12 +433,6 @@ public static Volume GetVolume(this ComputeService service, Identifier volumeId)
             return service.GetVolumeAsync(volumeId).ForceSynchronous();
         }
 
-        /// <inheritdoc cref="ComputeService.GetVolumeTypeAsync" />
-        public static VolumeType GetVolumeType(this ComputeService service, Identifier volumeTypeId)
-        {
-            return service.GetVolumeTypeAsync(volumeTypeId).ForceSynchronous();
-        }
-
         /// <inheritdoc cref="ComputeService.GetVolumeSnapshotAsync" />
         public static VolumeSnapshot GetVolumeSnapshot(this ComputeService service, Identifier snapshotId)
         {

src/corelib/Compute/v2_1/Serialization/ComputeApi.cs

@@ -1755,34 +1755,7 @@ protected ComputeApi(IServiceType serviceType, IAuthenticationProvider authentic
 
             return Endpoint.PrepareGetResourceRequest($"os-volumes/{volumeId}", cancellationToken);
         }
-
-        /// <summary>
-        /// Shows details for a volume type.
-        /// </summary>
-        /// <typeparam name="T">The return type.</typeparam>
-        /// <param name="volumeTypeId">The volume type identifier.</param>
-        /// <param name="cancellationToken">A cancellation token that can be used by other objects or threads to receive notice of cancellation.</param>
-        public virtual async Task<T> GetVolumeTypeAsync<T>(string volumeTypeId, CancellationToken cancellationToken = default(CancellationToken))
-        {
-            return await BuildGetVolumeTypeRequest(volumeTypeId, cancellationToken)
-                .SendAsync()
-                .ReceiveJson<T>().ConfigureAwait(false);
-        }
-
-        /// <summary>
-        /// Builds the <see cref="GetVolumeTypeAsync{T}"/> request.
-        /// </summary>
-        /// <param name="volumeTypeId">The volume type identifier.</param>
-        /// <param name="cancellationToken">A cancellation token that can be used by other objects or threads to receive notice of cancellation.</param>
-        /// <exception cref="System.ArgumentNullException">volumeTypeId</exception>
-        public virtual Task<PreparedRequest> BuildGetVolumeTypeRequest(string volumeTypeId, CancellationToken cancellationToken = default(CancellationToken))
-        {
-            if (volumeTypeId == null)
-                throw new ArgumentNullException("volumeTypeId");
-
-            return Endpoint.PrepareGetResourceRequest($"os-volume-types/{volumeTypeId}", cancellationToken);
-        }
-
+        
         /// <summary>
         /// Shows details for a volume snapshot.
         /// </summary>
@@ -1892,19 +1865,7 @@ protected ComputeApi(IServiceType serviceType, IAuthenticationProvider authentic
         {
             return Endpoint.PrepareGetResourceRequest("os-volumes", cancellationToken);
         }
-
-        //public virtual async Task<T> ListVolumeTypesAsync<T>(CancellationToken cancellationToken = default(CancellationToken))
-        //{
-        //    return await BuildListVolumeTypesRequest(cancellationToken)
-        //        .SendAsync()
-        //        .ReceiveJson<T>();
-        //}
-
-        //        //public virtual Task<PreparedRequest> BuildListVolumeTypesRequest(CancellationToken cancellationToken = default(CancellationToken))
-        //{
-        //    return Endpoint.PrepareGetResourceRequest("os-volume-types", cancellationToken);
-        //}
-
+        
         /// <summary>
         /// Lists volume snapshots.
         /// </summary>

src/corelib/Compute/v2_1/Serialization/VolumeTypeCollection.cs

@@ -127,7 +127,6 @@
     <Compile Include="Compute\v2_1\SecurityGroupExtensions.cs" />
     <Compile Include="Compute\v2_1\KeyPairExtensions.cs" />
     <Compile Include="Compute\v2_1\Serialization\VolumeSnapshotCollection.cs" />
-    <Compile Include="Compute\v2_1\Serialization\VolumeTypeCollection.cs" />
     <Compile Include="Compute\v2_1\Serialization\VolumeCollection.cs" />
     <Compile Include="Compute\v2_1\ServerSummary.cs" />
     <Compile Include="Compute\v2_1\VolumeSnapshotExtensions.cs" />
@@ -178,7 +177,6 @@
     <Compile Include="Compute\v2_1\ServerVolumeReference.cs" />
     <Compile Include="Compute\v2_1\VolumeSnapshot.cs" />
     <Compile Include="Compute\v2_1\VolumeSnapshotDefinition.cs" />
-    <Compile Include="Compute\v2_1\VolumeType.cs" />
     <Compile Include="Compute\v2_2\KeyPair.cs" />
     <Compile Include="Compute\v2_2\KeyPairDefinition.cs" />
     <Compile Include="Compute\v2_2\KeyPairType.cs" />

src/corelib/Compute/v2_1/VolumeType.cs

@@ -45,22 +45,6 @@ public void GetVolume()
             }
         }
 
-        [Fact]
-        public void GetVolumeType()
-        {
-            using (var httpTest = new HttpTest())
-            {
-                Identifier volumeTypeId = Guid.NewGuid();
-                httpTest.RespondWithJson(new VolumeType { Id = volumeTypeId });
-
-                var result = _compute.GetVolumeType(volumeTypeId);
-
-                httpTest.ShouldHaveCalled($"*/os-volume-types/{volumeTypeId}");
-                Assert.NotNull(result);
-                Assert.Equal(volumeTypeId, result.Id);
-            }
-        }
-
         [Fact]
         public void GetVolumeSnapshot()
         {