Skip to content

Commit aae4d3e

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "[neutron] Don't configure firewall_driver for core ML2 plugin"
2 parents 540ec94 + 30acfc6 commit aae4d3e

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

  • lib/neutron_plugins

‎lib/neutron_plugins/ml2‎

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -111,18 +111,7 @@ function neutron_plugin_configure_service {
111111
fi
112112
fi
113113
fi
114-
# REVISIT(rkukura): Setting firewall_driver here for
115-
# neutron.agent.securitygroups_rpc.is_firewall_enabled() which is
116-
# used in the server, in case no L2 agent is configured on the
117-
# server's node. If an L2 agent is configured, this will get
118-
# overridden with the correct driver. The ml2 plugin should
119-
# instead use its own config variable to indicate whether security
120-
# groups is enabled, and that will need to be set here instead.
121-
if [[ "$Q_USE_SECGROUP" == "True" ]]; then
122-
iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver neutron.agent.not.a.real.FirewallDriver
123-
else
124-
iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver neutron.agent.firewall.NoopFirewallDriver
125-
fi
114+
populate_ml2_config /$Q_PLUGIN_CONF_FILE securitygroup enable_security_group=$Q_USE_SECGROUP
126115

127116
populate_ml2_config /$Q_PLUGIN_CONF_FILE ml2 mechanism_drivers=$Q_ML2_PLUGIN_MECHANISM_DRIVERS
128117
if [[ "$Q_ML2_PLUGIN_MECHANISM_DRIVERS" == *"linuxbridge"* ]]; then

0 commit comments

Comments
 (0)