From ccfb4e2e9523d4c07c4cc688a7a3fd7dd2862df7 Mon Sep 17 00:00:00 2001 From: Itay Matza <85165801+imatza-rh@users.noreply.github.com> Date: Thu, 16 Jul 2026 12:06:47 +0300 Subject: [PATCH] shiftstack-qa: Require separate approver for PR merges Change require_self_approval from false to true so that PR authors cannot auto-approve their own PRs. A different member of openstack-approvers must explicitly /approve before Tide merges. This prevents PRs from being merged with only a single /lgtm when the author is also an approver. --- .../prow/02_config/shiftstack/shiftstack-qa/_pluginconfig.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core-services/prow/02_config/shiftstack/shiftstack-qa/_pluginconfig.yaml b/core-services/prow/02_config/shiftstack/shiftstack-qa/_pluginconfig.yaml index 6ab574b69a677..0f767f6b0adad 100644 --- a/core-services/prow/02_config/shiftstack/shiftstack-qa/_pluginconfig.yaml +++ b/core-services/prow/02_config/shiftstack/shiftstack-qa/_pluginconfig.yaml @@ -1,7 +1,7 @@ approve: - repos: - shiftstack/shiftstack-qa - require_self_approval: false + require_self_approval: true external_plugins: shiftstack/shiftstack-qa: - endpoint: http://refresh