OCPBUGS-86332: remove tests using base images older than 4.13

[sergiordlr]

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

- How to verify it

Tests using older images should not run in the automation

- Description for the changelog

Summary by CodeRabbit

• Tests
  • Updated exclusion labels for several scale-up and certificate-rotation tests to refine CI selection, excluding older bootimage versions and adjusting platform applicability for cloud image scaling and certificate rotation validation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@sergiordlr: This pull request references Jira Issue OCPBUGS-86332, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Remove the tests using base images older than 4.13.

Images older than 4.13 are not going to receive more fixes. Hence, we need to remove the tests using them.

- How to verify it

Tests using older images should not run in the automation

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

This PR adds an exclusion Ginkgo label to five tests so they are skipped starting in 4.22 for legacy boot images (4.1, 4.3, 4.12, 2.2.0 ignition nodes, and the MCS rotation case).

Changes

Boot Image Test Exclusion

Layer / File(s)	Summary
Add boot image test exclusion labels test/extended-priv/mco_scale.go, test/extended-priv/mco_security.go	Five test cases related to legacy boot images (Scaleup using 4.1, 4.3, 4.12 cloud images; Create new config resources with 2.2.0 ignition boot image nodes; and the PolarionID:80403 MCS cert rotation case) each receive an added Exclude:Starting in 4.22 we will no longer fix any bootimage related bugs from bootimages earlier than 4.13 Ginkgo label.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

lgtm

Suggested reviewers

• cheesesashimi
• pablintino

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	New Ginkgo tests make external HTTP requests to github.com (getRHCOSImagesInfo calls http.Get on raw.githubusercontent.com URLs), which will fail in IPv6-only disconnected environments.	Tests require external connectivity to github.com. Either modify to cache/mirror RHCOS data or add [Skipped:Disconnected] to test names if external access is unavoidable. Run IPv6 test job to verify compatibility.

✅ Passed checks (11 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding exclusion labels to tests using base images older than 4.13 to prevent them from running in CI, directly reflecting the file modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test names in the modified files use hardcoded, static strings without dynamic identifiers, interpolation, variables, or runtime-generated content. Test names are stable and deterministic.
Test Structure And Quality	✅ Passed	Tests use proper Ginkgo patterns: single responsibility, deferred cleanup for resources, appropriate timeouts (20m for nodes), meaningful assertion messages. PR only adds labels, not test logic.
Microshift Test Compatibility	✅ Passed	This PR only updates existing tests by adding exclusion labels; it does not add new Ginkgo e2e tests. The custom check specifically requires evaluation when "new" tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR modifies existing Ginkgo tests, not adding new ones. The check applies only to newly added tests, so it is not applicable here.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only modifies test files to add Ginkgo exclusion labels. No deployment manifests, operator code, controllers, or scheduling constraints are introduced.
Ote Binary Stdout Contract	✅ Passed	Changes only add Ginkgo labels within test declarations. No package-level stdout writes, main functions, or suite setup code. Labels in g.It() blocks don't affect OTE binary stdout.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

test/extended-priv/mco_security.go (1)

944-944: 💤 Low value

Consider consistent spacing in Exclude labels for readability.

This file uses mixed patterns for exclude labels: "Exclude:CategoryName" for category-style names (line 454) and "Exclude: descriptive sentence" for full sentences (lines 551, 638). The new label is a full sentence but uses the no-space pattern. For consistency with other descriptive exclude messages, consider "Exclude: Starting in 4.22..." (with space after colon).

Optional style consistency fix

-g.It("[PolarionID:80403][OTP] Validate MCS Certificate Rotation with 2.2.0 User-Data Secret [Disruptive]", g.Label("Platform:aws", "Exclude:Starting in 4.22 we will no longer fix any bootimage related bugs from bootimages earlier than 4.13"), func() {
+g.It("[PolarionID:80403][OTP] Validate MCS Certificate Rotation with 2.2.0 User-Data Secret [Disruptive]", g.Label("Platform:aws", "Exclude: Starting in 4.22 we will no longer fix any bootimage related bugs from bootimages earlier than 4.13"), func() {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/extended-priv/mco_security.go` at line 944, The Exclude label on the
g.It test invocation uses "Exclude:Starting in 4.22..." without a space after
the colon; update the label in the g.It(...) call so it matches the project's
descriptive exclude pattern by changing it to "Exclude: Starting in 4.22..."
(ensure the string inside the g.It(...) labels array is adjusted accordingly) so
spacing is consistent with other tests like the ones at lines referencing other
Exclude messages.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/extended-priv/mco_security.go`:
- Line 944: The Exclude label on the g.It test invocation uses "Exclude:Starting
in 4.22..." without a space after the colon; update the label in the g.It(...)
call so it matches the project's descriptive exclude pattern by changing it to
"Exclude: Starting in 4.22..." (ensure the string inside the g.It(...) labels
array is adjusted accordingly) so spacing is consistent with other tests like
the ones at lines referencing other Exclude messages.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e148bc7b-0464-47d5-ae97-88da5e7ba527

📥 Commits

Reviewing files that changed from the base of the PR and between 13d8044 and d7c369b.

📒 Files selected for processing (2)

• test/extended-priv/mco_scale.go
• test/extended-priv/mco_security.go

[sergiordlr]

/retest

Manually triggered executions

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-vsphere-mco-tp-longduration/2057494415009648640
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-machine-config-operator-release-4.23-periodics-e2e-aws-mco-fips-proxy-longduration/2057494449457467392

[isabella-janssen]

/lgtm
/jira refresh

[openshift-ci-robot]

@isabella-janssen: This pull request references Jira Issue OCPBUGS-86332, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/lgtm
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, sergiordlr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@sergiordlr: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.