Skip to content

OCPBUGS-83562: Bump kubensmnt dependency and service to v1.3.0#6051

Open
lack wants to merge 1 commit into
openshift:mainfrom
lack:OCPBUGS-83562_kubensmnt_precreate_netns
Open

OCPBUGS-83562: Bump kubensmnt dependency and service to v1.3.0#6051
lack wants to merge 1 commit into
openshift:mainfrom
lack:OCPBUGS-83562_kubensmnt_precreate_netns

Conversation

@lack
Copy link
Copy Markdown
Member

@lack lack commented May 15, 2026

- What I did

Updated the kubensmnt dependency to v1.3.0 to incorporate the upstream fix for OCPBUGS-83562

- How to verify it

Deploy, enable the 'kubens.service', and ensure that /run/netns/ is a mountpoint both in the default system namespace:

mountpoint /run/netns/

and the kubens namespace

kubensenter mountpoint /run/netns/

- Description for the changelog

Updated kubens.service to eliminate a race condition between CRI-O and external network tools running ip netns add

Fixes: OCPBUGS-83562

Summary by CodeRabbit

  • Bug Fixes

    • Resolved a race condition in network namespace initialization that could cause mount operation failures during service startup.
  • Chores

    • Updated dependencies to the latest stable version.

Signed-off-by: Jim Ramsay <jramsay@redhat.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 15, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This pull request references Jira Issue OCPBUGS-83562, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

Updated the kubensmnt dependency to v1.3.0 to incorporate the upstream fix for OCPBUGS-83562

- How to verify it

Deploy, enable the 'kubens.service', and ensure that /run/netns/ is a mountpoint both in the default system namespace:

mountpoint /run/netns/

and the kubens namespace

kubensenter mount | mountpoint /run/netns/

- Description for the changelog

Updated kubens.service to eliminate a race condition between CRI-O and external network tools running ip netns add

Fixes: OCPBUGS-83562

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

Walkthrough

This PR updates the kubensmnt module dependency from v1.2.0 to v1.3.0 and adds systemd unit initialization to ensure the /run/netns shared mount point exists, preventing setns errors and mount shadowing issues that occur with CRI-O-created mounts.

Changes

Netns shared mount point initialization

Layer / File(s) Summary
kubensmnt module upgrade and systemd ExecStartPost initialization
go.mod, templates/common/_base/units/kubens.service.yaml
The kubensmnt dependency is bumped to v1.3.0; an ExecStartPost step is added to kubens.service.yaml that initializes /run/netns as a shared mount point by creating and immediately deleting a temporary netns (kubensmnt), with a fallback mountpoint check to ensure the initialization succeeds.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main changes: bumping the kubensmnt dependency to v1.3.0 and updating the kubens.service to address a race condition.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@go.mod`:
- Line 16: The go.mod currently pins a non-existent module version
"github.com/containers/kubensmnt v1.3.0"; fix this by either removing that
require entry or replacing v1.3.0 with the correct release tag from the upstream
repo. Locate the "github.com/containers/kubensmnt" require line, verify the
correct tag on the upstream (or decide the dependency is unused), then run the
appropriate go tooling to apply the change (e.g., use `go get
github.com/containers/kubensmnt@<correct-tag>` or delete the require and run `go
mod tidy`) so the module version in go.mod is valid.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f54b8a72-91a0-4489-9f9d-137c8a2d3927

📥 Commits

Reviewing files that changed from the base of the PR and between 6c4403a and 9939548.

⛔ Files ignored due to path filters (7)
  • go.sum is excluded by !**/*.sum
  • vendor/github.com/containers/kubensmnt/utils/systemd/Makefile is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/containers/kubensmnt/utils/systemd/README.md is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/containers/kubensmnt/utils/systemd/embed.go is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/containers/kubensmnt/utils/systemd/kubens.service is excluded by !**/vendor/**, !vendor/**
  • vendor/github.com/containers/kubensmnt/utils/systemd/mkWrapperDropin is excluded by !**/vendor/**, !vendor/**
  • vendor/modules.txt is excluded by !**/vendor/**, !vendor/**
📒 Files selected for processing (2)
  • go.mod
  • templates/common/_base/units/kubens.service.yaml

Comment thread go.mod
@rphillips
Copy link
Copy Markdown
Contributor

/retest-required
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lack, rphillips
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. and removed jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This pull request references Jira Issue OCPBUGS-83562, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

- What I did

Updated the kubensmnt dependency to v1.3.0 to incorporate the upstream fix for OCPBUGS-83562

- How to verify it

Deploy, enable the 'kubens.service', and ensure that /run/netns/ is a mountpoint both in the default system namespace:

mountpoint /run/netns/

and the kubens namespace

kubensenter mountpoint /run/netns/

- Description for the changelog

Updated kubens.service to eliminate a race condition between CRI-O and external network tools running ip netns add

Fixes: OCPBUGS-83562

Summary by CodeRabbit

  • Bug Fixes

  • Resolved a race condition in network namespace initialization that could cause mount operation failures during service startup.

  • Chores

  • Updated dependencies to the latest stable version.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack
Copy link
Copy Markdown
Member Author

lack commented May 19, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 19, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@lack: This pull request references Jira Issue OCPBUGS-83562, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 19, 2026

@lack: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl-part1 9939548 link true /test e2e-gcp-op-ocl-part1

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants