OCPBUGS-83562: Bump kubensmnt dependency and service to v1.3.0#6051
OCPBUGS-83562: Bump kubensmnt dependency and service to v1.3.0#6051lack wants to merge 1 commit into
Conversation
Signed-off-by: Jim Ramsay <jramsay@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@lack: This pull request references Jira Issue OCPBUGS-83562, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThis PR updates the kubensmnt module dependency from v1.2.0 to v1.3.0 and adds systemd unit initialization to ensure the ChangesNetns shared mount point initialization
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 16: The go.mod currently pins a non-existent module version
"github.com/containers/kubensmnt v1.3.0"; fix this by either removing that
require entry or replacing v1.3.0 with the correct release tag from the upstream
repo. Locate the "github.com/containers/kubensmnt" require line, verify the
correct tag on the upstream (or decide the dependency is unused), then run the
appropriate go tooling to apply the change (e.g., use `go get
github.com/containers/kubensmnt@<correct-tag>` or delete the require and run `go
mod tidy`) so the module version in go.mod is valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f54b8a72-91a0-4489-9f9d-137c8a2d3927
⛔ Files ignored due to path filters (7)
go.sumis excluded by!**/*.sumvendor/github.com/containers/kubensmnt/utils/systemd/Makefileis excluded by!**/vendor/**,!vendor/**vendor/github.com/containers/kubensmnt/utils/systemd/README.mdis excluded by!**/vendor/**,!vendor/**vendor/github.com/containers/kubensmnt/utils/systemd/embed.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/containers/kubensmnt/utils/systemd/kubens.serviceis excluded by!**/vendor/**,!vendor/**vendor/github.com/containers/kubensmnt/utils/systemd/mkWrapperDropinis excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (2)
go.modtemplates/common/_base/units/kubens.service.yaml
|
/retest-required |
|
Scheduling tests matching the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lack, rphillips The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@lack: This pull request references Jira Issue OCPBUGS-83562, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@lack: This pull request references Jira Issue OCPBUGS-83562, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@lack: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- What I did
Updated the kubensmnt dependency to v1.3.0 to incorporate the upstream fix for OCPBUGS-83562
- How to verify it
Deploy, enable the 'kubens.service', and ensure that /run/netns/ is a mountpoint both in the default system namespace:
and the kubens namespace
- Description for the changelog
Updated kubens.service to eliminate a race condition between CRI-O and external network tools running
ip netns addFixes: OCPBUGS-83562
Summary by CodeRabbit
Bug Fixes
Chores