Skip to content

Friendlier error message than TypeError #26

@iaindillingham

Description

@iaindillingham

When neither --dsn is passed nor DATABASE_URL is set, SQL Runner prints a stack trace:

Running actions: query

jobrunner.run loop started
query: Copying in code from /Users/iaindillingham/Code/opensafely/tpp-database-schema
query: Preparing
query: Executing
query: Logs written to: /Users/iaindillingham/Code/opensafely/tpp-database-schema/metadata/query.log
query: Finalizing
query: Job exited with error code 1
query: Cleaning up container and volume

=> query
   Job exited with error code 1

   log file: metadata/query.log
   outputs:
     (no outputs)

   logs:

     Traceback (most recent call last):
       File "/usr/lib/python3.10/runpy.py", line 196, in _run_module_as_main
         return _run_code(code, main_globals, None,
       File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
         exec(code, run_globals)
       File "/app/sqlrunner/__main__.py", line 9, in <module>
         results = main.run_sql(dsn=args.dsn, sql_query=sql_query)
       File "/app/sqlrunner/main.py", line 51, in run_sql
         database=parsed_dsn.path.strip("/"),
     TypeError: a bytes-like object is required, not 'str'

parsed_dsn is an instance of ParseResultBytes rather than ParseResult because dsn was None:

parsed_dsn = parse.urlparse(dsn)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions