Revising AddSurefireFailsafeArgLineForMockito

[nmck257]

Hi, just noticed the current impl which adds --adds-opens flags to surefire execution.
38caf16#diff-9b48fea6f3aa733eafe641cece4c0679a04e5420d3ea7ac94c5a02ce32091497

I have a recipe in my environment that more-closely matches Mockito's advice:

• https://javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/Mockito.html#0.3

...by incorporating this config:

 <plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-dependency-plugin</artifactId>
     <executions>
         <execution>
             <goals>
                 <goal>properties</goal>
             </goals>
         </execution>
     </executions>
 </plugin>
 <plugin>
     <groupId>org.apache.maven.plugins</groupId>
     <artifactId>maven-surefire-plugin</artifactId>
     <configuration>
         <argLine>@{argLine} -javaagent:${org.mockito:mockito-core:jar}</argLine>
     </configuration>
 </plugin>

...but I was slow to contribute it upstream :)

I'd like to contribute that recipe and pivot the Java upgrade recipes to use that pattern instead.
Any concerns?

@timtebeek , @steve-aom-elliott

[timtebeek]

hi! That seems like a better alternative indeed; thanks for bringing it up and offering to contribute! Let me know if we can help in any way. Alternatively we can look to replicate the same outcome with a new recipe; just let us know what's your preference.