An issue has been created with the PR (#77)
The $skips array was removed (https://github.com/openclassify/advs-module/pull/77/files#diff-3f732e2090c80e126f0dcb1bb6137fa1df04ba74989d723b6654536ae0bd3aa2L12-L15) in favor of a setSkips function (https://github.com/openclassify/advs-module/pull/77/files#diff-3f732e2090c80e126f0dcb1bb6137fa1df04ba74989d723b6654536ae0bd3aa2R110-R115).
The issue with this change is that setSkips never gets called and causes the ads to not get created.
Should the $skips array get added back in or should the setSkips function get called somewhere?
I tested this on a fresh install and it causes the same error on ad creation. 'The "slug" field is required"
An issue has been created with the PR (#77)
The $skips array was removed (https://github.com/openclassify/advs-module/pull/77/files#diff-3f732e2090c80e126f0dcb1bb6137fa1df04ba74989d723b6654536ae0bd3aa2L12-L15) in favor of a
setSkipsfunction (https://github.com/openclassify/advs-module/pull/77/files#diff-3f732e2090c80e126f0dcb1bb6137fa1df04ba74989d723b6654536ae0bd3aa2R110-R115).The issue with this change is that
setSkipsnever gets called and causes the ads to not get created.Should the
$skipsarray get added back in or should thesetSkipsfunction get called somewhere?I tested this on a fresh install and it causes the same error on ad creation. 'The "slug" field is required"