Skip to content

Remove packaging as a runtime dependency of opentelemetry-instrumentation-pika #4886

Description

@ocelotl

Remove packaging as a runtime dependency of opentelemetry-instrumentation-pika

Summary

opentelemetry-instrumentation-pika declares packaging >= 20.0 as a runtime
dependency, used solely to compare the installed pika version.

Motivation: the auto-instrumentation injector

The auto-instrumentation injector (the Python auto-instrumentation shipped by the
OpenTelemetry Operator) bundles the instrumentation packages and all of their
runtime dependencies
into an init container and prepends that directory to the
target application's PYTHONPATH. Every runtime dependency is therefore injected
into the user's application process, where a common library like packaging
risks version shadowing/conflicts and adds to the injected payload. Removing it
shrinks that footprint. See #4882 for the full rationale.

Where it is used

  • pyproject.toml: packaging >= 20.0 in dependencies.
  • src/opentelemetry/instrumentation/pika/pika_instrumentor.py:34:
    version.parse(pika.__version__) compared against 1.0.0 to select the
    correct instrumentation hook.

Purpose: spec-compliant PEP 440 ordering of pika.__version__ to branch
behavior by installed pika version.

Proposed resolution

Import the PEP 440 Version from the internal implementation added in #4882
(opentelemetry.instrumentation._packaging.version) instead of packaging, and
remove packaging from this package's dependencies.

Depends on #4882, which introduces opentelemetry.instrumentation._packaging
in opentelemetry-instrumentation (a dependency of this package).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions