Skip to content

Commit 97de0f4

Browse files
committed
Merge branch 'dev' into sofia
2 parents 9c87bb3 + c68dafa commit 97de0f4

3 files changed

Lines changed: 31 additions & 48 deletions

File tree

app/containers/GraphsContainer/GraphsContainer.tsx

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ interface Params {
3333
const GraphsContainer: React.FC = React.memo(() => {
3434

3535
const { app, service } = useParams<keyof Params>() as Params;
36-
// console.log({app,service})
3736
const [ live, setLive ] = useState<boolean>(false);
3837
const { intervalID, setIntervalID } = useContext(ApplicationContext);
3938
const { getSavedMetrics } = useContext(ApplicationContext);
@@ -48,7 +47,6 @@ const GraphsContainer: React.FC = React.memo(() => {
4847
let [inspect, setInspect] = useState<boolean>(false);
4948

5049
useEffect(() => {
51-
// console.log({service})
5250
const serviceArray = service.split(' ');
5351
// You would think you should add "kubernetesmetrics" into the below for consistency's sake but it makes it not work correctly, so it has been omitted
5452
const healthServiceArray = serviceArray.filter(
@@ -71,16 +69,15 @@ const GraphsContainer: React.FC = React.memo(() => {
7169
);
7270
} else {
7371
if (intervalID) clearInterval(intervalID);
74-
//this function fetches all the server data from our database
7572
fetchCommsData(app, live);
7673
fetchHealthData(healthServiceArray);
77-
// if (service.includes('kafkametrics')) {
78-
// fetchEventData('kafkametrics');
79-
// }
80-
// // JJ-ADDITION
81-
// if (service.includes('kubernetesmetrics')) {
82-
// fetchEventData('kubernetesmetrics');
83-
// }
74+
if (service.includes('kafkametrics')) {
75+
fetchEventData('kafkametrics');
76+
}
77+
// JJ-ADDITION
78+
if (service.includes('kubernetesmetrics')) {
79+
fetchEventData('kubernetesmetrics');
80+
}
8481
getSavedMetrics();
8582
}
8683

app/modals/ServicesModal/ServicesLink.tsx

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -20,24 +20,24 @@ const ServicesLink = (props) => {
2020
return (
2121

2222
<div className="services-links">
23-
{props.servicesData.map((service: IService, index: number) => (
24-
<div
25-
key={`${index}servicesData`}
26-
className={props.services.includes(service.microservice) ? 'link selected' : 'link'}
27-
onClick={() => toggleService(service.microservice)}
28-
>
29-
{service.microservice}
30-
</div>
31-
))}
32-
<Link id='selectLink'
33-
className="router link"
34-
to={props.services.length > 0 ? `/applications/${props.app}/${props.services.join(' ')}` : '#'}
35-
>
36-
{props.services.length === 0 && 'Select Services'}
37-
{props.services.length === 1 && 'Display Service'}
38-
{props.services.length > 1 && 'Compare Services'}
39-
</Link>
40-
</div>
23+
{props.servicesData.map((service: IService, index: number) => (
24+
<div
25+
key={`${index}servicesData`}
26+
className={props.services.includes(service.microservice) ? 'link selected' : 'link'}
27+
onClick={() => toggleService(service.microservice)}
28+
>
29+
{service.microservice}
30+
</div>
31+
))}
32+
<Link id='selectLink'
33+
className="router link"
34+
to={props.services.length > 0 ? `/applications/${props.app}/${props.services.join(' ')}` : '#'}
35+
>
36+
{props.services.length === 0 && 'Select Services'}
37+
{props.services.length === 1 && 'Display Service'}
38+
{props.services.length > 1 && 'Compare Services'}
39+
</Link>
40+
</div>
4141
)
4242
}
4343

app/modals/ServicesModal/ServicesModal.tsx

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -53,26 +53,12 @@ const ServicesModal: React.FC<ServicesModalProps> = React.memo(({ i, app }) => {
5353
<h2>{app}</h2>
5454
<p>Select a server to monitor</p>
5555
</div>
56-
<ServicesLink servicesData={servicesData} services={services} setServices={setServices}/>
57-
{/* <div className="services-links">
58-
{servicesData.map((service: IService, index: number) => (
59-
<div
60-
key={`${index}servicesData`}
61-
className={services.includes(service.microservice) ? 'link selected' : 'link'}
62-
onClick={() => toggleService(service.microservice)}
63-
>
64-
{service.microservice}
65-
</div>
66-
))}
67-
<Link id='selectLink'
68-
className="router link"
69-
to={services.length > 0 ? `/applications/${app}/${services.join(' ')}` : '#'}
70-
>
71-
{services.length === 0 && 'Select Services'}
72-
{services.length === 1 && 'Display Service'}
73-
{services.length > 1 && 'Compare Services'}
74-
</Link>
75-
</div> */}
56+
<ServicesLink
57+
app={app}
58+
servicesData={servicesData}
59+
services={services}
60+
setServices={setServices}
61+
/>
7662
</>
7763
)}
7864
</div>

0 commit comments

Comments
 (0)