Skip to content

Commit e2e1474

Browse files
Fix filters impact analysis (#24877)
* fix(ui): impact analysis filter and sorting * support sorting and highlight to column level * fix dropdown issue * add debounce to search value * add coverage * fix tests * fix tests * update tests * fix sonar comment * Address PR review comments: fix useMemo dependencies and remove deprecated properties (#24981) * Initial plan * Address review comments: fix useMemo deps, remove deprecated props, fix test mocks Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: chirag-madlani <12962843+chirag-madlani@users.noreply.github.com> * fix pagination logic --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
1 parent c679793 commit e2e1474

16 files changed

Lines changed: 1006 additions & 217 deletions

File tree

openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/CustomControls.component.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,10 @@ import { ReactComponent as FilterLinesIcon } from '../../../assets/svg/ic-filter
3333
import { ReactComponent as FullscreenIcon } from '../../../assets/svg/ic-fullscreen.svg';
3434
import { ReactComponent as SettingsOutlined } from '../../../assets/svg/ic-settings-gear.svg';
3535
import { LINEAGE_DROPDOWN_ITEMS } from '../../../constants/AdvancedSearch.constants';
36-
import { FULLSCREEN_QUERY_PARAM_KEY } from '../../../constants/constants';
36+
import {
37+
AGGREGATE_PAGE_SIZE_LARGE,
38+
FULLSCREEN_QUERY_PARAM_KEY,
39+
} from '../../../constants/constants';
3740
import { ExportTypes } from '../../../constants/Export.constants';
3841
import { SERVICE_TYPES } from '../../../constants/Services.constant';
3942
import { useLineageProvider } from '../../../context/LineageProvider/LineageProvider';
@@ -328,7 +331,7 @@ const CustomControls: FC<{
328331
type: t('label.asset-or-column'),
329332
})}
330333
searchValue={searchValue}
331-
typingInterval={0}
334+
typingInterval={300}
332335
onSearch={onSearchValueChange}
333336
/>
334337
) : (
@@ -511,6 +514,7 @@ const CustomControls: FC<{
511514
defaultQueryFilter={queryFilter}
512515
fields={selectedQuickFilters}
513516
index={SearchIndex.ALL}
517+
optionPageSize={AGGREGATE_PAGE_SIZE_LARGE}
514518
showDeleted={false}
515519
onFieldValueSelect={handleQuickFiltersValueSelect}
516520
/>

openmetadata-ui/src/main/resources/ui/src/components/Explore/ExploreQuickFilters.interface.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,5 @@ export interface ExploreQuickFiltersProps {
2828
fieldsWithNullValues?: EntityFields[];
2929
defaultQueryFilter?: Record<string, unknown>;
3030
showSelectedCounts?: boolean; // flag to show counts instead of labels for selected filters
31+
optionPageSize?: number;
3132
}

0 commit comments

Comments
 (0)