Skip to content

Commit e0f04a6

Browse files
chirag-madlanichirag-madlani
authored
chore(ui): handle description render common with util (#24792)
* chore(ui): handle description render common with util * fix lint error * fix unit tests * fix unit tests * add license to new file * fix unit tests * address copilot comments and if metric spec failure * fix unit tests * fix flaky domain spec failure * fix domain spec issue * remove afterAll block as not required
1 parent 68db5a3 commit e0f04a6

84 files changed

Lines changed: 3164 additions & 773 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎openmetadata-ui/src/main/resources/ui/playwright/docs/Governance.md‎

Lines changed: 21 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Governance
44

5-
> **6 Components** | **26 Files** | **503 Tests** | **933 Scenarios** 🚀
5+
> **6 Components** | **27 Files** | **509 Tests** | **939 Scenarios** 🚀
66
77
## Table of Contents
88
- [Custom Properties](#custom-properties)
@@ -798,7 +798,7 @@
798798
## Tags
799799

800800
<details open>
801-
<summary>📄 <b>Tag.spec.ts</b> (18 tests, 22 scenarios)</summary>
801+
<summary>📄 <b>Tag.spec.ts</b> (21 tests, 25 scenarios)</summary>
802802

803803
> Source: [`src/main/resources/ui/playwright/e2e/Pages/Tag.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tag.spec.ts)
804804
@@ -817,6 +817,8 @@
817817
| | ↳ *Delete Asset* | |
818818
| 8 | **Tag Page with Admin Roles** - Create tag with domain | Create tag with domain |
819819
| 9 | **Tag Page with Admin Roles** - Verify Owner Add Delete | Owner Add Delete |
820+
| 10 | **Tag Page with Admin Roles** - Verify tag enable/disable toggle | Tag enable/disable toggle |
821+
| 11 | **Tag Page with Admin Roles** - Tag toggle should be disabled when classification is disabled | Tag toggle should be disabled when classification is disabled |
820822

821823
### Tag Page with Data Consumer Roles
822824

@@ -828,6 +830,7 @@
828830
| 4 | **Tag Page with Data Consumer Roles** - Add and Remove Assets for Data Consumer | Add and Remove Assets for Data Consumer |
829831
| | ↳ *Add Asset * | |
830832
| | ↳ *Delete Asset* | |
833+
| 5 | **Tag Page with Data Consumer Roles** - Tag toggle should be disabled for user without EditAll permission | Tag toggle should be disabled for user without EditAll permission |
831834

832835
### Tag Page with Data Steward Roles
833836

@@ -851,7 +854,7 @@
851854
</details>
852855

853856
<details open>
854-
<summary>📄 <b>Tags.spec.ts</b> (4 tests, 12 scenarios)</summary>
857+
<summary>📄 <b>Tags.spec.ts</b> (5 tests, 13 scenarios)</summary>
855858

856859
> Source: [`src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Tags.spec.ts)
857860
@@ -872,6 +875,7 @@
872875
| 2 | Search tag using classification display name should work | Search tag using classification display name should work |
873876
| 3 | Verify system classification term counts | System classification term counts |
874877
| 4 | Verify Owner Add Delete | Owner Add Delete |
878+
| 5 | Disabled tag should not allow adding assets from Assets tab | Disabled tag should not allow adding assets from Assets tab |
875879

876880
</details>
877881

@@ -894,6 +898,20 @@
894898

895899
</details>
896900

901+
<details open>
902+
<summary>📄 <b>SystemCertificationTags.spec.ts</b> (2 tests, 2 scenarios)</summary>
903+
904+
> Source: [`src/main/resources/ui/playwright/e2e/Features/SystemCertificationTags.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/SystemCertificationTags.spec.ts)
905+
906+
### System Level Certification Tags
907+
908+
| # | Test Case | Description |
909+
|---|-----------|-------------|
910+
| 1 | **System Level Certification Tags** - should NOT show disabled system certification tag in dropdown | NOT show disabled system certification tag in dropdown |
911+
| 2 | **System Level Certification Tags** - should NOT show any system certification tags when classification is disabled | NOT show any system certification tags when classification is disabled |
912+
913+
</details>
914+
897915
<details open>
898916
<summary>📄 <b>MutuallyExclusiveColumnTags.spec.ts</b> (1 tests, 1 scenarios)</summary>
899917

‎openmetadata-ui/src/main/resources/ui/playwright/docs/Integration.md‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Integration
44

5-
> **1 Components** | **5 Files** | **56 Tests** | **59 Scenarios** 🚀
5+
> **1 Components** | **5 Files** | **52 Tests** | **55 Scenarios** 🚀
66
77
## Table of Contents
88
- [Connectors](#connectors)
@@ -14,7 +14,7 @@
1414
## Connectors
1515

1616
<details open>
17-
<summary>📄 <b>ServiceIngestion.spec.ts</b> (49 tests, 49 scenarios)</summary>
17+
<summary>📄 <b>ServiceIngestion.spec.ts</b> (45 tests, 45 scenarios)</summary>
1818

1919
> Source: [`src/main/resources/ui/playwright/e2e/nightly/ServiceIngestion.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/nightly/ServiceIngestion.spec.ts)
2020
@@ -111,15 +111,6 @@
111111
| 4 | **Redshift Service** - Service specific tests | Tests database-specific ingestion behaviors Runs additional checks for Postgres, Redshift, and MySQL services |
112112
| 5 | **Redshift Service** - Delete Redshift Service service | Tests service deletion flow Deletes the service and validates removal |
113113

114-
### Airflow Service
115-
116-
| # | Test Case | Description |
117-
|---|-----------|-------------|
118-
| 1 | **Airflow Service** - Create & Ingest Airflow Service service | Tests service creation and first ingestion run Creates the service and triggers ingestion |
119-
| 2 | **Airflow Service** - Update description and verify description after re-run | Tests description update persistence across reruns Updates service description and verifies it after rerun |
120-
| 3 | **Airflow Service** - Update schedule options and verify | Tests schedule option updates Updates ingestion schedule options and verifies they persist |
121-
| 4 | **Airflow Service** - Delete Airflow Service service | Tests service deletion flow Deletes the service and validates removal |
122-
123114
### Service form
124115

125116
| # | Test Case | Description |

‎openmetadata-ui/src/main/resources/ui/playwright/docs/Platform.md‎

Lines changed: 43 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
# Platform
44

5-
> **12 Components** | **68 Files** | **1238 Tests** | **1615 Scenarios** 🚀
5+
> **12 Components** | **69 Files** | **1242 Tests** | **1618 Scenarios** 🚀
66
77
## Table of Contents
88
- [Other](#other)
@@ -59,7 +59,7 @@
5959
</details>
6060

6161
<details open>
62-
<summary>📄 <b>AutoPilot.spec.ts</b> (12 tests, 12 scenarios)</summary>
62+
<summary>📄 <b>AutoPilot.spec.ts</b> (10 tests, 10 scenarios)</summary>
6363

6464
> Source: [`src/main/resources/ui/playwright/e2e/Features/AutoPilot.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AutoPilot.spec.ts)
6565
@@ -98,13 +98,6 @@
9898
| 1 | **Mlflow** - Create Service and check the AutoPilot status | Create Service and check the AutoPilot status |
9999
| 2 | **Mlflow** - Agents created by AutoPilot should be deleted | Agents created by AutoPilot should be deleted |
100100

101-
### Airflow
102-
103-
| # | Test Case | Description |
104-
|---|-----------|-------------|
105-
| 1 | **Airflow** - Create Service and check the AutoPilot status | Create Service and check the AutoPilot status |
106-
| 2 | **Airflow** - Agents created by AutoPilot should be deleted | Agents created by AutoPilot should be deleted |
107-
108101
</details>
109102

110103
<details open>
@@ -126,6 +119,24 @@
126119

127120
</details>
128121

122+
<details open>
123+
<summary>📄 <b>CertificationDropdown.spec.ts</b> (6 tests, 6 scenarios)</summary>
124+
125+
> Source: [`src/main/resources/ui/playwright/e2e/Features/CertificationDropdown.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/CertificationDropdown.spec.ts)
126+
127+
### Certification Dropdown
128+
129+
| # | Test Case | Description |
130+
|---|-----------|-------------|
131+
| 1 | **Certification Dropdown** - should show enabled certification tag in dropdown | Show enabled certification tag in dropdown |
132+
| 2 | **Certification Dropdown** - should NOT show disabled certification tag in dropdown | NOT show disabled certification tag in dropdown |
133+
| 3 | **Certification Dropdown** - should NOT show certifications when classification is disabled | NOT show certifications when classification is disabled |
134+
| 4 | **Certification Dropdown** - should show certification after re-enabling disabled tag | Show certification after re-enabling disabled tag |
135+
| 5 | **Certification Dropdown** - should show certifications after re-enabling classification | Show certifications after re-enabling classification |
136+
| 6 | **Certification Dropdown** - should handle multiple disabled tags correctly | Handle multiple disabled tags correctly |
137+
138+
</details>
139+
129140
<details open>
130141
<summary>📄 <b>DescriptionSuggestion.spec.ts</b> (5 tests, 9 scenarios)</summary>
131142

@@ -2148,22 +2159,6 @@
21482159

21492160
</details>
21502161

2151-
<details open>
2152-
<summary>📄 <b>DataInsightSettings.spec.ts</b> (4 tests, 4 scenarios)</summary>
2153-
2154-
> Source: [`src/main/resources/ui/playwright/e2e/Pages/DataInsightSettings.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataInsightSettings.spec.ts)
2155-
2156-
### Data Insight settings page should work properly
2157-
2158-
| # | Test Case | Description |
2159-
|---|-----------|-------------|
2160-
| 1 | **Data Insight settings page should work properly** - Edit data insight application | Edit data insight application |
2161-
| 2 | **Data Insight settings page should work properly** - Uninstall application | Uninstall application |
2162-
| 3 | **Data Insight settings page should work properly** - Install application | Install application |
2163-
| 4 | **Data Insight settings page should work properly** - Run application | Run application |
2164-
2165-
</details>
2166-
21672162
<details open>
21682163
<summary>📄 <b>SearchSettings.spec.ts</b> (4 tests, 4 scenarios)</summary>
21692164

@@ -2185,6 +2180,21 @@
21852180

21862181
</details>
21872182

2183+
<details open>
2184+
<summary>📄 <b>DataInsightSettings.spec.ts</b> (3 tests, 3 scenarios)</summary>
2185+
2186+
> Source: [`src/main/resources/ui/playwright/e2e/Pages/DataInsightSettings.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataInsightSettings.spec.ts)
2187+
2188+
### Data Insight settings page should work properly
2189+
2190+
| # | Test Case | Description |
2191+
|---|-----------|-------------|
2192+
| 1 | **Data Insight settings page should work properly** - Edit data insight application | Edit data insight application |
2193+
| 2 | **Data Insight settings page should work properly** - Uninstall application | Uninstall application |
2194+
| 3 | **Data Insight settings page should work properly** - Install application | Install application |
2195+
2196+
</details>
2197+
21882198
<details open>
21892199
<summary>📄 <b>LineageSettings.spec.ts</b> (2 tests, 6 scenarios)</summary>
21902200

@@ -2588,7 +2598,7 @@
25882598
## Lineage (UI)
25892599

25902600
<details open>
2591-
<summary>📄 <b>Lineage.spec.ts</b> (20 tests, 73 scenarios)</summary>
2601+
<summary>📄 <b>Lineage.spec.ts</b> (22 tests, 77 scenarios)</summary>
25922602

25932603
> Source: [`src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Lineage.spec.ts)
25942604
@@ -2687,6 +2697,12 @@
26872697
| 13 | Verify function data in edge drawer | Function data in edge drawer |
26882698
| 14 | Verify table search with special characters as handled | Table search with special characters as handled |
26892699
| 15 | Verify cycle lineage should be handled properly | Cycle lineage should be handled properly |
2700+
| 16 | Verify column layer is applied on entering edit mode | Column layer is applied on entering edit mode |
2701+
| | ↳ *Verify column layer is inactive initially* | |
2702+
| | ↳ *Enter edit mode and verify column layer is active* | |
2703+
| 17 | Verify there is no traced nodes and columns on exiting edit mode | There is no traced nodes and columns on exiting edit mode |
2704+
| | ↳ *Verify node tracing is cleared on exiting edit mode* | |
2705+
| | ↳ *Verify column tracing is cleared on exiting edit mode* | |
26902706

26912707
</details>
26922708

@@ -2961,7 +2977,7 @@
29612977
</details>
29622978

29632979
<details open>
2964-
<summary>📄 <b>PersonaDeletionUserProfile.spec.ts</b> (2 tests, 8 scenarios)</summary>
2980+
<summary>📄 <b>PersonaDeletionUserProfile.spec.ts</b> (1 tests, 4 scenarios)</summary>
29652981

29662982
> Source: [`src/main/resources/ui/playwright/e2e/Flow/PersonaDeletionUserProfile.spec.ts`](https://github.com/open-metadata/OpenMetadata/blob/main/openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/PersonaDeletionUserProfile.spec.ts)
29672983
@@ -2974,11 +2990,6 @@
29742990
| | ↳ *Verify persona appears on user profile* | |
29752991
| | ↳ *Delete the persona* | |
29762992
| | ↳ *Verify user profile still loads after persona deletion* | |
2977-
| 2 | **User profile works after persona deletion** - User profile loads correctly after DEFAULT persona deletion | User profile loads correctly after DEFAULT persona deletion |
2978-
| | ↳ *Create default persona with user* | |
2979-
| | ↳ *Verify default persona appears on user profile* | |
2980-
| | ↳ *Delete the default persona* | |
2981-
| | ↳ *Verify user profile still loads after DEFAULT persona deletion* | |
29822993

29832994
</details>
29842995

‎openmetadata-ui/src/main/resources/ui/playwright/docs/README.md‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,39 +7,39 @@
77
| Metric | Count |
88
|--------|-------|
99
| **Components** | 30 |
10-
| **Test Files** | 137 |
11-
| **Test Cases** | 2191 |
12-
| **Total Scenarios** | 3088 🚀 |
10+
| **Test Files** | 139 |
11+
| **Test Cases** | 2197 |
12+
| **Total Scenarios** | 3093 🚀 |
1313

1414
---
1515

1616
## Governance
1717

18-
> **6 Components** | **503 Tests** | **933 Scenarios**
18+
> **6 Components** | **509 Tests** | **939 Scenarios**
1919
2020
| Component | Files | Tests | Total Scenarios | Skipped |
2121
|-----------|-------|-------|-----------------|---------|
2222
| [Custom Properties](./Governance.md#custom-properties) | 5 | 293 | 304 | 0 |
2323
| [Data Contracts](./Governance.md#data-contracts) | 2 | 86 | 429 | 0 |
2424
| [Glossary](./Governance.md#glossary) | 6 | 52 | 84 | 0 |
2525
| [Domains & Data Products](./Governance.md#domains-data-products) | 4 | 35 | 57 | 0 |
26-
| [Tags](./Governance.md#tags) | 6 | 28 | 43 | 0 |
26+
| [Tags](./Governance.md#tags) | 7 | 34 | 49 | 0 |
2727
| [Metrics](./Governance.md#metrics) | 3 | 9 | 16 | 0 |
2828

2929
## Platform
3030

31-
> **12 Components** | **1238 Tests** | **1615 Scenarios**
31+
> **12 Components** | **1242 Tests** | **1618 Scenarios**
3232
3333
| Component | Files | Tests | Total Scenarios | Skipped |
3434
|-----------|-------|-------|-----------------|---------|
3535
| [Entities](./Platform.md#entities) | 15 | 926 | 1093 | 0 |
36-
| [Users & Teams](./Platform.md#users-teams) | 9 | 81 | 104 | 0 |
37-
| [Other](./Platform.md#other) | 17 | 60 | 71 | 0 |
36+
| [Users & Teams](./Platform.md#users-teams) | 9 | 80 | 100 | 0 |
37+
| [Other](./Platform.md#other) | 18 | 64 | 75 | 0 |
3838
| [Personas & Customizations](./Platform.md#personas-customizations) | 5 | 44 | 142 | 0 |
3939
| [Navigation](./Platform.md#navigation) | 4 | 38 | 38 | 0 |
40-
| [Lineage (UI)](./Platform.md#lineage-ui-) | 3 | 30 | 83 | 0 |
40+
| [Lineage (UI)](./Platform.md#lineage-ui-) | 3 | 32 | 87 | 0 |
4141
| [RBAC](./Platform.md#rbac) | 4 | 19 | 34 | 0 |
42-
| [Settings](./Platform.md#settings) | 5 | 15 | 19 | 0 |
42+
| [Settings](./Platform.md#settings) | 5 | 14 | 18 | 0 |
4343
| [SSO](./Platform.md#sso) | 1 | 10 | 10 | 0 |
4444
| [Authentication](./Platform.md#authentication) | 2 | 7 | 7 | 0 |
4545
| [App Marketplace](./Platform.md#app-marketplace) | 2 | 5 | 11 | 0 |
@@ -72,11 +72,11 @@
7272

7373
## Integration
7474

75-
> **1 Components** | **56 Tests** | **59 Scenarios**
75+
> **1 Components** | **52 Tests** | **55 Scenarios**
7676
7777
| Component | Files | Tests | Total Scenarios | Skipped |
7878
|-----------|-------|-------|-----------------|---------|
79-
| [Connectors](./Integration.md#connectors) | 5 | 56 | 59 | 0 |
79+
| [Connectors](./Integration.md#connectors) | 5 | 52 | 55 | 0 |
8080

8181

82-
*Last updated: 2025-12-17*
82+
*Last updated: 2025-12-18*

‎openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
* See the License for the specific language governing permissions and
1111
* limitations under the License.
1212
*/
13-
import { Page, test as base, expect } from '@playwright/test';
13+
import { expect, Page, test as base } from '@playwright/test';
1414
import { EntityDataClass } from '../../support/entity/EntityDataClass';
1515
import { TableClass } from '../../support/entity/TableClass';
1616
import { PersonaClass } from '../../support/persona/PersonaClass';
@@ -498,6 +498,7 @@ test.describe('Mention notifications in Notification Box', () => {
498498
await user1Page.keyboard.press('@');
499499
const userSuggestionsResponse = user1Page.waitForResponse((response) => {
500500
const url = response.url();
501+
501502
return (
502503
url.includes('/api/v1/search/query') &&
503504
url.includes(adminUser.responseData.displayName)

‎openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/SystemCertificationTags.spec.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,4 +108,3 @@ test.describe.serial('System Level Certification Tags', () => {
108108
}
109109
});
110110
});
111-

‎openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/RightEntityPanelFlow.spec.ts‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -526,9 +526,11 @@ test.describe('Right Entity Panel - Admin User Flow', () => {
526526
const summaryPanel = adminPage.locator('.entity-summary-panel-container');
527527

528528
// First verify the Overview tab shows lineage counts in LineageSection
529-
await summaryPanel.getByRole('menuitem', {
530-
name: /overview/i,
531-
}).click();
529+
await summaryPanel
530+
.getByRole('menuitem', {
531+
name: /overview/i,
532+
})
533+
.click();
532534

533535
await adminPage.waitForSelector('[data-testid="loader"]', {
534536
state: 'detached',
@@ -562,6 +564,7 @@ test.describe('Right Entity Panel - Admin User Flow', () => {
562564

563565
// Verify navigation to lineage route
564566
await adminPage.waitForURL(/.*\/lineage$/);
567+
565568
expect(adminPage.url()).toContain('/lineage');
566569

567570
// Navigate back to explore and reopen the entity panel

‎openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Domains.spec.ts‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -753,11 +753,20 @@ test.describe('Domains', () => {
753753

754754
const descriptionInputBox = '.om-block-editor[contenteditable="true"]';
755755

756+
// clear existing description to avoid flakiness
757+
await userPage.fill(descriptionInputBox, '');
758+
756759
await userPage.fill(descriptionInputBox, 'test description');
757760

761+
const saveResponse = userPage.waitForResponse(
762+
(req) =>
763+
req.request().method() === 'PATCH' &&
764+
req.request().url().includes('/api/v1/domains/')
765+
);
766+
758767
await userPage.getByTestId('save').click();
759768

760-
await userPage.waitForTimeout(3000);
769+
await saveResponse;
761770

762771
const descriptionBox = '.om-block-editor[contenteditable="false"]';
763772

0 commit comments

Comments
 (0)