test(glossary): make selectActiveGlossary selector robust (#27566)

* test(glossary): make selectActiveGlossary selector robust

Scope the menuitem lookup to [data-testid="glossary-left-panel"] and
require an exact name match so the helper can no longer pick up an
element from another dropdown (e.g. the Add-button glossary picker) or
silently mis-click via .first() when many glossaries share the "PW % "
prefix. The label argument is documented as the rendered label
(displayName ?? name).

Update createGlossaryTerms and the six Glossary.spec.ts callers that
were passing glossary.data.name (which never matches the rendered
displayName) to pass the displayName instead. This is the underlying
cause of the flakiness in "Approve and reject glossary term from
Glossary Listing".

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(glossary): fill displayName in createGlossary so UI-created glossaries match strict sidebar lookup

The previous commit made selectActiveGlossary match the sidebar
menuitem by displayName with exact: true. That assumed every glossary
in a test had its displayName rendered in the sidebar. UI-created
glossaries (via the createGlossary helper) only filled the name field,
so the server had no displayName and the sidebar rendered the raw
name — the exact-match lookup then hung until the 180s test timeout.

Fill the display-name field in createGlossary, and look up the
menuitem in verifyGlossaryDetails by displayName as well. This aligns
UI-created glossaries with API-created ones and unblocks the three
tests that were failing on this PR:
  - Glossary & terms creation for reviewer as user
  - Glossary & terms creation for reviewer as team
  - Approve and reject glossary term from Glossary Listing

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Siddhant <siddhant@MacBook-Pro-621.local>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 3 people

openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts

@@ -153,7 +153,7 @@ test.describe('Glossary tests', () => {
     await test.step('Approve Glossary Term from Glossary Listing for reviewer user', async () => {
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary1.data.name);
+      await selectActiveGlossary(page1, glossary1.data.displayName);
       await verifyTaskCreated(
         page1,
         glossary1.data.fullyQualifiedName,
@@ -179,7 +179,7 @@ test.describe('Glossary tests', () => {
       await approveGlossaryTermTask(page1, glossary1.data.terms[0].data);
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary1.data.name);
+      await selectActiveGlossary(page1, glossary1.data.displayName);
       await validateGlossaryTerm(
         page1,
         glossary1.data.terms[0].data,
@@ -222,7 +222,7 @@ test.describe('Glossary tests', () => {
     await test.step('Approve Glossary Term from Glossary Listing for reviewer team', async () => {
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary2.data.name);
+      await selectActiveGlossary(page1, glossary2.data.displayName);
 
       await verifyTaskCreated(
         page1,
@@ -234,7 +234,7 @@ test.describe('Glossary tests', () => {
 
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary2.data.name);
+      await selectActiveGlossary(page1, glossary2.data.displayName);
       await validateGlossaryTerm(
         page1,
         glossary2.data.terms[0].data,
@@ -441,7 +441,7 @@ test.describe('Glossary tests', () => {
     await test.step('Approve and Reject Glossary Term', async () => {
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary1.data.name);
+      await selectActiveGlossary(page1, glossary1.data.displayName);
       await verifyTaskCreated(
         page1,
         glossary1.data.fullyQualifiedName,
@@ -454,7 +454,7 @@ test.describe('Glossary tests', () => {
       );
       await redirectToHomePage(page1);
       await sidebarClick(page1, SidebarItem.GLOSSARY);
-      await selectActiveGlossary(page1, glossary1.data.name);
+      await selectActiveGlossary(page1, glossary1.data.displayName);
 
       const taskResolve = page1.waitForResponse('/api/v1/feed/tasks/*/resolve');
       await page1

openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts

@@ -63,10 +63,18 @@ export const checkName = async (page: Page, name: string) => {
 
 export const selectActiveGlossary = async (
   page: Page,
-  glossaryName: string,
+  glossaryLabel: string,
   bWaitForResponse = true
 ) => {
-  const menuItem = page.getByRole('menuitem', { name: glossaryName }).first();
+  const sidebar = page.getByTestId('glossary-left-panel');
+  await sidebar.locator('[role="menuitem"]').first().waitFor();
+
+  const menuItem = sidebar.getByRole('menuitem', {
+    name: glossaryLabel,
+    exact: true,
+  });
+  await menuItem.waitFor({ state: 'visible' });
+
   const isSelected = await menuItem.evaluate((element) => {
     return element.classList.contains('ant-menu-item-selected');
   });
@@ -259,6 +267,8 @@ export const createGlossary = async (
 
   await page.fill('[data-testid="name"]', glossaryData.name);
 
+  await page.fill('[data-testid="display-name"]', glossaryData.displayName);
+
   await page.locator(descriptionBox).fill(glossaryData.description);
 
   await expect(
@@ -322,7 +332,7 @@ export const verifyGlossaryDetails = async (
   glossaryDetails: GlossaryData
 ) => {
   await page
-    .getByRole('menuitem', { name: glossaryDetails.name })
+    .getByRole('menuitem', { name: glossaryDetails.displayName, exact: true })
     .locator('span')
     .click();
 
@@ -761,7 +771,7 @@ export const createGlossaryTerms = async (
   page: Page,
   glossary: GlossaryData
 ) => {
-  await selectActiveGlossary(page, glossary.name);
+  await selectActiveGlossary(page, glossary.displayName ?? glossary.name);
 
   const termStatus = glossary.reviewers.length > 0 ? 'Draft' : 'Approved';