Skip to content

Commit d4e5cc3

Browse files
committed
MINOR - Fix RDF CI & repository cleanup
1 parent 326921e commit d4e5cc3

5 files changed

Lines changed: 16 additions & 194 deletions

File tree

.github/workflows/maven-postgres-rdf-tests-build.yml

Lines changed: 0 additions & 168 deletions
This file was deleted.

openmetadata-service/src/main/java/org/openmetadata/service/rdf/RdfRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ public String executeSparqlQueryWithInference(
620620
};
621621

622622
if (level == org.openmetadata.service.rdf.reasoning.InferenceEngine.ReasoningLevel.NONE) {
623-
return executeSparqlQuery(query, format);
623+
return executeSparqlQueryDirect(query, format);
624624
}
625625

626626
// For inference queries, we need to work with the full model

openmetadata-service/src/test/java/org/openmetadata/service/OpenMetadataApplicationTest.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@
9494
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
9595
public abstract class OpenMetadataApplicationTest {
9696
protected static Boolean runWithOpensearch = false;
97+
protected static Boolean runWithRdf = false;
9798

9899
protected static final String CONFIG_PATH =
99100
ResourceHelpers.resourceFilePath("openmetadata-secure-test.yaml");
@@ -552,13 +553,10 @@ private static void setupRedisIfEnabled() {
552553
}
553554

554555
private static void setupRdfIfEnabled() {
555-
String enableRdf = System.getProperty("enableRdf");
556-
String rdfContainerImage = System.getProperty("rdfContainerImage");
557-
if ("true".equals(enableRdf)) {
558-
LOG.info("RDF is enabled for tests. Starting Fuseki container...");
559-
if (CommonUtil.nullOrEmpty(rdfContainerImage)) {
560-
rdfContainerImage = "stain/jena-fuseki:latest";
561-
}
556+
if (Boolean.TRUE.equals(runWithRdf)) {
557+
String rdfContainerImage = System.getProperty("rdfContainerImage", "stain/jena-fuseki:5.0.0");
558+
LOG.info(
559+
"RDF is enabled for tests. Starting Fuseki container with image: {}", rdfContainerImage);
562560

563561
try {
564562
RDF_CONTAINER =
@@ -588,6 +586,7 @@ private static void setupRdfIfEnabled() {
588586
configOverrides.add(ConfigOverride.config("rdf.username", "admin"));
589587
configOverrides.add(ConfigOverride.config("rdf.password", "test-admin"));
590588
configOverrides.add(ConfigOverride.config("rdf.baseUri", "https://open-metadata.org/"));
589+
configOverrides.add(ConfigOverride.config("rdf.dataset", "openmetadata"));
591590

592591
LOG.info("RDF configuration overrides added");
593592
} catch (Exception e) {
@@ -596,7 +595,8 @@ private static void setupRdfIfEnabled() {
596595
configOverrides.add(ConfigOverride.config("rdf.enabled", "false"));
597596
}
598597
} else {
599-
LOG.info("RDF not enabled for tests (enableRdf={})", enableRdf);
598+
LOG.info("RDF not enabled for tests (runWithRdf={})", runWithRdf);
599+
configOverrides.add(ConfigOverride.config("rdf.enabled", "false"));
600600
}
601601
}
602602

openmetadata-service/src/test/java/org/openmetadata/service/resources/rdf/RdfResourceTest.java

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,25 @@
2525
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
2626
public class RdfResourceTest extends OpenMetadataApplicationTest {
2727

28+
static {
29+
// Enable RDF for these tests
30+
runWithRdf = true;
31+
}
32+
2833
// RDF type for Table entities (from RdfUtils.java)
2934
private static final String TABLE_RDF_TYPE = "dcat:Dataset";
3035

3136
private TableResourceTest tableResourceTest;
3237

3338
@BeforeAll
3439
public void setup(TestInfo test) throws URISyntaxException, IOException {
35-
// Skip setup if RDF is not enabled
36-
if (!"true".equals(System.getProperty("enableRdf"))) {
37-
return;
38-
}
3940
// Initialize the TableResourceTest helper for creating entities
4041
tableResourceTest = new TableResourceTest();
4142
tableResourceTest.setup(test);
4243
}
4344

4445
@Test
4546
void testEntityStoredInRdf(TestInfo test) throws Exception {
46-
if (!"true".equals(System.getProperty("enableRdf"))) {
47-
return; // Skip if RDF is not enabled
48-
}
49-
5047
// Create a table
5148
CreateTable createTable =
5249
tableResourceTest.createRequest(test.getDisplayName() + "_rdf_storage");
@@ -58,10 +55,6 @@ void testEntityStoredInRdf(TestInfo test) throws Exception {
5855

5956
@Test
6057
void testMultipleEntitiesStoredInRdf(TestInfo test) throws Exception {
61-
if (!"true".equals(System.getProperty("enableRdf"))) {
62-
return; // Skip if RDF is not enabled
63-
}
64-
6558
// Create multiple tables
6659
CreateTable createTable1 =
6760
tableResourceTest.createRequest(test.getDisplayName() + "_rdf_multi1");
@@ -78,10 +71,6 @@ void testMultipleEntitiesStoredInRdf(TestInfo test) throws Exception {
7871

7972
@Test
8073
void testEntityDeleteFromRdf(TestInfo test) throws Exception {
81-
if (!"true".equals(System.getProperty("enableRdf"))) {
82-
return; // Skip if RDF is not enabled
83-
}
84-
8574
// Create a table
8675
CreateTable createTable =
8776
tableResourceTest.createRequest(test.getDisplayName() + "_rdf_delete");

openmetadata-service/src/test/java/org/openmetadata/service/util/RdfTestUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ private RdfTestUtils() {
2626
* Check if RDF is enabled for the current test run
2727
*/
2828
public static boolean isRdfEnabled() {
29-
return "true".equals(System.getProperty("enableRdf"));
29+
RdfRepository repository = RdfRepository.getInstance();
30+
return repository != null && repository.isEnabled();
3031
}
3132

3233
/**

0 commit comments

Comments
 (0)