fix(ui): logout should clear all the stale state and clear tokens

Author: chirag-madlani

openmetadata-ui/src/main/resources/ui/src/components/Auth/AuthProviders/AuthProvider.tsx

@@ -81,6 +81,7 @@ import {
 import { getPathNameFromWindowLocation } from '../../../utils/RouterUtils';
 import { escapeESReservedCharacters } from '../../../utils/StringsUtils';
 import {
+  clearOidcToken,
   getOidcToken,
   getRefreshToken,
   setOidcToken,
@@ -264,7 +265,7 @@ export const AuthProvider = ({
 
   const resetUserDetails = (forceLogout = false) => {
     setCurrentUser({} as User);
-    setOidcToken('');
+    clearOidcToken();
     setRefreshToken('');
     setIsAuthenticated(false);
     setApplicationLoading(false);

openmetadata-ui/src/main/resources/ui/src/utils/SwTokenStorageUtils.ts

@@ -67,6 +67,21 @@ const setAppState = async (state: AppState): Promise<void> => {
   }
 };
 
+const clearAppState = async (): Promise<void> => {
+  try {
+    if (isServiceWorkerAvailable()) {
+      await swTokenStorage.removeItem(APP_STATE_KEY);
+    } else {
+      // Fallback for browsers that don't support SW/IndexedDB
+      localStorage.removeItem(APP_STATE_KEY);
+    }
+  } catch {
+    // Storage failures are intentionally ignored to prevent auth flows from breaking.
+    // Token persistence is treated as "best effort" - if storage fails, the user
+    // may need to re-authenticate, but core functionality continues working.
+  }
+};
+
 export const getOidcToken = async (): Promise<string> => {
   try {
     const state = await getAppState();
@@ -110,3 +125,13 @@ export const setRefreshToken = async (token: string): Promise<void> => {
     // may need to re-authenticate, but core functionality continues working.
   }
 };
+
+export const clearOidcToken = async (): Promise<void> => {
+  try {
+    await clearAppState();
+  } catch {
+    // Storage failures are intentionally ignored to prevent auth flows from breaking.
+    // Token persistence is treated as "best effort" - if storage fails, the user
+    // may need to re-authenticate, but core functionality continues working.
+  }
+};