Skip to content

Commit 70fc7cb

Browse files
Rohit0301Copilot
andauthored
Fixed flaky entity data steward spec (#27829)
* Fixed entity data steward spec Co-authored-by: Copilot <copilot@github.com> * fixed all the utils function --------- Co-authored-by: Copilot <copilot@github.com>
1 parent 01936b6 commit 70fc7cb

1 file changed

Lines changed: 29 additions & 3 deletions

File tree

  • openmetadata-ui/src/main/resources/ui/playwright/utils

openmetadata-ui/src/main/resources/ui/playwright/utils/entity.ts

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -918,6 +918,12 @@ export const removeTag = async (page: Page, tags: string[]) => {
918918
await page.getByTestId('saveAssociatedTag').click();
919919
await patchRequest;
920920

921+
await page
922+
.getByTestId('saveAssociatedTag')
923+
.locator('[data-icon="loading"]')
924+
.waitFor({ state: 'detached' });
925+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
926+
921927
await expect(
922928
page
923929
.getByTestId('KnowledgePanel.Tags')
@@ -969,6 +975,12 @@ export const removeTagsFromChildren = async ({
969975

970976
await patchRequest;
971977

978+
await page
979+
.getByTestId('saveAssociatedTag')
980+
.locator('[data-icon="loading"]')
981+
.waitFor({ state: 'detached' });
982+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
983+
972984
await expect(
973985
page
974986
.locator(`[${rowSelector}="${rowId}"]`)
@@ -1022,9 +1034,11 @@ export const assignGlossaryTerm = async (
10221034
.click();
10231035

10241036
await patchRequest;
1025-
await expect(
1026-
page.getByTestId('custom-drop-down-menu').getByTestId('saveAssociatedTag')
1027-
).not.toBeVisible();
1037+
await page
1038+
.getByTestId('saveAssociatedTag')
1039+
.locator('[data-icon="loading"]')
1040+
.waitFor({ state: 'detached' });
1041+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
10281042

10291043
await expect(
10301044
page
@@ -1244,6 +1258,12 @@ export const removeGlossaryTerm = async (
12441258
.click();
12451259
await patchRequest;
12461260

1261+
await page
1262+
.getByTestId('saveAssociatedTag')
1263+
.locator('[data-icon="loading"]')
1264+
.waitFor({ state: 'detached' });
1265+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
1266+
12471267
await expect(
12481268
page
12491269
.getByTestId('KnowledgePanel.GlossaryTerms')
@@ -1297,6 +1317,12 @@ export const removeGlossaryTermFromChildren = async ({
12971317

12981318
await patchRequest;
12991319

1320+
await page
1321+
.getByTestId('saveAssociatedTag')
1322+
.locator('[data-icon="loading"]')
1323+
.waitFor({ state: 'detached' });
1324+
await expect(page.getByTestId('saveAssociatedTag')).not.toBeVisible();
1325+
13001326
await expect(
13011327
page
13021328
.locator(`[${rowSelector}="${rowId}"]`)

0 commit comments

Comments
 (0)