Skip to content

Commit 6fdc353

Browse files
MINOR - Prepare extra validations for system repository health (#24846)
* MINOR - Prepare extra validations for system repository health * Update generated TypeScript types --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent 6d953d8 commit 6fdc353

4 files changed

Lines changed: 7 additions & 11 deletions

File tree

docker/development/docker-compose-fuseki.yml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,9 @@ services:
1919
memory: 4G
2020
reservations:
2121
memory: 2G
22-
networks:
23-
- app_net
2422
# Create the database directory before starting Fuseki
2523
entrypoint: /bin/sh -c "mkdir -p /fuseki/databases/openmetadata && exec /docker-entrypoint.sh /jena-fuseki/fuseki-server --update --loc=/fuseki/databases/openmetadata /openmetadata"
2624

2725
volumes:
2826
fuseki-data:
2927
driver: local
30-
31-
networks:
32-
app_net:
33-
driver: bridge
34-
ipam:
35-
driver: default
36-
config:
37-
- subnet: 172.16.240.0/24

openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/SystemRepository.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -525,9 +525,14 @@ public ValidationResponse validateSystem(
525525
validation.setLogStorage(logStorageValidation);
526526
}
527527

528+
addExtraValidations(applicationConfig, validation);
529+
528530
return validation;
529531
}
530532

533+
public void addExtraValidations(
534+
OpenMetadataApplicationConfig applicationConfig, ValidationResponse validation) {}
535+
531536
private StepValidation getDatabaseValidation(OpenMetadataApplicationConfig applicationConfig) {
532537
try {
533538
dao.testConnection();

openmetadata-spec/src/main/resources/json/schema/system/validationResponse.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,5 +53,5 @@
5353
"$ref": "#/definitions/stepValidation"
5454
}
5555
},
56-
"additionalProperties": false
56+
"additionalProperties": true
5757
}

openmetadata-ui/src/main/resources/ui/src/generated/system/validationResponse.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ export interface ValidationResponse {
3838
* Search instance connectivity check
3939
*/
4040
searchInstance?: StepValidation;
41+
[property: string]: any;
4142
}
4243

4344
/**

0 commit comments

Comments
 (0)